From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71544EB64D9 for ; Mon, 3 Jul 2023 03:25:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AEDE8E008D; Sun, 2 Jul 2023 23:25:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65E7A8E007C; Sun, 2 Jul 2023 23:25:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 526998E008D; Sun, 2 Jul 2023 23:25:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3DC6E8E007C for ; Sun, 2 Jul 2023 23:25:11 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0EED4AFE6C for ; Mon, 3 Jul 2023 03:25:11 +0000 (UTC) X-FDA: 80968859622.27.6F0A1F1 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf02.hostedemail.com (Postfix) with ESMTP id E6B1F80006 for ; Mon, 3 Jul 2023 03:25:07 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688354709; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zhvxshNL+NIgKIYjtQFzMSKr7ej+Cmtyqt2+wyqHGrc=; b=cPi151brmJKT6U8hTdALGbCwKO6/zwU+ak/8MuCNInPs9eeoKVIgwslcrQZvXZasDZIB24 90f8sBPhQZ3Qg5YAH8URBNv2+yfexcEeBm7x8kO4s14MBpu3ePCBvXqHyTBoO40xyCnYuz 2su69Ca9lMxXoXMQ/u++wWdDZP0aNyQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688354709; a=rsa-sha256; cv=none; b=a8V04GeqqltkqFaV83BIWTSNaO9BWLBiBtPWUyaRKwe1ApDOQ09LWRPrg5xzX2mvJcmClq n/RHCGNtkto1SUtm1uTHWT660FfOeh/vExRRDzaUVizG2NeyIqxL/g4KnWPJbEAfNwKn2o 4UFh/OreQ+YxymKO6ZOkC9QcHyraGbI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QvWSQ1FxWztQv8; Mon, 3 Jul 2023 11:22:14 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 3 Jul 2023 11:25:03 +0800 Subject: Re: [PATCH] memory tier: Use helper function destroy_memory_type() To: "Huang, Ying" CC: , , , Aneesh Kumar K.V References: <20230626121053.1916447-1-linmiaohe@huawei.com> <873525k9tt.fsf@yhuang6-desk2.ccr.corp.intel.com> <87y1jxitg9.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Miaohe Lin Message-ID: <7da17dc7-b226-3a22-b13b-c2e6c6365c5d@huawei.com> Date: Mon, 3 Jul 2023 11:25:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <87y1jxitg9.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Stat-Signature: ewqgrw9wryercdkpct1t1mrc6nif7wnf X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E6B1F80006 X-Rspam-User: X-HE-Tag: 1688354707-319610 X-HE-Meta: U2FsdGVkX1+egpbjL7FpdcmLLnLYXDb1dmitzKDOSuNy0gpnnZdVh329l8YhbcQl3XheeIbyaY9jWv+fXgfIMXMUyTsvzmLDI14LIxmZcsxlIVmjNJxXa1ymnmqdqdGWHZFavwKmH03BcZKmOT8FGM2WwjHIh+p14wPRnFLtg0ONz6F/UUHx+kRFBtxDo8CP8nzkxloZ6ldb8QOx9aE3M1lUoumn1wkO1k3mFAwoiPeKLp0QlqYeMDivH65B1s2Mj4GXtKnLyaX/ljncnDFhDd4c53yMSQKZshgfNd3VDwC63TIaeXmNv0i+AKsXtTOio/I40cuIxV/56jRsDy6pk1o1puI0bGZWTlwI7dJI6fiKJsfDLtPxaF2Ir1GfV1wmjVvXp+T9hD8OrQH05Mkz3ISEPOXZLzLrpp2kqUTK8PqiFBp/6T40kcd6Nay/aAAB8yPGGkuU9iVJDFM6eRoA4LDYBR180MnEEcT4ClhKyRPTH5RsTMqe9EJBsjQVLsSGTXUPfgX2oz3Vh1yZ6S3RD40pv6QN2E7M/YB0020igWSyGFbYhge+m0W1r0I4wGIjAZmuunGGcd7yAhsoi0qsFQlmeltjKVdkr5SqHDwrQFiUvnTYenZmjHSyRCk6b0QXHb9RG8sUYWpbnJcs3pKbd6vRSmrLLkwWthtG0cwZIa3YB8K5Va3vmzB6o7tW2X6CzxMX1MwyZuiL7rjyqTuMS4jFOBAKeYZTS/c6oS3PHYeneAglqzLCTUoDR0dSSAr7ciSHwDeRjhpNDo9gkd4azm6DsWQ4J+ZyH8hVQqaSvNf3RVmQOBaO7hqb3koB0Zj2+frqqU27+ubwnSZFCxVdc2TOHli9eJ9zJ30vkgUjp/fnRxlxzoxnDR1iALhUzHgVHh5Mcqh13Id0mCy9GOokL0gX1sW9TxXXBk49+/jZkFmenqvuYevvvDGVU8qRiaL0GgOXxuoEHBB/RtLlZ0u 5mnCw+AH cUrPS1NgbkQufIAifTUtE1WSRE9T7QGnXw5U4Oq1JeX/Vr2RAzvG+MjntIFRq8Nf/E2Xtjoe5eF2kd4jAmkBmQ0pJTnihVG1j2GRU5/Br1JPE0HmYx+y0mjMSsRV+d06ZxfvKkrc0jHTzL7YjG7JPoeK80vLqU114xYdtvO31qTaynkwhOr1OXuxNK7U1/8o9oRWkNWXBrjIUx08= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/3 11:07, Huang, Ying wrote: > Miaohe Lin writes: > >> On 2023/7/3 10:28, Huang, Ying wrote: >>> Miaohe Lin writes: >>> >>>> Use helper function destroy_memory_type() to release memtype instead >>>> of open code it to help improve code readability a bit. No functional >>>> change intended. >>>> >>>> Signed-off-by: Miaohe Lin >>>> --- >>>> mm/memory-tiers.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c >>>> index e593e56e530b..0b8b76078c12 100644 >>>> --- a/mm/memory-tiers.c >>>> +++ b/mm/memory-tiers.c >>>> @@ -587,7 +587,7 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype) >>>> */ >>>> if (!node_memory_types[node].map_count) { >>>> node_memory_types[node].memtype = NULL; >>>> - kref_put(&memtype->kref, release_memtype); >>>> + destroy_memory_type(memtype); >>> >>> Not need to be changed in this patch. It appears that >>> destroy_memory_type() isn't a very good name, because we usually will >>> not free the memory_type here. Rename it to "put_memory_type()"? >> >> Do you mean rename destroy_memory_type to put_memory_type in a >> separate patch? > > Yes. > >> This sounds reasonable to me. But destroy_memory_type is a >> EXPORT_SYMBOL_GPL symbol, is it fine to do the rename work? > > I think so. This isn't a kernel ABI. And not many people use it now. Will do it. Thanks for your advice. > > Best Regards, > Huang, Ying > > > . >