From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD4FAC369C2 for ; Tue, 22 Apr 2025 11:11:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22C066B0008; Tue, 22 Apr 2025 07:11:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B66E6B000A; Tue, 22 Apr 2025 07:11:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 056B86B000C; Tue, 22 Apr 2025 07:11:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DBF536B0008 for ; Tue, 22 Apr 2025 07:11:14 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4A2101208A1 for ; Tue, 22 Apr 2025 11:11:15 +0000 (UTC) X-FDA: 83361413310.05.0193F8B Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 738C320002 for ; Tue, 22 Apr 2025 11:11:13 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745320273; a=rsa-sha256; cv=none; b=KZzJHwGsW+DmiGZMv2gzHHYRRtGt1wcgbNrrNL29Ob/KEsh5dc5ZVHMHkIRe85W2nk5zUv uoXlTzMFWyuZ7vdT8YhiLf/nc9Rl9pcz9MQEjke7TH/fHYeJRJ4aPDFLScEEdlWt4HxxPf 5dCM+iaiKm6LP+tk3xWtUAkg2U4Zb2s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745320273; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BF78oZ6CIn/yHMvFYPafTYYSm0NrkNUuFI4WACHtcNs=; b=yTeQyTTS7Ic/xb81ff0prXFI2nmGncmXtRnTRMQCcqoBEDkmG3agS+jY7PNrqPkgxmX9GP vbajnztvwpk81CNDCugBjEPY02fxneJrv40spz8DYjCTuJ1wce1iMXJXgkoco4LwMDXnJV gDdPD4kbtzj1bQUw6k0WIefDA1TWEYs= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 53A8D152B; Tue, 22 Apr 2025 04:11:08 -0700 (PDT) Received: from [10.57.90.106] (unknown [10.57.90.106]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E38F83F5A1; Tue, 22 Apr 2025 04:11:09 -0700 (PDT) Message-ID: <7d9f87cc-c891-4845-a917-c1d9b606bea9@arm.com> Date: Tue, 22 Apr 2025 12:11:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] tools/selftests: expand all guard region tests to file-backed Content-Language: en-GB To: Lorenzo Stoakes Cc: Andrew Morton , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Vlastimil Babka , "Paul E . McKenney" , Jann Horn , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shuah Khan , linux-kselftest@vger.kernel.org, linux-api@vger.kernel.org, John Hubbard , Juan Yescas , Kalesh Singh References: <7d5e0f61-66d9-471c-b6ef-bf68dbffa614@lucifer.local> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 738C320002 X-Stat-Signature: 9n1gtq9oe8w8bayifhstgfd3q95s8fb1 X-Rspam-User: X-HE-Tag: 1745320273-308232 X-HE-Meta: U2FsdGVkX1/9/o0VgApzxCN58acTq7+ZJmWVXd5uVoxPSxbj1OVqQBGfj4cCxJ/kvWoAt++uL/Kf2tFxMrn9nZjeRj02RyvsneYot+O6v4mfvqmeE+ZKFUGlfywTBKybFMbyoU6F2n9uAFeSVpU6WzJMuCgSFr1Lw48rA0k8C8sntucpsfT4msVo+axE6nD9wjgqWAqf2i8JcPZiMZzfi+WIRUSw/sGjRJM+1zjbm1dBG5hw7irCTO2LBf5KOCrFAAvKMxSvXtEv9Y/IlykVne3FJ+oubAdWrL/xeA2X4WzetN6R1bREqOto98h+JcMxaUbAzzEuUVPZtxqNy2Mqb+Sj9bw8m25BuAne+q1iIIERFsrJZLggN1v2k4EWu6Fj5/q0ERdj5mPxEcIQK5zlzZGYZf8vXSvMEukHYK+iTIxDTnqPC1LX4hd5zSFgKfUUsgZLAv8zlEmdV25CDMypC/qUibeWyvoLM4RBOsoAqx8w79Gpci6HBg/9msy1SEB2ViOX8V2g98fvVlJP9FkzW1W5u+lQPttqMoVTB+8ehZD91AEliWi7xsrH+rWxt+SgBEXO2DGr1j1yxILb3OVFTGYNd9NQEpPjhSsJl+SVH+FlAV6i1yEg5zvC229tthN33F2PmjHsgvl9b8P9ht928kY5+eqieclO+Kc7Cd/+OZjEcPypLPYt7wO5EGI5E63bGvy4Ag7e3AKkjUo2n7kTocf6071U3ws7uA4a2tnfshk+Tsr7h7TD6jInLXD/mlm0d2KH5qGH0SA8q9zqnStqV+aw629m6pxDL2Jl2SD7q7mnVsD9SlUuBRMQjMcsQpPnupGGeuLTZr45TpimjvbFayJXummwmDlINm591EBGG61cx2onmkqxanPJ1mgNqBL8INDMP4XrSHD9/lD83rhXCgHASeFuzd8ZCBYdpeRPhdbT/R5ExNM7Ujxin40NsvKqrpO4BjrJVm94FziQYMW lzDOf0EL heY6CXTnW7mhtdKwNd4Ont/LrnfLOxzZSygdDPvS8RtZ5BYVU0+4hz2E1i38K0EyhqRxNIaHFNDi1hErfTF6XW9F90AK51zoeFZK/6taDsKcpvjMkbhegWQmLUnYvyjwehRcKq9I/4Gzg84B2MOcZS54K/w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22/04/2025 12:07, Lorenzo Stoakes wrote: > On Tue, Apr 22, 2025 at 12:03:08PM +0100, Ryan Roberts wrote: >> On 22/04/2025 11:47, Lorenzo Stoakes wrote: >>> On Tue, Apr 22, 2025 at 11:37:57AM +0100, Ryan Roberts wrote: > > [snip] > >>>> >>>> Hi Lorenzo, >>>> >>>> I'm getting a test failure in v6.15-rc3 on arm64: >>>> >>>> ----8<---- >>>> # RUN guard_regions.shmem.uffd ... >>>> # guard-regions.c:1467:uffd:Expected ioctl(uffd, UFFDIO_REGISTER, ®) (-1) == >>>> 0 (0) >>>> # uffd: Test terminated by assertion >>>> # FAIL guard_regions.shmem.uffd >>>> not ok 45 guard_regions.shmem.uffd >>>> ----8<---- >>>> >>>> The ioctl is returning EINVAL. >>> >>> Hm strange, that works fine on x86-64. Is >>> userfaultfd enabled in your config, to ask a silly question? >> >> Yep, and the anon version of the test is passing, as are all the uffd tests. >> >>> >>> It'd be odd for this to vary depending upon arch. >>> >>> So a factor here is a _stupidity_ in the testing - does your system mount /tmp >>> as tmpfs or an actual file system? As the test code unconditionally assumes /tmp >>> is indeed going to get you a shmem file. >> >> Ahh that's probably it. I'm on Ubuntu and it looks like /tmp is just a dir on >> the rootfs (XFS in my case). >> >> Forcing a tmpfs to /tmp solved it. >> >> Looks like uffd-unit-tests (see shmem_allocate_area()) is just using memfd. >> Would it be reasonable to take that approach? Or just use anon+shared via mmap? > > Yeah could be either memfd or MAP_ANON | MAP_SHARED. I think I did it this > way to make the code a little easier given all the variant stuff. > > Unless you felt especially keen, I can add fixing this to my todos :) I'm not keen, but if it lingers I might have a crack. Otherwise it's just more noise to ignore when I'm running tests... > > Sorry about this! Entirely my fault, knew it wasn't ideal when I wrote it, > but with test code sometimes you (perhaps incorrectly) tolerate things you > wouldn't elsewhere... No problem; I would have done the same thing. Given we know the root cause is a test issue, this is not a high priority issue from my perspective. > > Cheers, Lorenzo > >> >> Thanks, >> Ryan >> > > [snip]