From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1B8BC02198 for ; Fri, 14 Feb 2025 23:48:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81B99280002; Fri, 14 Feb 2025 18:48:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CC68280001; Fri, 14 Feb 2025 18:48:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BB64280002; Fri, 14 Feb 2025 18:48:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4B4B0280001 for ; Fri, 14 Feb 2025 18:48:44 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 00DCC80B6F for ; Fri, 14 Feb 2025 23:48:43 +0000 (UTC) X-FDA: 83120192568.12.AF348B9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 3069C1C0002 for ; Fri, 14 Feb 2025 23:48:40 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CZyXFSNV; spf=pass (imf21.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739576921; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K6phXu4+Pf0qom22NaynRbMF2gFKCZhD3gI+zjKxLEs=; b=dgYExz0S8BVIsNwTu4epCijy3x97OaDEZOjcHyaYZ6pNG97nrb1HWTvgNZ1XVkyt7SkfF/ i/Fpfg6HW921vvarlRm4IAz8IsP+SoG/ZW1S2Nwdh/whC7Jdxqs6cd8ve4QK/GZYCGuQWS ABimN7xj8mxLhK0udsq3JmGtiaDm0iY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CZyXFSNV; spf=pass (imf21.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739576921; a=rsa-sha256; cv=none; b=ypvGImWz6EXqUA+/rBbLs3Env7+KTqffMdZBRHUclqdh4j9E9nyzRCwzFIGzRjZnfypagT XwIJH12NogEj1PkztUwBZJXJVG0JDLQGq8Y8widv1X87R5V+XHqFmsMVfaTSEMgv8Riufv JasjQTnXCaIRDr6mX9QGEAqOawc0HW8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739576919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K6phXu4+Pf0qom22NaynRbMF2gFKCZhD3gI+zjKxLEs=; b=CZyXFSNV/aIyPBS8ez0KDSrnlU9YgI4lDGk+sDtbNzjZX1hfylZer346ZQi27Gcs58Q/s3 qpVNIxuHGPerckatqGGXzsUPZx/nNon7TZibinhW0sYKYoYSYJMwIVjIZoyDWr4yr08O6W BLN0jrj5kSOp9fHq7QqoH3Fo18x3PXM= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-437-YZLipE50MKS2-uVxsGnpmA-1; Fri, 14 Feb 2025 18:48:37 -0500 X-MC-Unique: YZLipE50MKS2-uVxsGnpmA-1 X-Mimecast-MFC-AGG-ID: YZLipE50MKS2-uVxsGnpmA_1739576917 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-220e62c4f27so52164315ad.0 for ; Fri, 14 Feb 2025 15:48:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739576917; x=1740181717; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K6phXu4+Pf0qom22NaynRbMF2gFKCZhD3gI+zjKxLEs=; b=ShX4CGDE1D7QQWMZY/Xg5EjPqr2eFx8anRBOfgMA5EhQ2w9hIAkE6q8KLj9q2eOtk/ D//2UqGKU3/2GqhL7gh72mnrUJqhw0oyTkH3JhuPG6jKyig5hYWC8k126Nrq8Z/NI5CY Mauh0dlmcO/Idk2py5TxWdWGPa0t04XRoENQg3w8LeNEEUk438Tepd5zCJUpiExw+l7s K5Q3AkwdevknIwlCg2MWt28h10RnUjCjKHYlU4EWXdnPYAZ5ll+OJYvHktYCssazlO38 Bkuzr2BTbZgiMONb4FwSP/hIHWtGQmh5fHEQAxCl/F/AatG16qJTYj6kypvfVc9Sf8aW 0XhA== X-Forwarded-Encrypted: i=1; AJvYcCUPqs6vKjtsgQzwfBUgL2fjZjmLTfVMxqSPtcTZ0PR/9K5mxUl0U4+Jby4jeb5MT2H9S5GBZuxO6g==@kvack.org X-Gm-Message-State: AOJu0Ywod05L6KPKbYiHPGByomxnABrEP73w3NfPhOsIni4l+lqE/35D ijifNQBlfogOf47B1fgC/62XFsReBUX4AIDu0Ml6BqbbFV7quFPs9Do6Ovn6CUGOM0k62jcmR2e ChsdULwVvp4qqjw/MDOGKTE9uM48YeREJfx9zCpo3crskobG5 X-Gm-Gg: ASbGncvC5lA5dUQ+021TFQdk7hRz0JH5fc5RFuTgGCdUQj+7uPzYeC+XTjBU1bO5O2E 3Pj8dsJc8otveySXVSWEq9SRu/+1sC570gGyBOWqLQVomigdjSgvLPR0tDfUu5lehcxNu71EgyX m5Lr6+TlsME5prSAbED9tc/NHvYtluLIuOi12DC1lbfxTiXvaXQDT41PGmZKo1+8mIrKQF/RdV9 oKB1f/m3Xk+1uWwwWPYndvR1EGHaZOujy3Av67Ut4RAG544lE9vXwOgj3WBOLxyiltOk7sZV/lA 6O4H9A== X-Received: by 2002:a17:902:d542:b0:215:f1c2:fcc4 with SMTP id d9443c01a7336-221040bc31bmr19217775ad.41.1739576916721; Fri, 14 Feb 2025 15:48:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IHRyGtDSqzej/ErHH5h6imPG+tPqnBrUyq+pULBF1AEJ4qdGua+o5pwJZME07H5eRAbT6hSGA== X-Received: by 2002:a17:902:d542:b0:215:f1c2:fcc4 with SMTP id d9443c01a7336-221040bc31bmr19217475ad.41.1739576916420; Fri, 14 Feb 2025 15:48:36 -0800 (PST) Received: from [192.168.68.55] ([180.233.125.64]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d558ee0bsm34340145ad.236.2025.02.14.15.48.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Feb 2025 15:48:35 -0800 (PST) Message-ID: <7d9d0ba9-a503-4009-8dd9-ded51c620128@redhat.com> Date: Sat, 15 Feb 2025 09:48:31 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] drivers/base/memory: Simplify add_boot_memory_block() To: David Hildenbrand , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org, akpm@linux-foundation.org References: <20250214063504.617906-1-gshan@redhat.com> <20250214063504.617906-2-gshan@redhat.com> From: Gavin Shan In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XjPSUzgUX5UcDIsHkqMTJ3g_xQy1vi5rvD94Ax8ODM4_1739576917 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 3069C1C0002 X-Stat-Signature: aqxomptazbk46b14o7xzsiucumj5deyp X-Rspamd-Server: rspam03 X-HE-Tag: 1739576920-159227 X-HE-Meta: U2FsdGVkX1+YgCowXFjWKomXxgJcIdU6trsOXC7AP6VhBfy/h6Po66UzQEPFHgVtIjaw8R/O0viWnVRIj1v4O0AXQjBjaI3oFs/W+8iuXWqRbadU9PCu3bPS8chM5u5rTrg/wXFByAc18EeJn2Nv/4/n7Ber9MOWtNHaRQNbOH3spy1H51XUY3GZ2eXWxe8dPRsUwHmrdYK6DpUeG+G/RJ/yyp5XrN9i7GhH70z8zBHej+yYvlbH2Bdq5YWCDj3vzbpIwuC+09WtNT3is8iiRN1+8JYo4rBV4N3uhgo9lQnPc9s8Qhp07o2kNbPaB3x2YWyHFEDe29Y+EWVRja2O4wlD86xicICpMfBpkxDkzoSSWqBvNGw8Jwu1keftQ5q3TzbpJri8WZuzcUTgbOpMR7pKE3PpZaEXhuIECzOeo155ZeX6a6ZIIO+Qcw2YWz+VdWySQaJTmjJL8y6fNYOvE2VDz2VyhVY4SB12kHL7oOtBNf9cEF6sil5TWi6S2axmN3+k9Ikl2Z/mGWfpD+1A+VRXDkIshhlfbOFqqsIp+QHh/M5Q/3T0xqoQbAKMTYG5wO3iAJTGvvIZEDqSS320mrdQesIrBipuF8PI0nm9EbQKkaoBP/pXsr0v2EI0RA8RV8FUfsHjMx0bx5VigD0Z1uI3hHTyjJRmIxngj1mzGLEl+HXh2G/Pb7URozMZOUa8NBD8NhRPJHnDJETRF5HjNQJePiGk7vS9atkgU8sdPiTFZA/n2Z1Es00ky8cHcaeSW0KlD43rsQtwvz8IhGZP+jvOAPS1UxZ2R2wLU5MzvzGUTYxA+Axk+ZEMv6ItAYZ3DYNPLUq2zRhgbyqNwVku0BTuND804IgJBpSkWItEl8q0M8ICHXhV+qZMTJ/pTqwjkGcp1/ZBx/KeAg5PTyh6p+ySfRp370zTBgBx6nDDop7alljzDgLwVJBDwJm18XMqQWn+PTaFsRJCcJ/N6Eo J2Fv9DJG hZ8bGc6/UZECZF5igvmswqWrb44xZZW1AiPVz0VaEsC9dK8Cfl6vD9Y+BwxyWSw/3WANnhMeJwxr+meC2XT+eOkC7G/sfMOR+GOrJdUlD7WGilAP9hnJr6AAVlmFiEZ6vmkIe9m98gU2whcleAzQWBT23oEjgwhIMfvAACs2EPS/GWxwIoZLZ5PLn+Vi4Q340Tkiw6GqxoDgTkyCPdGjJN6Xugk3NocrewCdzSCGeXLC4KfYcdiY4HHtWczLPjiAD2q246ZBCkZUyRZbUrZEMkZN1McbPJtIGE+jeaf+ZQtTrv6yVuCWs+QiCA4ZHfckxDOAYfb2e33HhHM1tjhTS8+Z5VIZ4BZpmupqRS1ZyQh1/ZdOedwk8M+iZk7x2iVeW6eJlYs0Q62QYyFZhwbXelCwCAI3iSRBL1q6xzMse8zyYGvpNYibk+a5ZRsJnRM6IWTQBMV3j+TjNvdh5WoXIqeeP2eMWbxB1OXaH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/14/25 5:53 PM, David Hildenbrand wrote: > On 14.02.25 07:35, Gavin Shan wrote: >> It's unnecessary to keep the variable @section_count in the function >> because the device for the specific memory block will be added if >> any of its memory section is present. The variable @section_count >> records the number of present memory sections in the specific memory >> block, which isn't needed. >> >> Simplify the function by dropping the variable @section_count. No >> functional change intended. >> >> Signed-off-by: Gavin Shan >> --- >>   drivers/base/memory.c | 15 +++++++-------- >>   1 file changed, 7 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/base/memory.c b/drivers/base/memory.c >> index 348c5dbbfa68..208b9b544012 100644 >> --- a/drivers/base/memory.c >> +++ b/drivers/base/memory.c >> @@ -822,18 +822,17 @@ static int add_memory_block(unsigned long block_id, unsigned long state, >>   static int __init add_boot_memory_block(unsigned long base_section_nr) >>   { >> -    int section_count = 0; >>       unsigned long nr; >>       for (nr = base_section_nr; nr < base_section_nr + sections_per_block; >> -         nr++) >> -        if (present_section_nr(nr)) >> -            section_count++; >> +         nr++) { >> +        if (present_section_nr(nr)) { >> +            return add_memory_block(memory_block_id(base_section_nr), >> +                        MEM_ONLINE, NULL, NULL); >> +        } > > Superfluous set of braces for the if statement. > > Not sure I count this while thing here as a "simplifcation" -- the code is IMHO easier to read without the nested return in the loop body. > > No strong opinion, though. > Indeed. I will use for_each_present_section_nr() as Andrew suggested. With it, one level of the nested if statement can be avoided. The point was to avoid counting the number of present sections in the specified block since the block will be added if any section is present. Thanks, Gavin