From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B72A5C54FCB for ; Mon, 20 Apr 2020 14:33:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6570A20775 for ; Mon, 20 Apr 2020 14:33:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Uye49zY0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6570A20775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0CF748E0005; Mon, 20 Apr 2020 10:33:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 058E88E0003; Mon, 20 Apr 2020 10:33:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3A7D8E0005; Mon, 20 Apr 2020 10:33:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id C51678E0003 for ; Mon, 20 Apr 2020 10:33:16 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7E04C180ACF75 for ; Mon, 20 Apr 2020 14:33:16 +0000 (UTC) X-FDA: 76728475992.22.music66_1c85254b3a916 X-HE-Tag: music66_1c85254b3a916 X-Filterd-Recvd-Size: 7421 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Apr 2020 14:33:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587393195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/BICmOxm1sDjBE0Fw16pReYLCBtQ7NAWk0hypsbt5YE=; b=Uye49zY0BfZIE/nJfQeMoV1U1TdSl+avsRSbETN9HC3WgiKG02i8Yu8QncgvGPhH/exfq0 e1TazExUafRrxEkH607MtjLA4sZHvIFMPtv8VXm9jZte4z6cQfdFYxpszG/Yo0RvfOHJfS /EhXE0fr88JLdK2lTf4VivzbpFXzX6A= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-ewL4Gn4lO8mE4VDwflglpw-1; Mon, 20 Apr 2020 10:33:11 -0400 X-MC-Unique: ewL4Gn4lO8mE4VDwflglpw-1 Received: by mail-wm1-f69.google.com with SMTP id t62so4249075wma.0 for ; Mon, 20 Apr 2020 07:33:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/BICmOxm1sDjBE0Fw16pReYLCBtQ7NAWk0hypsbt5YE=; b=CnuUg9hNUbibQg0+loFOQ9jU+G0Tvos/4dbQ6mDcHayK8leUvI6hKdnpr+xoA21tP1 YjtE5pDbh/aRezsByLuFcFkkkQ8aPoKD4BEoO66K3ug5vwDmKvuFeK7eR8aKMqkVYuYg yC7CSS6LnAVBeYt+mcyPdmhs95gKTo03CDuWzCBi0MiJw58sF9ykB/A8rPTRRQqsY6hR 7FIL9hckytD08x+r/zennqOGNH8EJud4L6xEZUcZaRAVmbrGN8tApxOGTdaU2uXIhZcB audHQ8XJk/u04HcwZOtn/+DL1k3hLSn9D05tS7gX6v9NBiPwssC5RvF1rDWO7dsHEBq5 AdDg== X-Gm-Message-State: AGi0PuafHsbd45PqVa9gxJP2SCedIq7KBFC3+N57Yz6Rtm5i6n8i263P kkwO0DLpymgievqwObx8gLqnT3gAQhEi+etA3aZ/qXXIEwe3Jk/7d2uuALSUzALZZ7JGOri49T8 y1z0QM8JRBO0= X-Received: by 2002:a5d:6689:: with SMTP id l9mr10607518wru.261.1587393190507; Mon, 20 Apr 2020 07:33:10 -0700 (PDT) X-Google-Smtp-Source: APiQypIE3DMH5xFDwGNUfVPw+X70x/SDiUNUfiLWd0azjzp9qQ2tZy+YP/738/NNIg43An+9cygOww== X-Received: by 2002:a5d:6689:: with SMTP id l9mr10607487wru.261.1587393190204; Mon, 20 Apr 2020 07:33:10 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:199a:e5ab:a38c:544c? ([2001:b07:6468:f312:199a:e5ab:a38c:544c]) by smtp.gmail.com with ESMTPSA id l5sm1432000wrm.66.2020.04.20.07.33.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2020 07:33:09 -0700 (PDT) Subject: Re: [PATCH 6/8] simplefs: add file creation functions To: Greg Kroah-Hartman , Emanuele Giuseppe Esposito Cc: linux-nfs@vger.kernel.org, Jeremy Kerr , Arnd Bergmann , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , Frederic Barrat , Andrew Donnellan , Robert Richter , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , Alexander Viro , Ian Kent , Joel Becker , Christoph Hellwig , "Rafael J. Wysocki" , Matthew Garrett , Ard Biesheuvel , Miklos Szeredi , Mike Kravetz , Mark Fasheh , Joseph Qi , Alexey Dobriyan , Luis Chamberlain , Kees Cook , Iurii Zaikin , Anton Vorontsov , Colin Cross , Tony Luck , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Hugh Dickins , Andrew Morton , "J. Bruce Fields" , Chuck Lever , Trond Myklebust , Anna Schumaker , "David S. Miller" , Jakub Kicinski , James Morris , "Serge E. Hallyn" , John Johansen , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, oprofile-list@lists.sf.net, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-fsdevel@vger.kernel.org, autofs@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org, ocfs2-devel@oss.oracle.com, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-security-module@vger.kernel.org References: <20200414124304.4470-1-eesposit@redhat.com> <20200414124304.4470-7-eesposit@redhat.com> <20200414125626.GC720679@kroah.com> <20200420142842.GA4125486@kroah.com> From: Paolo Bonzini Message-ID: <7d7a9ccc-022d-f60d-d28a-f063ab9494bc@redhat.com> Date: Mon, 20 Apr 2020 16:33:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200420142842.GA4125486@kroah.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20/04/20 16:28, Greg Kroah-Hartman wrote: >> I assume you meant a new file. These new functions are used only by a few >> filesystems, and I didn't want to include them in vmlinux unconditionally, >> so I introduced simplefs.c and CONFIG_SIMPLEFS instead of extending libfs.c. >> In this way only fs that need this code like debugfs and tracefs will load >> it. > Nothing "loads it", why not just make these libfs functions instead? As > the difference between the two is not obvious at all, please don't make > things confusing. I think Emanuele meant "will link it" not "will load it". Emanuele, you can just move everything to libfs.c and get rid of CONFIG_SIMPLEFS too. "Do less" is not an offer you want to turn down! Thanks, Paolo