From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3F4BC7EE22 for ; Wed, 10 May 2023 16:28:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8824E6B0071; Wed, 10 May 2023 12:28:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 832676B0072; Wed, 10 May 2023 12:28:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FAA36B0074; Wed, 10 May 2023 12:28:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 61BF36B0071 for ; Wed, 10 May 2023 12:28:15 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2B750C066C for ; Wed, 10 May 2023 16:28:15 +0000 (UTC) X-FDA: 80774877750.27.AE30652 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 80BD016001B for ; Wed, 10 May 2023 16:28:12 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ns3y+AMV; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683736092; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wug8MPxwb1qwikFpXl+LsvcQU0BExfoIt784lLQszUA=; b=0McVYeNj4+S28I1bd4+QHFGa2xEPLM8ZBmI67aq7bJvp7Pt5g1bSCDOgINrvYeJ66+Mrgn RAtWQ4ubtHca4VqD/q2BuvbClE1YHXy99W5UP8OxVS8tdktXb7myxneEuBnFrVDLMpFtby NmP0JfFFYCgcveo8shyLWhSxxzN3hpw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683736092; a=rsa-sha256; cv=none; b=dWtOO7iLEWzwUJzSc6K7OSX0sijKeI9hJH0n1LrPRE247L16dE1V63sfyzf7zrAX8Cmg9m XzvClmfGKv3DEMgQzcEo1UA0dh44a5//OqzU5eEkJdj38m8pldP/r0pKEeF8Rgudv1Xfe8 oM4WHnA7mSadX9WYHrQDqcLrvbZaBkA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ns3y+AMV; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683736091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wug8MPxwb1qwikFpXl+LsvcQU0BExfoIt784lLQszUA=; b=Ns3y+AMVl+2a9ertl3kZIXOonu7Jg4tNe7BkDOMgSKbgnaINnmDBu0fH3gIZTLQnvHfJjy tmRgj/yb7QeXnlDJpL9PHWFU0hMUydRO884/jEzoROE8+tZxamKdEqOfWYKmy4jiwrc1lb UCTTtfuzOUDPnLGG0ruH++tsspL3qiU= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-275-5qxXSnFnM02X1UsdCIowEw-1; Wed, 10 May 2023 12:28:10 -0400 X-MC-Unique: 5qxXSnFnM02X1UsdCIowEw-1 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-528cb2ec137so3790838a12.0 for ; Wed, 10 May 2023 09:28:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683736089; x=1686328089; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wug8MPxwb1qwikFpXl+LsvcQU0BExfoIt784lLQszUA=; b=JJrW4IRnNQw31whS6bD3FNSZCnoklBf+XJDz2fYTTuJBrSMqgxrQx/MDrStvyvgILY TB+9TzJmK1gK2MLgDdOiuLSijxYe7acDNnBgz2IMV2Ydbm+QcM5iSs3voPTwygmxb2+E TEzxYQKMTLd6bjPKkwsO7f8crjzykh1+Ilz+UAjw76x8pl9zCJPmrkS6E3fTgUEbWPYg GUJgFO8LKkhL0yIUSr8xmHogeCKI7QU1vPjU54jCu4Xq39n9VVsFVGV5UPGJTn7qtZNV 6aj+/vHidVbNLAKNOTrnVNwJFxtTZ/hCCzNYPPXxfFFSUqL6VY/4VWW6E/LU4nxlXFfJ diLA== X-Gm-Message-State: AC+VfDzrPQuyTf56cQTCx4pvw6ZMNnpHuUyBgozAD1GWf80Xiwh+ceyH KolzMsPCvefX26uI3hJaZvZM/BuawxqWZctOWCLLJpZvVIGX/8mPRCyo7/lbsdwJ4j9EEjQx0Kx 6VB+PngFhzZ8= X-Received: by 2002:a17:90b:3b8b:b0:252:7114:b37a with SMTP id pc11-20020a17090b3b8b00b002527114b37amr1700954pjb.47.1683736089093; Wed, 10 May 2023 09:28:09 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ71vWUUnU7AsOBwsGxC0ccIsutZeH6ArG3YH506jPelGdB7oxxS6W/XHzHY2l9G3KKb1qg+vQ== X-Received: by 2002:a17:90b:3b8b:b0:252:7114:b37a with SMTP id pc11-20020a17090b3b8b00b002527114b37amr1700938pjb.47.1683736088796; Wed, 10 May 2023 09:28:08 -0700 (PDT) Received: from ?IPV6:2001:4958:15a0:30:5835:5bd3:f0c8:e5ef? ([2001:4958:15a0:30:5835:5bd3:f0c8:e5ef]) by smtp.gmail.com with ESMTPSA id lr8-20020a17090b4b8800b0024752ff8061sm22035186pjb.12.2023.05.10.09.28.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 May 2023 09:28:08 -0700 (PDT) Message-ID: <7d72d054-2994-cc5a-53fb-c28eba32be49@redhat.com> Date: Wed, 10 May 2023 18:28:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] mm: memory_hotplug: Fix format string in warnings To: Rick Wertenbroek , rick.wertenbroek@heig-vd.ch Cc: Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230510090758.3537242-1-rick.wertenbroek@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230510090758.3537242-1-rick.wertenbroek@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: jd3137t4bs13ua9km5pf8mfjhp866dky X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 80BD016001B X-HE-Tag: 1683736092-623829 X-HE-Meta: U2FsdGVkX18RLogpuwDQplwcqA7NBfgv4XKiY+E5D5GDWGm6zX3daQSM32rOL41P7T/bKzGHEc6VYmNPFhhsqMOJuCY0UwIeBzTmC0iqpYFgZPCouiK13DTAKuSkzO+sYywbT0KNjQ73gvdriwRa3EZgOfoNrcALR+Wb7GeNkT/T1fezdsMieGBQYDzpQz76Amy+/vo7Nm48NUCbb2VhTF9P6auPrC2GozUwPcHCynP6P37BF4rcXlAVxP+Cmw9BJUiqIjmckDUzTxzqQ5VKOm9Duj+I43OLMbKCA+p/cU2aaAGjj9GSH9UExVlfXS5oIgf1CW8m/DLeZ+WwVRV5PjKXpeFFYXt2CsQEn7jLi4kfvGRRGtuVi1uKHJPK8KzhMc+RjFuPIOXl8ZDJ2fY95EW6szxRh5E0Mk7jI2OTJcqpx7E+7vE7ryK9cVF582bLuUHhRs5Fn+jCiP0ARaovdBh27LK0hcfuoaTJ5OIUo1inpevJQiv3/mHqWU4bdKYYRFa4U2hKIs926eRxbdgefxF4Kpwr0b5QvT0t/10GcGk0tddeVm63VQJvcGHryTM3EreXZwYXSoZqr+psqeCLWXIliMzdVvBHei3mojBPGF0GRA+sTR6/GCkeCx5bpsEUAdcCDHsFeEBBwtXA+nbv4Xx+5IOeOybUhkAh4xD0/KUdodrsqcRvp33wASgVOmaCzVGl1SGGDSPEwZ6+S1cFbpudxNjgT4l/LjUwasf3XeiUQqFYZIWAPN2mpLDMWCk7lSmEokmfCJhqapOK3LF1xw30FBrCik+6q9V/ahb3v/X1TbzbblqIkEWiPS2cKcJMbKXHmTUKuFcP2ZIP1TAdnDDH9qx+A29YDyq1f829NhwI9uQmRBib8bmPAbgufRaU5E3f+5qK+iASQz7hl1F1sJjckiIKEKNiZYe32ocdg2TG0wKTDrZrzQzuTXkpT/EXRKZFadvo4xaGlDl/s3h Jz2hzj5i /mtWmRF3cRCCS7JzZS5FWLGLeZ+EVC6p9s1u83vHN5M+Yb9/DJvgDAxMFqQIi8fR1xMwkQS/1kJJDzMzSbuA4ZBnaxK4u3GqoIIc43OU4F1Ktsuynbs1HrDLXtdXGYH2jpbAQ8SaU0NW9Kzkt3edVcE/lRgVplcvHR3SdiN6cHWW290YIqXtm4giri4iijs7OB8FaYo6gwcWVoZ1uyYLbz++kExEfOXPoVbK4zWcxS6zOHyuqXsBnvqJK9RpE9m+NmRnEKd+sFF7Rc1IGo1IQD51c+SkIbMu6I9V63elXiTKYfnuclq0WZzYsGS+xJeAfO1Hu3FYVpu2oKXEjR/6pLaGvDtptUPiMxlcy2YclfHwYN1ZsRt/lrFgJ3zC623Pl8Ir7WOt29Ke7nGadSCuoWmG8G1Ev9u0Sd+63cUSotDCR468ytJDo2SZYYJ0L/QRABznMqLxLDq1AJewJ0ERJAZTAQGVdB0+RuDh1XoDtVeLR2kx+Q/lyczqrjGxayF8SYflkmlpoOIfF3WM1eQR/B+r2Sd73QSnmh2V5MC8zXoiDLLPZ+oDg/0QguJ+jLiykmF/w X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10.05.23 11:07, Rick Wertenbroek wrote: > The format string in __add_pages and __remove_pages has a typo > and prints e.g., "Misaligned __add_pages start: 0xfc605 end: #fc609" > instead of "Misaligned __add_pages start: 0xfc605 end: 0xfc609" > Fix "#%lx" => "%#lx" > > Signed-off-by: Rick Wertenbroek > --- > mm/memory_hotplug.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 8e0fa209d533..9061ac69b1b6 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -325,7 +325,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages, > } > > if (check_pfn_span(pfn, nr_pages)) { > - WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1); > + WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__, pfn, pfn + nr_pages - 1); > return -EINVAL; > } > > @@ -525,7 +525,7 @@ void __remove_pages(unsigned long pfn, unsigned long nr_pages, > map_offset = vmem_altmap_offset(altmap); > > if (check_pfn_span(pfn, nr_pages)) { > - WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__, pfn, pfn + nr_pages - 1); > + WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__, pfn, pfn + nr_pages - 1); > return; > } > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb