From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6575BEB64DD for ; Mon, 7 Aug 2023 09:42:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03FA96B0072; Mon, 7 Aug 2023 05:42:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F33296B0074; Mon, 7 Aug 2023 05:42:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E21558D0002; Mon, 7 Aug 2023 05:42:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D36DE6B0072 for ; Mon, 7 Aug 2023 05:42:15 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 906AD1A0A2C for ; Mon, 7 Aug 2023 09:42:15 +0000 (UTC) X-FDA: 81096817830.10.148C791 Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) by imf26.hostedemail.com (Postfix) with ESMTP id 533BB14001D for ; Mon, 7 Aug 2023 09:42:12 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691401333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aEZz6uK5UNIO78K6YnJ6p8x2AiovWCFzCRqs1eaPMfw=; b=O+XZUbK0sx3j9mxuGGXee6MH64iZNiGojYsfWYjePzpoDym2PDBiNWsYnQOw9pLINraLrC cPRl+IwLDIRKjfGw30BdrNA7wSm8Xs5oS9dgiXx99Okzejc96Uh5VHK+x8hz7N4vFBgRTY Xg4eRDgw5Qni/wXMeRbfjPXdATXP5tI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691401333; a=rsa-sha256; cv=none; b=AENFvDItaS7Zcpao5RkkYTDi4Tik9cFT+r9YsN66NNSYEZlkuBwh0oHrTeuXrQaMMWZZjS a+bE5hgc2RkM2Yiv6E/bYAJvYiEmBo4IzM48wWDN4PJEPWz3+rCgK15yGYTGcZVsKCkq4Z m6VeOiKAXI0hzUZ6K0JADp6oa777zIA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.110 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R751e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VpEKeuw_1691401328; Received: from 30.97.48.53(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VpEKeuw_1691401328) by smtp.aliyun-inc.com; Mon, 07 Aug 2023 17:42:09 +0800 Message-ID: <7d687e10-32a8-1404-e714-4c6784e45f99@linux.alibaba.com> Date: Mon, 7 Aug 2023 17:42:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 4/8] mm/compaction: correct comment of fast_find_migrateblock in isolate_migratepages To: Kemeng Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mgorman@techsingularity.net, david@redhat.com References: <20230804110454.2935878-1-shikemeng@huaweicloud.com> <20230804110454.2935878-5-shikemeng@huaweicloud.com> From: Baolin Wang In-Reply-To: <20230804110454.2935878-5-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 533BB14001D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: nqodyoizrne99ds3j48fbbhu73x6us4z X-HE-Tag: 1691401332-692181 X-HE-Meta: U2FsdGVkX188uDb+fTe6hqFleN8S0l+x66B2MNptsspvzKuesHd/fyA1N2NUJNyFINH8g49kGVuZEQfUntTfO3vgDDnxSW7FOqq63aunmQRW4dbQiJ8eYV9M2hLOYr8S4vcWNDxow2jNnk2zenRQ35I80tjwgl75WtPasdaxboRi+Mk1cI2tS4rBYzypPRzoQyupvQIESEkzU9NlkWjzAm8N9S4G1sn+0taXTwjq/Qw8RaFNy8mTgAo2z+XSHIQtz1PRIs3CYRqRyWev1P1Zv9QfgiPzwTOVcfM0mJkPEVt7NWS4AKUt4YYPWohcn+RLu/gzyjSoCDic7Nrj5cEIFkNWtlshDZmgLQhU4ElwwkQKs2bfrcz8usxkIGnq3+0iMdu6mB9PWqPrIPEl3T5MgWb4zd6EMs5tl6ON7+zgvMt5S9kRiTNSIMANY0eex813AGUNcLe/dq4xsYvszfA0ypW1OrxsHBZVgn3gajQFbob6S2K6QfsJ2VyZ+tAaSZTOumSuG9E8vmMjl+G+KCUwVzKLyOgFoxaToDcDCdlCKE+uM9ytyO+epAHSI54UNfaIV8no6fP8PU/e2sfcEa7YRzAKRQ/ZcLaW1p8MBdk9Ueu/2e8DosBRmYU0ElAEkBQdJdE9DDvne6ONpVsdpN58mKII1x/CxrqKdZu60FHIWBqWjGuUq2KB6n2GbIvNVXbmmE860IP99llujuJNeO100onzNu5k+7/lZw06FJCN+JajRNAdg+nK3jkj7V6y5ajkp1T4P2mzwDbIX3J8yG7sIFOo2p+ZyGQT17Sxs/EHInz71o1Y/Wz6ms0m3uAFfFtwsPYwyjnG2eNAuyGAnNjdh8en1f/Q/5DkL7TWjA8q01cmNBkDTR/54A9ZuOXLSj5SjzMC6hI8ecdajdH7QkB+yMY3MC3eItUbvZBym4/+Nbe/n//1q9qGkFZgabBNT3kX+zAFDKhyAMtLcq5gW4v B49d0ExM 15jUooWY+ToOsnxDoZAxcxjYdVTCDEHbxGqducNfxfIYz9YsimXJLrv2n2it1y6rB1MYPOcMYbX+YM/JRhczSzY/DK5xICpS3e/bessHpx/78Iq8MBdKsvnVDsrf0tm7OqpReM+fSyIAr3IFc8hvb0rZS0CFHqX9xQ124HfFnr30tUZWyft9euovCg4HFMydEBZ2Uqujeju1Iex5ZUuyBHU54GQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/4/2023 7:04 PM, Kemeng Shi wrote: > After 90ed667c03fe5 ("Revert "Revert "mm/compaction: fix set skip in > fast_find_migrateblock"""), we remove skip set in fast_find_migrateblock. > Correct comment that fast_find_block is used to avoid isolation_suitable > check for pageblock returned from fast_find_migrateblock because > fast_find_migrateblock will mark found pageblock skipped. > Instead, comment that fast_find_block is used to avoid a redundant check > of fast found pageblock which is already checked skip flag inside > fast_find_migrateblock. > > Signed-off-by: Kemeng Shi LGTM. Reviewed-by: Baolin Wang > --- > mm/compaction.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 9a2f0bd5394a..4bf2dc936add 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1988,9 +1988,9 @@ static isolate_migrate_t isolate_migratepages(struct compact_control *cc) > block_start_pfn = cc->zone->zone_start_pfn; > > /* > - * fast_find_migrateblock marks a pageblock skipped so to avoid > - * the isolation_suitable check below, check whether the fast > - * search was successful. > + * fast_find_migrateblock() has already ensured the pageblock is not > + * set with a skipped flag, so to avoid the isolation_suitable check > + * below again, check whether the fast search was successful. > */ > fast_find_block = low_pfn != cc->migrate_pfn && !cc->fast_search_fail; >