From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53528C41535 for ; Sat, 16 Dec 2023 19:21:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C71D66B007B; Sat, 16 Dec 2023 14:21:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BD2DE6B007E; Sat, 16 Dec 2023 14:21:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A73C86B0080; Sat, 16 Dec 2023 14:21:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 941BE6B007B for ; Sat, 16 Dec 2023 14:21:46 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6A34DC068F for ; Sat, 16 Dec 2023 19:21:46 +0000 (UTC) X-FDA: 81573651012.12.F845ED6 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf14.hostedemail.com (Postfix) with ESMTP id BF64610000F for ; Sat, 16 Dec 2023 19:21:44 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=uPIsM4sT; spf=none (imf14.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702754504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9I9jmriNkRRhZzL8LAvE/UO9XO8ynzIkcjc6Pnubh3Q=; b=ENyAfnCn9HBvxNFCTUhD/tfNIvz6K4aaijhMimHO2vDWEuXu2HUJWWSRmry3+wi0lOJkh5 N7qlbk4uYvicvDeSvSKccbhAt4ztPBysVxjkm0Vhd5Q5bU/LByLlupaV5zAsq1LnEaRtAS /SpY3MQQp7HclZCL8ybTMK2X+W/H0OA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702754504; a=rsa-sha256; cv=none; b=RYdTIk9apbUiTEqnIl2181tLLsViFEJxY+OuKm3YLNIjLIFoLD8Gbr98iug63PttES8r/x oPs/J13NC3t1730WS+XusyPWDOXHu1ltI/0GFKNZdw+EUX25ZI+4xuVRT0wq5QHNeaKb3M xSh4xJPpD9FdgSQywAHVfU30gTlU54E= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=uPIsM4sT; spf=none (imf14.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=9I9jmriNkRRhZzL8LAvE/UO9XO8ynzIkcjc6Pnubh3Q=; b=uPIsM4sTCLJq9Lw5+wpQ3YaDTt 7/B8oCiQV5HSzRgH5yQktxmUe/2Ss49tYD9j0FBfdD/yp+Ndn3SVodYw48ngCU2omJX+lkvFJClZ3 WUEBS8QBRARpxjZ0yVyNkQ3HjX5XxDt2IVN1pdISmgNEPKzrcDIIglYPwtXVS11LKtyTrWE2Dtnxv m4mY4KHmu1BvP3xJKwutGwfcM0YWhAUrxzt+SUDyggQbni0kDiyW87t1XwgYrQhAWZ1f3CBh+fDnN IPVvPCIWXA6srVzqkUaAc1UC9V4BKU4Ll6PzVzYUVSv8hUSmCleQH0puJF9UejiS7KQZH7weShRzl IZ1p85CQ==; Received: from [50.53.46.231] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rEaEF-006bv4-2t; Sat, 16 Dec 2023 19:21:39 +0000 Message-ID: <7d5d85f9-a78a-453d-8d1f-01189eb21c2f@infradead.org> Date: Sat, 16 Dec 2023 11:21:39 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 46/50] preempt.h: Kill dependency on list.h Content-Language: en-US To: Matthew Wilcox , Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216033552.3553579-1-kent.overstreet@linux.dev> <20231216033552.3553579-3-kent.overstreet@linux.dev> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BF64610000F X-Rspam-User: X-Stat-Signature: n6sigaif451ytk956j5wmu8ybi3eg3o4 X-Rspamd-Server: rspam03 X-HE-Tag: 1702754504-833706 X-HE-Meta: U2FsdGVkX192v2pdstI9YspMN6dD+MFvlLqjRIXE2AvKjoF13pu6Rna5ZSzQSVZNAg/HSsi2er+TiukPSC1y5XH+a24aOLTtd4KHl3wOfzxxSMvyUPBIUJGZ3Uqm7TvgjDnyb1weGX6PDqxECxo5ohf7DtLzhMYv9wiWSh9XT56KqmyEdu5fQN6BZ9iC6JaSwtplzfY8ap9C1ogRj7KXxAs4lU0xSYRp2JFF4lonA8PBotVUptCHN42ZYSGugbOWto0txr7AcQHX8OOqNG1Ynm5cDtBJDpz7X+wp6iEaa44Zh6erHbB0w8ADrfnWC6gASfFvJt359yXL8rya6+P6YT8cHm5ucihZKjKa7BQU1etBDV25c+y90FNraKYG3mfbjtl3ewLEI0Ni2dzllBfujkyrvR5v7l+eJrpw+m21HMPsmrHaQkNx0f0ZVoKz6AuIHbIEKhZQRy1PFWn4yBl0mb3QPIdhuebkVOYcvCyT4XjimsXBgHCVxdfqDgHRdJ+rgm1Wxo84aX2ULD1Y4vmLsIK4r87Ki2ni90XrMkEfbdNT+MXNBpCQ+MLRxTv8SG0og7du+hHFYv+xgzqdeiA6ZaZjve/dbJwE2vrsmuzCRr4hWF1zxR/FIXowK3eyzMeBK5gEaXEVY6Vjqu1xY8mtpXcEC2NDdI5Y561hf7VIXF+bedn5xAk+sjemBBWFpIwg70yp48/z3nG/0RZjpqbwgqJlgY3CpABnCgGaS86u1DzscZS6HTCNANVs81GnZn2a+FzA9wG4EmQisp4PzvDWbrqc0afWzkVjtYF3nUlfZNdtCyE0ayDDIzte53ssAMrjdyOHOVpXK7PFLKmmQAx2nORfEiuonB5DY8o5SudtwNNPGX8PGQXzzFLDZWNQjE92iHKzHoefXJtJL//x7dVlpvFmr4DZvzGsoDZDLCmp/Cq3LCDFaXUp8W0xxphtfpaUUtEi8yWvPtb1pH6XlMS g/Vs5Xa5 Sx7zk4eckG4H5f5Tu1r48joZ+/+P5KJu8AfSaMt9O12iGnVvegMmtVjjIGSZP53t1MViooW6kCjxbnJr/NbQys6Gwa/RG7+6xGGl/YzzBpmmUnHgIRQp7sV8ol/1lgCUVf/Lg2wcS3eWRjDhFxS1vejHCtuohsPJTpBCwP2lcXGl49qKjwNArTjjjN1uCNADKIzZ+EeXwe8zS+1Wnhvp3C2huuC6lzSUzex7jXtcl+8MzP7gfOWdJ65/0zNDZWOLBrYGy4x1a4IPUb8K9ZRvXEyPqzCezwnePLdeoD/mgavCPbRY6CUKGMWL0JKv8aHj0UISyxysRB9Qjn6175uzJ5qNwIMIKbSZLJFobE3xjpr+UDrMQofjQvQ1akZUcS2mA4EjL6V8MGr7OgPs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/15/23 22:13, Matthew Wilcox wrote: > On Fri, Dec 15, 2023 at 10:35:47PM -0500, Kent Overstreet wrote: >> - INIT_HLIST_NODE(¬ifier->link); >> + /* INIT_HLIST_NODE() open coded, to avoid dependency on list.h */ >> + notifier->link.next = NULL; >> + notifier->link.pprev = NULL; > > Arguably INIT_HLIST_NODE() belongs in types.h -- we already have > RCUREF_INIT() and ATOMIC_INIT() in there. > That would be far better than open-coding it. -- #Randy https://people.kernel.org/tglx/notes-about-netiquette https://subspace.kernel.org/etiquette.html