From: Jan Beulich <jbeulich@suse.com>
To: paulmck@kernel.org, Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: open list <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
lkft-triage@lists.linaro.org,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: x86: WARNING: at mm/memblock.c:1339 memblock_set_node - Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead
Date: Wed, 5 Jun 2024 21:46:37 +0200 [thread overview]
Message-ID: <7d55b65e-331a-4ce2-8f72-d3c5c9e6eae0@suse.com> (raw)
In-Reply-To: <315d6873-d618-4126-b67a-de62502d7ee2@paulmck-laptop>
On 05.06.2024 21:07, Paul E. McKenney wrote:
> On Mon, Jun 03, 2024 at 07:19:21PM +0530, Naresh Kamboju wrote:
>> The following kernel warnings are noticed on x86 devices while booting
>> the Linux next-20240603 tag and looks like it is expected to warn users to
>> use NUMA_NO_NODE instead.
>>
>> Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead
>>
>> The following config is enabled
>> CONFIG_NUMA=y
>
> I am seeing this as well. Is the following commit premature?
>
> e0eec24e2e19 ("memblock: make memblock_set_node() also warn about use of MAX_NUMNODES")
>
> Maybe old ACPI tables and device trees need to catch up?
>
> Left to myself, I would simply remove the WARN_ON_ONCE() from the above
> commit, but I would guess that there is a better way.
Well, the warning is issued precisely to make clear that call
sites need to change. A patch to do so for the two instances
on x86 that I'm aware of is already pending maintainer approval.
Jan
next prev parent reply other threads:[~2024-06-05 19:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 13:49 Naresh Kamboju
2024-06-05 19:07 ` Paul E. McKenney
2024-06-05 19:46 ` Jan Beulich [this message]
2024-06-05 20:48 ` Paul E. McKenney
[not found] ` <eaa90c1a-ae96-4506-90dd-146ce85d311c@suse.com>
2024-06-06 14:19 ` Paul E. McKenney
2024-06-06 18:04 ` Paul E. McKenney
2024-06-06 19:48 ` Mike Rapoport
2024-06-06 20:17 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d55b65e-331a-4ce2-8f72-d3c5c9e6eae0@suse.com \
--to=jbeulich@suse.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkft-triage@lists.linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=paulmck@kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox