From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: David Hildenbrand <david@redhat.com>
Cc: Lance Yang <lance.yang@linux.dev>,
akpm@linux-foundation.org, Liam.Howlett@oracle.com,
baohua@kernel.org, baolin.wang@linux.alibaba.com,
dev.jain@arm.com, hughd@google.com, ioworker0@gmail.com,
kirill@shutemov.name, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, mpenttil@redhat.com, npache@redhat.com,
ryan.roberts@arm.com, ziy@nvidia.com, richard.weiyang@gmail.com
Subject: Re: [PATCH mm-new v3 1/1] mm/khugepaged: abort collapse scan on non-swap entries
Date: Tue, 14 Oct 2025 17:10:39 +0100 [thread overview]
Message-ID: <7d3ac12c-c3a5-4913-93cf-98c887f67397@lucifer.local> (raw)
In-Reply-To: <e2c77ce4-c260-4d10-b9b6-93a507080e61@redhat.com>
On Tue, Oct 14, 2025 at 05:33:18PM +0200, David Hildenbrand wrote:
> For the sake of progress, I assume the compiler will optimize out the
> additional pte_none() stuff.
>
> I absolutely, absolutely hate is_swap_pte(). To me, it makes the code more
> confusing that talking about something that is !present but also !none:
> there is something that is not an ordinary page table mapping.
Yeah it's nasty for sure.
I hate non-swap-entry swap entries with a passion.
We clearly need to rework this... :)
Naming is hard however...
>
> The underlying problem is how we hacked in non-swap into swap (and that's
> exactly where it gets confusing). Well, which this series is all about.
Yup
>
> So, I don't care in the end here.
I do still feel a single guard condition works better than having to know
implementaiton details so would still prefer this change to be made.
>
> --
> Cheers
>
> David / dhildenb
>
Cheers, Lorenzo
next prev parent reply other threads:[~2025-10-14 16:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 3:26 Lance Yang
2025-10-08 8:18 ` David Hildenbrand
2025-10-10 3:44 ` Barry Song
2025-10-10 15:21 ` Zi Yan
2025-10-10 15:34 ` Lance Yang
2025-10-10 15:35 ` Zi Yan
2025-10-14 11:08 ` Lorenzo Stoakes
2025-10-14 14:26 ` Lance Yang
2025-10-14 14:32 ` David Hildenbrand
2025-10-14 14:37 ` Lance Yang
2025-10-14 14:43 ` Lorenzo Stoakes
2025-10-14 14:39 ` Lorenzo Stoakes
2025-10-14 15:01 ` Lance Yang
2025-10-14 15:12 ` David Hildenbrand
2025-10-14 15:33 ` David Hildenbrand
2025-10-14 16:10 ` Lorenzo Stoakes [this message]
2025-10-14 15:41 ` Lorenzo Stoakes
2025-10-14 15:48 ` David Hildenbrand
2025-10-14 15:57 ` Lorenzo Stoakes
2025-10-14 15:11 ` David Hildenbrand
2025-10-14 15:52 ` Lorenzo Stoakes
2025-10-14 16:09 ` Lance Yang
2025-10-14 16:27 ` Lorenzo Stoakes
2025-10-15 1:52 ` Lance Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d3ac12c-c3a5-4913-93cf-98c887f67397@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=hughd@google.com \
--cc=ioworker0@gmail.com \
--cc=kirill@shutemov.name \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpenttil@redhat.com \
--cc=npache@redhat.com \
--cc=richard.weiyang@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox