From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7ED9C4167B for ; Wed, 6 Dec 2023 10:23:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 291D46B0083; Wed, 6 Dec 2023 05:23:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 241A96B0085; Wed, 6 Dec 2023 05:23:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BD3C6B0089; Wed, 6 Dec 2023 05:23:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id ECC236B0083 for ; Wed, 6 Dec 2023 05:23:07 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C48A4A014C for ; Wed, 6 Dec 2023 10:23:07 +0000 (UTC) X-FDA: 81536005614.05.4328F8D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 26F9420023 for ; Wed, 6 Dec 2023 10:23:04 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A4d6XdNq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701858185; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jq8nL+CD+mR1CiAuFz6mufGPWoKHMp+SCfReE8TYqDk=; b=yCgCY1WgMEW4UAjPEdwqVfAaYnfL2e49ZSVk3pJwn3ZHP/R8CkE6IA2OgWl2YSgIGyus4E CFRfT3kNS+trxVJb/gBihKZXRiIQUk/AMOvsYNvb+LLSAERDvEiOUY4zRje7ogtRMCalTJ JUTeIsvSWN5RLESHT2NyVac3bRti5BI= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A4d6XdNq; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701858185; a=rsa-sha256; cv=none; b=PMomJB9jPwIv4j2Vib3ZjUMyxPOUetlPdH2K/FpbWTCu07+0VjSS4l7NFKgx4LeloqufhQ xM2RkT0vv3Z9ED4SXEWyCd9rXOLnVoxefGmd009Xm0G/Svw2uaOoz8EouP49eznxyzwZ6m 1r+hcw9eJeTlK+pxwhG071NGNxogBa8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701858184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jq8nL+CD+mR1CiAuFz6mufGPWoKHMp+SCfReE8TYqDk=; b=A4d6XdNq/eL/yuMqHAOQg31Yo4IgxzWuCai8ZAFUGes4YSCRnLG7x/46xDpFPZWjvW5eHT sdWCrH5bU2XYEMDtb8pJ/iEugeZzDYJ9BEPQHh/w7g5YtY75CsVqqNprEaNDHR0eLjpEsH GoBgCFi6YsZM7ImJf4iNnsjLTfJ6gH0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-240-aj_prLSGNwSo7IIn1jbtfg-1; Wed, 06 Dec 2023 05:23:02 -0500 X-MC-Unique: aj_prLSGNwSo7IIn1jbtfg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3334b1055fbso521437f8f.2 for ; Wed, 06 Dec 2023 02:23:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701858182; x=1702462982; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jq8nL+CD+mR1CiAuFz6mufGPWoKHMp+SCfReE8TYqDk=; b=tiZW5xgiO9nevlwDS6Zer/NWiKOmQV6D5VThG5FHB3ZDAsFss8qkaWj1nyynfmmwNB vKC5o5UDTI3dM8N204rbK0OKll3tzsJ1hcuOpAxIOzGxGgSP6IG6+0PR73AaL8eh0Lkg I0Volaads0DJezaUY5hgOE5cF1i76nqjd5dZI58pk4Rkv7fT0MciOpgflbUnS5UzW05r Ism4hbzOL4DKBP4m00/r4yuD1e31J5fPkO+P9TRyVNy9kiSunq0hEIxeoNKP5NWwj73F GjkjYKJvSqQuWc3Y18k/Mm7Q2H7AgjdNRR/wZo8q0gF8tBQKy0jCjvaW1nuLdaYwirPB OKgA== X-Gm-Message-State: AOJu0YzFv7Adi1DW7D+hDMnmXde+oM1A7I3IzzTgIrtWra+qh8g+i2hg 5IrM2NWUCETiLSx9GwRNeRAhWO1J8IwiTIjfLN6H28rA9T1zSMJE7PZkwXuIT5ll3WaYAxxltR9 TD0+jTqzWDCw= X-Received: by 2002:adf:fd06:0:b0:333:14ff:a33f with SMTP id e6-20020adffd06000000b0033314ffa33fmr233725wrr.21.1701858181884; Wed, 06 Dec 2023 02:23:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IG0uRN+5iInKq4TWIHFK/wkcE5T+JAgNGBJBNSzj7PtS29sgQtALyPAB3Oxl0HE8kWOXAwyHw== X-Received: by 2002:adf:fd06:0:b0:333:14ff:a33f with SMTP id e6-20020adffd06000000b0033314ffa33fmr233696wrr.21.1701858181243; Wed, 06 Dec 2023 02:23:01 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id y5-20020adffa45000000b00333320cf08bsm13753878wrr.102.2023.12.06.02.22.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Dec 2023 02:23:00 -0800 (PST) Message-ID: <7d3457cd-5e3d-42a7-8113-545da646d7c8@redhat.com> Date: Wed, 6 Dec 2023 11:22:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 00/10] Multi-size THP for anonymous memory To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Alistair Popple Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20231204102027.57185-1-ryan.roberts@arm.com> <8d5fdb17-c670-4814-8f48-4b90062668fc@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 26F9420023 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: s18pohmkr69qwdd37y56i1tayspx1qzs X-HE-Tag: 1701858184-767024 X-HE-Meta: U2FsdGVkX1/T1tEOYNxoDJBtskDiv5SwMdMJGMu8yGFBXCZFApm8tBUfaZdjvJZLPhuPfj0WDs+2VNRP+OrMI8nIkOsgSjKMH0G8M+QLioBdtYSEKnuGhEMkSotsu+upT8gnXuDMYyd8vgvEM8ZzioJ7rb3j8Ziil3270FtpuBJdvqZKTOwTG1IdQ+jTUUZ/v5mZT6jq3JXtmAA8VNDKot/IO91D3uiACDspa9m4kV+FYmoqWYXH4Vck/hz6kNdglLuDyWYRV9xiuAzWNSJ91xyYjOO3FnmVAqNUiGg7jlxYQ/leWgZWBpuNXgjTvt/drA/LuQMEM0f7r7FZ0AxNKqGTpQ+niteEyRunq4sO8/p0GMLmyNYbuvFsyJHlpQpEA0KJcpDZy3w72qdw6w+sEYkpNcpIwSZlZQQaw8EJn4RPJpwAhtOFZNqKh/YI+3xt0oe6DdcGGeWmHTR2VVZKgJ985EXrGXBQfXmQLNr6Qg6GHeKYcZKnmdWDe0agjF6NwmoyjGko1yNxxcX7qG3gWeqAXuN/MWCfYaDaRWO5LT3PmpQKdyqon1QyQQY6cpuW3bz//fAeele0hJX0VAsuxOdFkWhH3S1DobGaUvtAXs+bppemeNPAK5zgJ9fN+ASJa1DTVwAPAT5VlIj6bI33IX6Vd8rLBiSskmOaD5ZE6rACcyLmY8Gf69Uo16BSPdTWDotWYa8eXMm0crN5oVOxABubP7p1c9s2h9VWxBuXmFDZokjekHoR6wAO3MT8ADeS40v7hRC53T1lLVYuuCl1upmWp/715RcuB0lfWcR7Ad+34uRtz6HV3jnBxvJWk5LPoL57WXjYWlSD0Isq4FG96kmyPUjTqO9yEWjGGhmQ/tdd+O8cqlTuboYwxXaeJosdjiHl5fg9Z39Oh6mwdJXQ5/OBpIFhnpsMJx8fGz8jO6xG3jHvBmkYgyJuESwXW3RFgAJ7EsKcDtb698+EUer CKvaiq4J 3a1g9ILDzxyxMA27tg8e3NZw/Kq5+qWjW6hrqA3kCOGq6fiJrKxujk05AEamNHML3Vrc10ayF4rBE9lUQGCCW/c0VmS/FyOE7r+U7sntdTi60eD/LprvVUNGkQNiPnoDUFTUPR8EyKfCbyIBGHvhyXJvaMCfhqrmz2Asbi81+gm5VdkN6S4LXbqtKnf7yjYs3Ty9QVw6IQEnTrOUC7gfhc5AeOZPVJwBsA56bc9d+25B/tSBwX7dWjekBwEh7YZZ5lt7MY+THuElus1QL1DZGBXoP3SQeE2vYciAThYwoN/SjhULqPco0agFBoQzv89mL60FS/C2Ube85R61bekbPqiOn5DxNWFXeWmnA666BNGS76gTqmNdbIzTR9uyRIBfCBf3ipNB/SLgUuuToa52dKHddHgm0lJm+I8CxRm9ub1kWlbGJRl31us6QMDUPiEVERRCevZbpQ8pnd7bIk+s39PLFCNj1S5rL3II5/f3lZVgj9+Mf18sS9Nbz2UHKv7UwIo3yRxo5mp7EsA9WqJhm4kqotkw6GlwGYHkWP0ixV3gIN/U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.12.23 11:13, Ryan Roberts wrote: > On 05/12/2023 17:21, David Hildenbrand wrote: >> On 04.12.23 11:20, Ryan Roberts wrote: >>> Hi All, >>> >>> A new week, a new version, a new name... This is v8 of a series to implement >>> multi-size THP (mTHP) for anonymous memory (previously called "small-sized THP" >>> and "large anonymous folios"). Matthew objected to "small huge" so hopefully >>> this fares better. >>> >>> The objective of this is to improve performance by allocating larger chunks of >>> memory during anonymous page faults: >>> >>> 1) Since SW (the kernel) is dealing with larger chunks of memory than base >>>     pages, there are efficiency savings to be had; fewer page faults, batched PTE >>>     and RMAP manipulation, reduced lru list, etc. In short, we reduce kernel >>>     overhead. This should benefit all architectures. >>> 2) Since we are now mapping physically contiguous chunks of memory, we can take >>>     advantage of HW TLB compression techniques. A reduction in TLB pressure >>>     speeds up kernel and user space. arm64 systems have 2 mechanisms to coalesce >>>     TLB entries; "the contiguous bit" (architectural) and HPA (uarch). >>> >>> This version changes the name and tidies up some of the kernel code and test >>> code, based on feedback against v7 (see change log for details). >>> >>> By default, the existing behaviour (and performance) is maintained. The user >>> must explicitly enable multi-size THP to see the performance benefit. This is >>> done via a new sysfs interface (as recommended by David Hildenbrand - thanks to >>> David for the suggestion)! This interface is inspired by the existing >>> per-hugepage-size sysfs interface used by hugetlb, provides full backwards >>> compatibility with the existing PMD-size THP interface, and provides a base for >>> future extensibility. See [8] for detailed discussion of the interface. >>> >>> This series is based on mm-unstable (715b67adf4c8). >> >> I took a look at the core pieces. Some things might want some smaller tweaks, >> but nothing that should stop this from having fun in mm-unstable, and replacing >> the smaller things as we move forward. >> > > Thanks! I'll address your comments and see if I can post another (final??) > version next week. It's always possible to do incremental changes on top that Andrew will squash in the end. I even recall that he prefers that way once a series has been in mm-unstable for a bit, so one can better observe the diff and which effects they have. -- Cheers, David / dhildenb