From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2171EB64D9 for ; Thu, 29 Jun 2023 18:16:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EB098D0002; Thu, 29 Jun 2023 14:16:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19C918D0001; Thu, 29 Jun 2023 14:16:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 063168D0002; Thu, 29 Jun 2023 14:16:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EB9588D0001 for ; Thu, 29 Jun 2023 14:16:12 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B69B8A0C3D for ; Thu, 29 Jun 2023 18:16:12 +0000 (UTC) X-FDA: 80956589784.16.F5B1CDF Received: from resdmta-c1p-023853.sys.comcast.net (resdmta-c1p-023853.sys.comcast.net [96.102.19.46]) by imf02.hostedemail.com (Postfix) with ESMTP id BCF7C8000D for ; Thu, 29 Jun 2023 18:16:10 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=comcastmailservice.net header.s=20211018a header.b=t0Qg2bUZ; dmarc=none; spf=pass (imf02.hostedemail.com: domain of kernel@mattwhitlock.name designates 96.102.19.46 as permitted sender) smtp.mailfrom=kernel@mattwhitlock.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688062570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mWTnVt9e/Fb+ASjag2lt89PvPdIMQDGYRRlGDqMbUnQ=; b=h6PmqdYyVwcLc+s5C0joewTrYhxFso2n7hodwNQgR4sbO/fKHTE6uJGaxhL8fjVYJapUp3 sWMKiltKeBO2Fzq2zvV2KJ68c3/njg8Gd4nnZYWMBA3J9kcYo1rLGX6iVqxI8BEaMLwXO/ edhBwtI83NQMFlT2os572GJKprwwDNY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=comcastmailservice.net header.s=20211018a header.b=t0Qg2bUZ; dmarc=none; spf=pass (imf02.hostedemail.com: domain of kernel@mattwhitlock.name designates 96.102.19.46 as permitted sender) smtp.mailfrom=kernel@mattwhitlock.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688062570; a=rsa-sha256; cv=none; b=Z4T9hL4adQvAuZRLWIdVOldYmCYpnU/+ayn4LYh3ZWs0pLoGjvWta/OwgUNhzv6d0cf+xs 5Fh3FRT9o8L5D2HoVcCZx47ZA1G2/vfr+n/zh9BWJj8XKcSlHWPS33CSpMFKXSnB1qqmEL TvH2+BRX5+fREJxoAXRjR0O175oDz1A= Received: from resomta-c1p-023412.sys.comcast.net ([96.102.18.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 256/256 bits) (Client did not present a certificate) by resdmta-c1p-023853.sys.comcast.net with ESMTP id EuYlqQtZGnWmVEwBdqHR1C; Thu, 29 Jun 2023 18:16:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcastmailservice.net; s=20211018a; t=1688062569; bh=mWTnVt9e/Fb+ASjag2lt89PvPdIMQDGYRRlGDqMbUnQ=; h=Received:Received:From:To:Subject:Date:MIME-Version:Message-ID: Content-Type:Xfinity-Spam-Result; b=t0Qg2bUZn2f2+4hitCISYF/J63ESQ8/P1+eMV6Et6kZyqhojH9uF0rPk0knvWz/xL BYElNb1W5Ut3zjc7BG4AainNiPRFeLSt3Nml7xwtlNfh/sTHuFq5CshL+wl2HG7H1n +DWol4oL4myW13ipKOJFKX7Yne4YSwmAzgqS31QBfJl+QBYkEYybr4ckjZBZhQUzaG /qb5YRoz6IvKIXaO1V7nhMwCILibImTvKi4qND7Dp0JiRoqY8SP8d49kq8Fhmm4rhr P8QpVEkm093ug1csw3DjMvylQG/ZPTzPs2ff/b4kHa4qXFY77+x2tE2x8nSTvHFqdS qO45bV2IIgyTg== Received: from localhost ([IPv6:2601:18c:9082:afd:219:d1ff:fe75:dc2f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 256/256 bits) (Client did not present a certificate) by resomta-c1p-023412.sys.comcast.net with ESMTPSA id EwBWqLftphq3SEwBXq8dQY; Thu, 29 Jun 2023 18:16:07 +0000 X-Xfinity-VMeta: sc=-100.00;st=legit From: Matt Whitlock To: David Howells Cc: , Matthew Wilcox , Dave Chinner , Linus Torvalds , Jens Axboe , , , Subject: Re: [RFC PATCH 0/4] splice: Fix corruption in data spliced to pipe Date: Thu, 29 Jun 2023 14:16:02 -0400 MIME-Version: 1.0 Message-ID: <7d33f8a7-eb75-4a0d-bb10-aa4ab497c016@mattwhitlock.name> In-Reply-To: <20230629155433.4170837-1-dhowells@redhat.com> References: <20230629155433.4170837-1-dhowells@redhat.com> User-Agent: Trojita/v0.7-595-g7738cd47; Qt/5.15.10; xcb; Linux; Gentoo Linux Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: z8dwzufctpt7txup18m51jt5sd5quojb X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BCF7C8000D X-HE-Tag: 1688062570-106536 X-HE-Meta: U2FsdGVkX19weGNoosq52qaCMWVTXRP68+lyZvngakOXO2GHQURLAQVa0LR5Q7DYfAyPtarHLzyrac4dz/31I7bDTK2QvEk0s5TDSpkJNq1NmWhjXrOKzhJd6ynsWCtV/z/JiBwt9rEOBU9fEM/KFYCTVrlzI6nVsIEQy1NjVW11tuyl7eB7mBV8UoHq7S6BKReGV8r8wIwNxzzXlemo6YP6aGFwMVZbCohtAZTPmZmYJ7t82wr5IJIK1zfeySwqLH3UBhJudl/fNgQ9uHnuNLmtpSjMDuQVZqr/aN8LjnDcb0WUjzCQFjAwkppc+7TwRy5b1aMuZRK+w9V5ZfYCS+5a2+3j3/mS3GPcIBcAxO6ZI4+qjNyc3OJcVbexDqO0NzXSUwt4wW66kAXxWJh43Ptm4XdKPFzzlNIK14gkZg5d9PV6B2Kw5O2AEUdRgcmq7MzYAa6aptZgMuUfSedePZ4txfA98Nm3mW0Fn1fa3ygUlgBIZN3s9nVZLzi1v3gmdzqgA1uCiDkGkzWwpIICrR9SCAXmWtT2rHL4j+fv9/UQ40VjRoXSCF9nxdSPX2Xa1QWL4uDeE1r3sQ7p+iix8RGnTAr3ObzWBI01IleFPVimC2ZIv66xrkoGFHnklH6wUSxt3isV3BM/83n+Y/Ut9uBT8t5RKrpynE/3Tb8znOJ0BvUP/mGCbR5NEygCfnhQM4Y+rXQ6VBO0ViEr7xnYEaW8FhjfcYp8EizLtWvLY4efV39tzXAQTDRH26gCqttf2MafrpBtJbs/jY1nRGduR3/v2UYx0GoELnbE1/7jlyJnyxlfQ+jrfrIP54SMyTiR0dg0cpEjOtv//zFPZ8dBkb15svOELuLM+NW/L3wRQosIKwr4uxYWyMn+SiRfeTYeYZtJSTiku4AZk1GY4j+GrMdxs3P0MWHUf+O9pgbL1jzcLqfTBrcMvmvppOFLEcnxKHkho6lyZbshlf3mn+K TSkA807v fCZNdW54rGsVBYDsBhHOaCQtcEVyNLEeXHqwFYSuUEktXmZU42rl08S5Z2ExuzD8jcuAo8UpO0K5ordsfaHLpftiF63yGiJ49Qt/oj1a0e7Igk7aR8T74UWm0XjGpN4Air4RC9ajOlPC7YXHCNFWFURDYD4alE47IH5MCgWVlQ952fOz+K2rMLzrlw0KSYHKS0o/w9BBjnqZXXR4Oir4nUUUYUBA98InHk9YM8kgSqKP6N3Ur/wAi0RbvnPXfvuCwMRS2HEXWj0dzDs8suaIRQIHfbspWWKe6lODNKYIHQIABPMBsBWZu/Z5atmU+xz9mFPlLbKASZPma/fMg0/SNtyfYIK0ZCCt1Kzs7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thursday, 29 June 2023 11:54:29 EDT, David Howells wrote: > Matt Whitlock, Matthew Wilcox and Dave Chinner are of the opinion that data= > in the pipe must not be seen to change and that if it does, this is a bug. > Apart from in one specific instance (vmsplice() with SPLICE_F_GIFT), the > manual pages agree with them. I'm more inclined to adjust the > documentation since the behaviour we have has been that way since 2005, I > think. Anecdotally, my use case had been working fine for years until I upgraded=20 from 5.15.x to 6.1.x in February of this year. That's when my backups=20 started being corrupted. I only noticed when I was trying to restore a lost=20= file from backup earlier this week.