From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BF91C021B8 for ; Tue, 4 Mar 2025 06:11:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66CDD6B0085; Tue, 4 Mar 2025 01:11:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F5906B0088; Tue, 4 Mar 2025 01:11:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 496B16B0089; Tue, 4 Mar 2025 01:11:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 251F86B0085 for ; Tue, 4 Mar 2025 01:11:41 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BA7DC1215EC for ; Tue, 4 Mar 2025 06:11:40 +0000 (UTC) X-FDA: 83182847160.06.48A8D12 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf07.hostedemail.com (Postfix) with ESMTP id 244C040006 for ; Tue, 4 Mar 2025 06:11:36 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=V5liFoVM; spf=pass (imf07.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741068698; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4FvNFViwfp2APOt2jux8SKthZ9o17Z2NZrToAsK4eao=; b=AuXMWEfKKvGGY7yHc2u2Ppnd88Mn1S0PcXY0/qCfOQQaTorwH87W3ZddDEnWI73qk2hTMV m9Gn7HTRjAx7yVK1hVn8HiKSm1puVz924zNFBYT4LMqD1EoV3qcg3bm0zodIR6TVSp6kTc 81YufEufGoAprnMt+5COro7cP1FjqyM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=V5liFoVM; spf=pass (imf07.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741068698; a=rsa-sha256; cv=none; b=OdsJ/W32nZXEyVkWG0J0q0B6cf7/VJBm7+SyUJD3ftcSfWq/hEbose8P0+0YDpYolLQbqO 1v/XfI632u/prU/R35h1dR1zp/1QJG3/sCiTafeZMwWAfICDDMSANFQ3B68uh6VEqtG+iK 9zXZkeD3yJ5av9Pc8JpLrCarsdT9/4c= Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2234daaf269so73904515ad.3 for ; Mon, 03 Mar 2025 22:11:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1741068696; x=1741673496; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=4FvNFViwfp2APOt2jux8SKthZ9o17Z2NZrToAsK4eao=; b=V5liFoVM93m3Pmgd2fojmjniaghqJCv+ZRC6u4umOL13OgFMzq7X4pVE2uyoouHk9D xd0Qe296YYhxiEenfc8yUHqoPGgJj4hds2201hPtYw/Xs8l1IzAve+zN+kC2Iu1qKlNj 1DH6DwZE8YPnAln/6oYyjKHcGk5pkmj13YPWUYrXNnhnFwvQCOKWSP88AR+hRp0U7Aj1 HslN+ppbQtL41oDkC2ED9o8AuBFi3siFogy9zqt0cGN55ty1xhqgIGaQXOxHfZNACP4k 2wsUljhDp2IF2IRWe09mMQkIHAjyToRtTrF+d9gBCxdHHZoZpfC6StJMPayEC5GCHpfO MvgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741068696; x=1741673496; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4FvNFViwfp2APOt2jux8SKthZ9o17Z2NZrToAsK4eao=; b=ikWSSfGLwI8xHY4kpXxXq4ZB4zuReSDOXaJ8KhNPFmsacSWynxj3UcWh/jJXgOSsBF pH+P2p6CnREDbJTNhY1j1UOK8lKXQrNqY7RdMXV6kd7wsA1xoHv07OiSbPHnYOhmt5OU P0oE73n6LECcHPVXOExGyVjKVX3e9BjFtHOB7rI7o3RSIo8irLVwsQdeMl2jQ/2iIIRw QRI4xCmx9lLthPnG15aU6MulPHeKUCEIWefjgJCjwZV7Al/+hE4x3TfLpHWfG15XsT+l dGHExUVtqDosVMU4ijtnr0EN3LQX9evxXaokIkZ/ZBESowQp4gOZz1K88rVb1IjVYYZz KGpw== X-Forwarded-Encrypted: i=1; AJvYcCX8DgUp0Uk59cX0m+VrMT49JuGYIuZUeqXbfxbdxgwBCVGOvedNS8vwAVaCHPbGFB282bJffHHBhA==@kvack.org X-Gm-Message-State: AOJu0Ywih7y45fNeK0Em1mBr65XauD+GxO2MGc4CX1DQ+5WZsvOi7Nnk 3ge76Qtq2ZC9FrXAqQjeTG5TXwWSsMSiH3zujT15kktp83Y1l5N3U6xbf6B41a8= X-Gm-Gg: ASbGnct5HRh/tk19HpamZfZkbuK1EDLDZv1zBT9Dx+NrUMrOZ2tv385M9Ya3H4mVQa/ 5HkUjMpNhxcX7pIyUAeTjXcHcGLHwvg6XneMg+VSHM22T5x75/8GrANkzn3ktafC2vk+s5XV7hl is184iOtJqq7csgkr6zQewj/9rwFap77Ok8P5f8HB3/whbylQw817KZSA6zFOcnM/9QmCmAOAy7 jo6+z4QU9yQSj67M4gwUJvPs0ttlSna37b4t0uUUZdX+NJa0KThh7tHBQJdKQpWZKIdySF0ACjM dP/Z6QBG9Gn8OKK6HTa9aKI1gAiSHEvvOxPRADnMaahX0/HZFBbZ626cRH4Dkkb3PiRw X-Google-Smtp-Source: AGHT+IEXDQyCMQ8sBrL+0HeKoJpZdetEfwPwd6LYj+c4cbVY5/CTPcBDN/0v1nn1xNdV90cajxorag== X-Received: by 2002:a05:6a20:db0a:b0:1f3:40d3:67d4 with SMTP id adf61e73a8af0-1f340d369d8mr504424637.30.1741068695820; Mon, 03 Mar 2025 22:11:35 -0800 (PST) Received: from [10.68.122.90] ([63.216.146.178]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-aee7ddf23b6sm9305805a12.15.2025.03.03.22.11.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Mar 2025 22:11:35 -0800 (PST) Message-ID: <7d1c834d-bc65-4979-9b72-0d1d91019501@bytedance.com> Date: Tue, 4 Mar 2025 14:11:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6 update] mm: pgtable: convert some architectures to use tlb_remove_ptdesc() To: Andrew Morton Cc: peterz@infradead.org, kevin.brodsky@arm.com, riel@surriel.com, vishal.moola@gmail.com, david@redhat.com, jannh@google.com, hughd@google.com, willy@infradead.org, yuzhao@google.com, muchun.song@linux.dev, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, arnd@arndb.de, dave.hansen@linux.intel.com, rppt@kernel.org, alexghiti@rivosinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Geert Uytterhoeven References: <19db3e8673b67bad2f1df1ab37f1c89d99eacfea.1740454179.git.zhengqi.arch@bytedance.com> <20250303072603.45423-1-zhengqi.arch@bytedance.com> <20250303155331.de9b2fff9b04984a255a7bc2@linux-foundation.org> <20250303200815.53007fb79e5049a99f24c999@linux-foundation.org> From: Qi Zheng In-Reply-To: <20250303200815.53007fb79e5049a99f24c999@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 7wppabh9caf85xmu9j3wimmggx5ieb8f X-Rspamd-Queue-Id: 244C040006 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1741068696-719676 X-HE-Meta: U2FsdGVkX1/5WOS7O9+a5cygL8E+SdMeb5Q8QCqZhg5Q5yoTJClSayhWPPrshkak8ijyjyY0Xbhu8Ks/ie9NHCP6shvq/NSBi2bsglGoyT0c7HaeZOjV2M2PwgUnHzFBs43+QpSp0/adm7tQ/XHVhi5IFDJFhsEHBA7lY0+wsPpvyUhUQy5qAywERuwOA+isg7qImGKpVsuW3E0Z4u8LOrgVGElIYJLjuF/QVYx0lMH0v9ZGMRPrVem0d4krpILwadY5lNxynxK/eUb9I7W+sC8WeWOAEemYz5ayp0qWzN3YxQgeVM2JdYO7k3t+iuH6wCv6F4G3QA4Wxg0mPxdlP2f7Vu0GIWj2Z44ZlRYgHf30YlUae/mgsX86LTBnBt7e2Pm8SEe0i9cDNfB5odgQIoO3zTeb3tEIrbSaH8dKbMKSgvaenP5hfDbFDq2haz4v0oUuZebKJUzRBMoPrdjgwrThNTp3D3A7ymqJyE4otyyDWGrqCkMU3LnnX/ya6AHS25DoM1LUKZxBUsvLuDqeyg9XHuhAkc/r4XilY67N5yvF/xwo2Op5QQWVATKRPagphIffHRszoI7VMb22wzGhKGQ1Oj64OYvrqzAcG9e+3sWcIlkA3htyejMBHeICpNMGAW+Ny2Jy3EdGJMDVBEQ3fTT4JIOV3uwfI372ntJaE63pgB+boFX44aGqheKZt+gShplX20k0EMbXyfPjnpMZCG9D5Y729ODOfNf6++FxEV7L9Ba6DW/2UcrpFT0mXUpZvf0hKzj6WzjCEOVFHibwGqzb3XraU31mCqVXU8aEs/l7VzHu0S50Gy6j3WDldAI9UWPtWqcQMvTTUE/K6enCCwG+C8TsJ2CX9kJ6HuEPFRA2Kn3cfWOiBcZCyEivQLM7V7FEbUlR6m2JuLX3fAnI3HVUKnXVl0Io4bZiGcrAw6cWb1KYPQMZws4E9yxG8DfMsVl6OxilcilcftwkICb uCQ2A9Y9 NGnomFWUM/BcX+P0bn7Q20ih/XNc+vT0axF5U3DBlggpCHeTVppvMsaVATY6Oo5v0m6tsATjbpeDNdTm3m24Sq0D+9qaWGsUxb8MoHqu2WyxKGMabp13wZFIP3wLURBgak5WXyBOgaDev2xpOT4cshmwNlw98yJn/s8GMRDc98ifeCe/S0PVfQQUlgN2tuUE5rHzqTNuAXVvtwVXs8xKd0bRp5qihV80HpmgzJQx2YNyDguHFRv+82jdbqYtdgb3fjXOPqMW8KM+4OOvAYQ+V2e7mxqyFaCXqqwLDvbrtiJr0IhDzal43uuDvRNYrbQbUe7toMMTwA1AuFN8ocIcRuZAMrAytg3+d9d91oT653r9c3Ft4AbClcEowWN9b+ptxAE/2IKNM9vMtHIjKPfULYEAs96fKd7DrqLW87Gvsvggl49WWz5Byu7GF5ws5+OdeswsMMP3RTqJuPx2Mp9+FBMmPRkIrJ+fM+vy/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/4/25 12:08 PM, Andrew Morton wrote: > On Tue, 4 Mar 2025 10:31:07 +0800 Qi Zheng wrote: > >> >> >> On 3/4/25 7:53 AM, Andrew Morton wrote: >>> On Mon, 3 Mar 2025 15:26:03 +0800 Qi Zheng wrote: >>> >>>> Now, the nine architectures of csky, hexagon, loongarch, m68k, mips, >>>> nios2, openrisc, sh and um do not select CONFIG_MMU_GATHER_RCU_TABLE_FREE, >>>> and just call pagetable_dtor() + tlb_remove_page_ptdesc() (the wrapper of >>>> tlb_remove_page()). This is the same as the implementation of >>>> tlb_remove_{ptdesc|table}() under !CONFIG_MMU_GATHER_TABLE_FREE, so >>>> convert these architectures to use tlb_remove_ptdesc(). >>>> >>> >>> checkpatch warns. >>> >>> Do these things have to be macros? Switching to static inline fixes >>> the unused-arg warning in a nice fashion. >> >> This can be switched to static inline. In addition, I found that alpha, >> arc, microblaze, parisc, sparc32 and xtensa also have the unused-arg >> issue. Do I need to add a new patch to fix all of them, or just fix the >> newly added 11 warnings? > > I guess leave things as they are now. Switching all these to C > functions can be addressed at a later time? Okay, let's leave it for later.