From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19ECFC54E58 for ; Mon, 25 Mar 2024 10:33:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 911936B0089; Mon, 25 Mar 2024 06:33:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C17F6B0092; Mon, 25 Mar 2024 06:33:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7622A6B0093; Mon, 25 Mar 2024 06:33:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 600316B0089 for ; Mon, 25 Mar 2024 06:33:40 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0420740C0D for ; Mon, 25 Mar 2024 10:33:39 +0000 (UTC) X-FDA: 81935200200.05.3CA155F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 8110CA0017 for ; Mon, 25 Mar 2024 10:33:37 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ckrBFCNO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711362817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o8GhFT/33LclDx1D75rX36wDhvwb/FGwgeUBIS9s3Fw=; b=T+PF+PYESmiX95vYvVcThkrd18XDVWoeNQLhhwfD1V0R3PKu/v/MWm7mmaGeOX3dfHtUsv QNigcMAnTfmupdUCyJb2HsyQeKwHfe3qQsRnZ+A9NKdWsoh6gv4QKertsYX6lcpucGbT9O IVuNkM7K4+T8b4Fc9goyi5YPc1Zj1Dg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ckrBFCNO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711362817; a=rsa-sha256; cv=none; b=Xjr+AcZS/SCdseI46HlvhIeIUdfcTrZ6xAOguEb4iozybQ4zv5PxZ0N+Itk8e2jdfaOYxQ 54I4qe8SPui/BxlvhDecGTQIcrphUVoaCrVZjlLlczCLz2PjrnfpWsxkiBhOXj2IKbDIAI pplMcgJ+peJ50hVW4TrxL/uJOMv/rLE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711362816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=o8GhFT/33LclDx1D75rX36wDhvwb/FGwgeUBIS9s3Fw=; b=ckrBFCNOn3LcavFKHds5maf3ZkQRZehsTEj43xYXVPUxtDC4eeucvaiC9rxs41pOKGMLEN heWIDBnG9khBCxctOO1W2Xgn3o3dHdojyGVnytaVg7unhuc6oZbAEk/SvLuuh0RwsePGCA 83BJss6700k/VxEQuEc5KAHf7P1jJV8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-259--M28mmJUOnapUd1VWawH3g-1; Mon, 25 Mar 2024 06:33:35 -0400 X-MC-Unique: -M28mmJUOnapUd1VWawH3g-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-41482ca91b9so5730615e9.2 for ; Mon, 25 Mar 2024 03:33:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711362814; x=1711967614; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o8GhFT/33LclDx1D75rX36wDhvwb/FGwgeUBIS9s3Fw=; b=sMkQfUmEEfTfyOKw9xGna0Xh6k1pz3m1VBMhcDA3Qvt/31pWjMrnf1g89TPDytzlnW zYKjWNskHel0g2CUiytSFvWdtX+LRaajTw600Ilz1/ryNfx1SkpEMOPVoRIy0l2ZRjB6 IsptTWc0CbiFYWYkX655iscoZO9GyebNflE26trZ5bs4ltde0t/UxdhZItWm7d/QGc9c 2h95TuLO2KPL0BGhfEE8wuO0qf/dSd1itEEVfqgbrrzkUrma9qTs68/664Riq2rN5Sak wYZcMymwpXlZ690IFLv6YtGsMRbPNjyki/k6OtFqWiwgjFBIvj/pYErMIrlc5QjIjd0S 5IiQ== X-Forwarded-Encrypted: i=1; AJvYcCX0Hiw3BqX7IXwbpZl05oHEYQY976Uc7lWAdIUOE9+TEmMinkYxsdc3H7dOAvLZxXWvgm+qIZ7Ggj0/fW1mkzYr1qM= X-Gm-Message-State: AOJu0YwMMcTFH96aUG1TXeQnopiGlla6W9Q/jXMBHKvbDnQ8MX8VecoH 9AxJdsXSB9wvFuv0spPcf9kG6G8nE0In36IBusM6BfypnlHX6EXpjllsyCOY+k+NiqUkWvJyUWR NqmIMN69ldXdH4URr0JLDNghbUemOVqUzbrl8aaHx+TlK7ykE X-Received: by 2002:a05:600c:3b11:b0:414:5e92:cbd8 with SMTP id m17-20020a05600c3b1100b004145e92cbd8mr4793939wms.1.1711362813865; Mon, 25 Mar 2024 03:33:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHrFvzOcXy316ovMGFAEmVpWzn3p4ZDCqwhlI6NIYXHL/DX/H6NTMCtMgEOvPzZNHIAJT0z1g== X-Received: by 2002:a05:600c:3b11:b0:414:5e92:cbd8 with SMTP id m17-20020a05600c3b1100b004145e92cbd8mr4793930wms.1.1711362813438; Mon, 25 Mar 2024 03:33:33 -0700 (PDT) Received: from ?IPV6:2003:cb:c738:b400:6a82:1eac:2b5:8fca? (p200300cbc738b4006a821eac02b58fca.dip0.t-ipconnect.de. [2003:cb:c738:b400:6a82:1eac:2b5:8fca]) by smtp.gmail.com with ESMTPSA id fj12-20020a05600c0c8c00b0041409db0349sm8037354wmb.48.2024.03.25.03.33.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Mar 2024 03:33:32 -0700 (PDT) Message-ID: <7d151430-c296-44de-8998-a20a0b526aab@redhat.com> Date: Mon, 25 Mar 2024 11:33:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] virt: acrn: stop using follow_pfn To: Christoph Hellwig , Andrew Morton , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Fei Li Cc: x86@kernel.org, linux-mm@kvack.org References: <20240324234542.2038726-1-hch@lst.de> <20240324234542.2038726-2-hch@lst.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240324234542.2038726-2-hch@lst.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8110CA0017 X-Stat-Signature: nygmi9n85mzxyoqhob736uhz9z799frj X-Rspam-User: X-HE-Tag: 1711362817-702375 X-HE-Meta: U2FsdGVkX1+YDgmQnrsQdJZyOIHYiHDPb7kWTCKa1iakMyPFRvgk+mvP0tWVTFpWHpBmrziSJuet770ECCn2zbImZqQjvc1/DBjDSGvF2pxdjNW9/LhiTRK/fwoCD41YRxeg4zivO9TvhGhDAnP3d2aopHZaOzX+ZQFy+DJQq9+4sAIRA5HSuqf+EZJGI989cOUesTIsa2RTW4oML3trtETfM3L8Zyo3jCQwPeD0zm8jaHsUBqlMSsy8s07SAVbZ3AhjS3nukfhZFFgrkMzE9PwPVGln/QjhjClsEvIA0v02CL1rRkANqV2fn3XHzdnIiqIlQwbhWXET9Lsx5BcSHctYK778dUUuvkT8DnBwyR5Xab6Ji8tdLDyJeADs9yPVGrNWcJtoS9G/caARXSliCrXteLFHzXq+8m8SPzGcJ5QlMaia//x4LuKXhR++LOs1zckiS33tLI3rUTWSE9WL9O6Qyf5wq3FC5ItBV1GNErSGPg32STuJfusrtXW6zmmJ+QLJXEFfg40wNWNJguqzDm7U9D77o++lWOBAgL/UZymkBGVEb3LOhEbf8eYcPNzt5kpFT9lztIcpGtpzgnaQaSPhRk7RY/R9gKUGBao0wEGwF7wV41mjcduzDQthaACGKOtNZO/LXAEXgqYdH5yuZQr/D2rZ2JtEXT8GTnWmyQZ+CIjAnF+x8ukLdsGtaVIX0zn9yM9YI7dSOQh9eosRLQS0STkXQOHx7RpnTelIEk1jsMcq+N0Zt0I7NNhib1YotYLq3AsdRGFiIo6dYWcgpElsQcOWpItxOIoN3FlLOCAQEH2rPOb/yrZU0L9FeO3Ck3aSeheDgSXuNwPqISnl5zQ233bMJg1lxqH7L88zn1I6FWNYoq0Fl1PyBUh6R+RIXRjKdWrx3MaXX1zayOhVQq69+7JAfJMSqDMq4FMHbnnmMSZ12/pdh2X2i27hIiFM58v+/wiF+XaWwolv31L hGVy8XGe jt6w5elu4wp0xNdvvxWQ6Sx/MauYfVXR5enR56vbwjmm1odUfgwIxc5LxZTsaf1+FfY3y8v6enG6RuMXZl8bhBKxcVFQQ/kDLJQ0i7oa1HM+U7J2AEH+fPQkZFzlf7IAfUPc8wW6zVEB9Z2GipLLT2RTtCAhY7YjlnBZ1X0GaR/DGg5RZXByE+UrTKcHR3g4RGj4oIBe0MqGwrY+5b3HqtMI74PM0OAkv7wKgAV7H4rGn7mOocuq/Sbj8WTJ0FJ+pRiKlAzx3ALwl87hklFXIGU2kCLND2/DpqpnTIUYSjub+JufUDkZFHvx/pEKGwymSYCRIGBhQcBR0fpDVZjDpxEnNdSv8WWwKD7GG35/s5szJC17EI2ahb4IIC1ODyjDn2F+ZC8T4uFig1aAtwXymqoxFJ6ZbA6nqPY2kmQWdGPATo3fFj6mY/HUzgK+w8DpUcGQD+6Fm0y+A8geJ9KaDLHkYeAuHi0hfdvf+DqKNQ4N/kSjLah7+MQuvHA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.03.24 00:45, Christoph Hellwig wrote: > Switch from follow_pfn to follow_pte so that we can get rid of > follow_pfn. Note that this doesn't fix any of the pre-existing > raciness and lack of permission checking in the code. > > Signed-off-by: Christoph Hellwig > --- > drivers/virt/acrn/mm.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/virt/acrn/mm.c b/drivers/virt/acrn/mm.c > index fa5d9ca6be5706..69c3f619f88196 100644 > --- a/drivers/virt/acrn/mm.c > +++ b/drivers/virt/acrn/mm.c > @@ -171,18 +171,24 @@ int acrn_vm_ram_map(struct acrn_vm *vm, struct acrn_vm_memmap *memmap) > mmap_read_lock(current->mm); > vma = vma_lookup(current->mm, memmap->vma_base); > if (vma && ((vma->vm_flags & VM_PFNMAP) != 0)) { > + spinlock_t *ptl; > + pte_t *ptep; > + > if ((memmap->vma_base + memmap->len) > vma->vm_end) { > mmap_read_unlock(current->mm); > return -EINVAL; > } > > - ret = follow_pfn(vma, memmap->vma_base, &pfn); > - mmap_read_unlock(current->mm); > + ret = follow_pte(vma->vm_mm, memmap->vma_base, &ptep, &ptl); > if (ret < 0) { > + mmap_read_unlock(current->mm); > dev_dbg(acrn_dev.this_device, > "Failed to lookup PFN at VMA:%pK.\n", (void *)memmap->vma_base); > return ret; > } > + pfn = pte_pfn(ptep_get(ptep)); > + pte_unmap_unlock(ptep, ptl); > + mmap_read_unlock(current->mm); > > return acrn_mm_region_add(vm, memmap->user_vm_pa, > PFN_PHYS(pfn), memmap->len, ... I have similar patches lying around here (see bwlow). I added some actual access permission checks. (I also realized, that if we get an anon folio in a COW mapping via follow_pte() here, I suspect one might be able to do some nasty things. Just imagine if we munmap(), free the anon folio, and then it gets used in other context ... At least KVM/vfio handle that using references+MMU notifiers.) Reviewed-by: David Hildenbrand commit 812e577dea97327bcc68d34504e7387dff2ffd8f Author: David Hildenbrand Date: Fri Mar 8 13:53:04 2024 +0100 virt/acrn/mm: use follow_pte() instead of follow_pfn() follow_pfn() should not be used. Instead, use follow_pte() and do some best-guess PTE permission checks. Should we simply always require pte_write()? Maybe. Performing no checks clearly looks wrong, and pin_user_pages_fast() is unconditionally called with FOLL_WRITE. Signed-off-by: David Hildenbrand diff --git a/drivers/virt/acrn/mm.c b/drivers/virt/acrn/mm.c index fa5d9ca6be57..563c545adb2c 100644 --- a/drivers/virt/acrn/mm.c +++ b/drivers/virt/acrn/mm.c @@ -171,12 +171,22 @@ int acrn_vm_ram_map(struct acrn_vm *vm, struct acrn_vm_memmap *memmap) mmap_read_lock(current->mm); vma = vma_lookup(current->mm, memmap->vma_base); if (vma && ((vma->vm_flags & VM_PFNMAP) != 0)) { + spinlock_t *ptl; + pte_t *ptep; + if ((memmap->vma_base + memmap->len) > vma->vm_end) { mmap_read_unlock(current->mm); return -EINVAL; } - ret = follow_pfn(vma, memmap->vma_base, &pfn); + ret = follow_pte(vma, memmap->vma_base, &ptep, &ptl); + if (!ret) { + pfn = pte_pfn(ptep_get(ptep)); + if (!pte_write(ptep_get(ptep)) && + (memmap->attr & ACRN_MEM_ACCESS_WRITE)) + ret = -EFAULT; + pte_unmap_unlock(ptep, ptl); + } mmap_read_unlock(current->mm); if (ret < 0) { -- Cheers, David / dhildenb