From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAE73ECAAD8 for ; Wed, 14 Sep 2022 10:03:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3727E8D0001; Wed, 14 Sep 2022 06:03:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 321AA6B0073; Wed, 14 Sep 2022 06:03:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C3348D0001; Wed, 14 Sep 2022 06:03:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0C96E6B0071 for ; Wed, 14 Sep 2022 06:03:13 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D08B1A1226 for ; Wed, 14 Sep 2022 10:03:12 +0000 (UTC) X-FDA: 79910253024.20.10ECA98 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 66A86C00C8 for ; Wed, 14 Sep 2022 10:03:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663149791; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c1ETyT+v8pgJCm2Ac1OrFwTV0+ZElI/JolxfD221azM=; b=aELWjt2FXGhnhNwRe7HZvm2nxnlTzMShZmv5tFn+dQ5V4peGdSkFvAVCJrWczkYMxDMQ4v ZJnhL2iQNGN5LQEZhmsg7hPmvErg0qx4b1q6lyZvtweXjCHXVedGQbPRM6a85Y/2BEGAFD apxy5Yi3Icss8GOBtt7ll09o7zr18qg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-154-X-_Znyo-MDq9QLWIFbH0Xg-1; Wed, 14 Sep 2022 06:03:10 -0400 X-MC-Unique: X-_Znyo-MDq9QLWIFbH0Xg-1 Received: by mail-wm1-f71.google.com with SMTP id i129-20020a1c3b87000000b003b33e6160bdso9094822wma.7 for ; Wed, 14 Sep 2022 03:03:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date; bh=c1ETyT+v8pgJCm2Ac1OrFwTV0+ZElI/JolxfD221azM=; b=rlNz0t2SMhxOvoovQFEMZzKetULvarGOgESSW8n7muHk+LOSKeMC0VvNUiMajStKEA j+0K5QYwvPcSqStnEBeYIyhb8et8DoiVU6WabvuDM6gOHXlb5SlgjXrtVEgsMTU7pEqH EucdVxucjq5fcK7m3tnh7CtxjDeGdqxu2Np0VAIt1mo1vPT9TMRQ14iDS7Nw1gZdrjgn JyNl8wOOvsjM3DDwy0XMducluH002KZ+OhVWpQuH0yCxNdQfnf7u/et01PQviVHty70b kH/j5p64zVD8T5etbAuJ0CkWSl/FKZdh0+V0EtqekXCrJxGqkBZVIom9j6RuNdyJz9hp r7UA== X-Gm-Message-State: ACgBeo25s/uwjTLeGfd8BcgCL0kH+2VkEFu1mJc453fwZL457RHdqbl7 D2bBRCW5h7oS56pgMdK+7RrP5FCHxpHmwqI1efTkNaMplNgcQL8rcf5iDJorYjAFY56S35UPxLB Oapf6DdPrQV4= X-Received: by 2002:adf:fac9:0:b0:228:652b:a33e with SMTP id a9-20020adffac9000000b00228652ba33emr20734050wrs.61.1663149789416; Wed, 14 Sep 2022 03:03:09 -0700 (PDT) X-Google-Smtp-Source: AA6agR6t54ZB4vYC+AeZy1aRNmx2WUEQiFF9CWkoqYZB6+Tnw9U8ZHRQ21b2Sk/PoUkMxNISv/pVzA== X-Received: by 2002:adf:fac9:0:b0:228:652b:a33e with SMTP id a9-20020adffac9000000b00228652ba33emr20734024wrs.61.1663149789110; Wed, 14 Sep 2022 03:03:09 -0700 (PDT) Received: from [10.119.22.46] ([89.101.193.71]) by smtp.gmail.com with ESMTPSA id t3-20020a1c4603000000b003a5c244fc13sm16971787wma.2.2022.09.14.03.03.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Sep 2022 03:03:07 -0700 (PDT) Message-ID: <7d14feb6-24a7-c114-c9c0-9ff3d8f4f448@redhat.com> Date: Wed, 14 Sep 2022 12:03:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v4 1/2] mm: hugetlb: simplify per-node sysfs creation and removal To: Muchun Song , gregkh@linuxfoundation.org, rafael@kernel.org, mike.kravetz@oracle.com, akpm@linux-foundation.org, osalvador@suse.de, ying.huang@intel.com, aneesh.kumar@linux.ibm.com, rientjes@google.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, muchun.song@linux.dev, Andi Kleen References: <20220914072603.60293-1-songmuchun@bytedance.com> <20220914072603.60293-2-songmuchun@bytedance.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220914072603.60293-2-songmuchun@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aELWjt2F; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663149792; a=rsa-sha256; cv=none; b=C5G1yszPa6PcMOcJGwFVfHW+RSJS+jdsMxPG2+MuvitgvI7BdglPmzt8EqtKQOHqVUgwuD /iBMAnptcVitW5N53LO6xl3iBGCsYqahwqU4oD19PVQ7+hNRtlNNnaDQQ9uMA9T0VYtLju lLSWrcpnCbkLJzDkHtVter4aqOH2gvI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663149792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c1ETyT+v8pgJCm2Ac1OrFwTV0+ZElI/JolxfD221azM=; b=oxP/sYJeqKB5+saQZ8MlSr3zrkGvxMkb/CCzGP3YUbpIm5GQcpJy8J4hOnicwc7r0EQ5gB lx/e8zzVYNjmHMWroAuhNVliYF6xolEoK0AJyCHpiV4MKZ0b+G7fQnYfKpEvjevJYuZlnO 1TxF+NSlXb0xHl2oMRsjanxXBpYUopg= X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 66A86C00C8 X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aELWjt2F; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: tzwmgifekagwug4g81ui9drjh4sndrin X-HE-Tag: 1663149792-313467 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.09.22 09:26, Muchun Song wrote: > The following commit offload per-node sysfs creation and removal to a > kworker and did not say why it is needed. And it also said "I don't know > that this is absolutely required". It seems like the author was not sure > as well. Since it only complicates the code, this patch will revert the > changes to simplify the code. > > 39da08cb074c ("hugetlb: offload per node attribute registrations") > > We could use memory hotplug notifier to do per-node sysfs creation and > removal instead of inserting those operations to node registration and > unregistration. Then, it can reduce the code coupling between node.c and > hugetlb.c. Also, it can simplify the code. > > Signed-off-by: Muchun Song > Acked-by: Mike Kravetz > Cc: Andi Kleen > Cc: David Hildenbrand > Cc: Greg Kroah-Hartman > Cc: Muchun Song > Cc: Oscar Salvador > Cc: Rafael J. Wysocki > Signed-off-by: Andrew Morton > --- Acked-by: David Hildenbrand -- Thanks, David / dhildenb