From: David Hildenbrand <david@redhat.com>
To: Muchun Song <songmuchun@bytedance.com>,
gregkh@linuxfoundation.org, rafael@kernel.org,
mike.kravetz@oracle.com, akpm@linux-foundation.org,
osalvador@suse.de, ying.huang@intel.com,
aneesh.kumar@linux.ibm.com, rientjes@google.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
muchun.song@linux.dev, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH v4 1/2] mm: hugetlb: simplify per-node sysfs creation and removal
Date: Wed, 14 Sep 2022 12:03:07 +0200 [thread overview]
Message-ID: <7d14feb6-24a7-c114-c9c0-9ff3d8f4f448@redhat.com> (raw)
In-Reply-To: <20220914072603.60293-2-songmuchun@bytedance.com>
On 14.09.22 09:26, Muchun Song wrote:
> The following commit offload per-node sysfs creation and removal to a
> kworker and did not say why it is needed. And it also said "I don't know
> that this is absolutely required". It seems like the author was not sure
> as well. Since it only complicates the code, this patch will revert the
> changes to simplify the code.
>
> 39da08cb074c ("hugetlb: offload per node attribute registrations")
>
> We could use memory hotplug notifier to do per-node sysfs creation and
> removal instead of inserting those operations to node registration and
> unregistration. Then, it can reduce the code coupling between node.c and
> hugetlb.c. Also, it can simplify the code.
>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
> Cc: Andi Kleen <andi@firstfloor.org>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Muchun Song <songmuchun@bytedance.com>
> Cc: Oscar Salvador <osalvador@suse.de>
> Cc: Rafael J. Wysocki <rafael@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-09-14 10:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 7:26 [PATCH v4 0/2] simplify handling of " Muchun Song
2022-09-14 7:26 ` [PATCH v4 1/2] mm: hugetlb: simplify " Muchun Song
2022-09-14 10:03 ` David Hildenbrand [this message]
2022-09-14 7:26 ` [PATCH v4 2/2] mm: hugetlb: eliminate memory-less nodes handling Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d14feb6-24a7-c114-c9c0-9ff3d8f4f448@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
--cc=rafael@kernel.org \
--cc=rientjes@google.com \
--cc=songmuchun@bytedance.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox