From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 366D4C54EBD for ; Mon, 9 Jan 2023 14:46:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C3908E0002; Mon, 9 Jan 2023 09:46:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 973C28E0001; Mon, 9 Jan 2023 09:46:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8148E8E0002; Mon, 9 Jan 2023 09:46:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6D9748E0001 for ; Mon, 9 Jan 2023 09:46:11 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4213D1A06EE for ; Mon, 9 Jan 2023 14:46:11 +0000 (UTC) X-FDA: 80335535742.27.53BD709 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 5FF8214000A for ; Mon, 9 Jan 2023 14:46:09 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iGbL9ZFK; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of jlayton@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jlayton@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673275569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xgtAtVBH1Vyv6Kj1UevcBC0uMuGeG8DqErw1vWGcO4E=; b=GjRwhvYvRMx6V4DcipcBVAadBVqGLz7vHbknxOnvrB4u5KaPnSzeAX6Gk2IyOv9oCYw0Ih S4xwpOFkvgKtFu28PMjQzDtlK5VlNaH2XTsaoNDjrZhZpTYeqHiF+fFmctlIpgKthUl6af zgQ/skLHMjTp+LTcZWYrxwJM3tVq86w= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iGbL9ZFK; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of jlayton@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jlayton@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673275569; a=rsa-sha256; cv=none; b=oG1ll/8KhWEGzfH2T33yG7gMpz8oSInHuQsFCJ1+wU0TqNHU0sgyWSX1SfScv7nA2rTjKG Oz5VxwNR6f4KumKl2pGbYZvUrXc2JhpZsXR0dm6GNsS9OdT52RuRynEzp32leE6QoX2iZS QB4bBePqu2evo4XJ9TGhJWcL1erMVvM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673275568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xgtAtVBH1Vyv6Kj1UevcBC0uMuGeG8DqErw1vWGcO4E=; b=iGbL9ZFKU5tGmfLl+NJf2NLLfWtNClgQx6jjxHe8WGKStt8eo1+pUJSV1zBYS38LGDmXHw iYXQLsRkjDIADKGNLtUVyl1gFlWO1fR9kLFqOzIISWTg41PLNQCYaBmrw/NNySRpaR2V/h WJuYYetzgvJgVmtxooIhC09N4oeeQZM= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-650-pGfQ4ZYYNZe0dX_KrNphrA-1; Mon, 09 Jan 2023 09:42:38 -0500 X-MC-Unique: pGfQ4ZYYNZe0dX_KrNphrA-1 Received: by mail-qv1-f71.google.com with SMTP id nt2-20020a0562143c0200b004c74f7ec3afso5247737qvb.2 for ; Mon, 09 Jan 2023 06:42:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GqO8WP47IGCJ8c3pWUysSVCAJdwUf/hbc3Q+tFowqGk=; b=FAHObz++8Da6FIq2x3Z9XLhFaOb+xmgZWHWvRjYqfoDnF5wCiFrWNXBjvouySjjTF7 MXup+e+1/BXY7APZ5ShGKG05Mxsp229sPnPZfRh7QrFJlqyyvbMktPGZVnu1FMCYSYfL ruLlAvUkf5kqewltOqEfBZr+zBmyBBw5wnP+6hHW4JG3EAV+eE38/qdY/pDTvaiPItFO MBpRTF+Kfeo9X4t5fjjM4UfLhi1lM1YbF9HOxeJ2II1DWKQdkvVhUVjJWBFvygKy6VoY zL6iP598qhe+TVbL3XJgpGfSIFKi/Pa3opnELDAo7pBnd82VBhczgEVm5HilOid/xEOq twzQ== X-Gm-Message-State: AFqh2krGCvHKZjTAJCFlWbW7yfCFb/5eMw9M7xvAZ9UImKJrwvcIHQ3P eSFmJ2d7v17jHvSAiTsPkamKHLB//FRfISrFt1VZYpCm4uny3lCA4MyB8t7siS3ZlnBBRNVWYbK WQtxDwIsoxc8= X-Received: by 2002:a05:622a:580c:b0:3a8:2b87:9fd8 with SMTP id fg12-20020a05622a580c00b003a82b879fd8mr98712598qtb.48.1673275357937; Mon, 09 Jan 2023 06:42:37 -0800 (PST) X-Google-Smtp-Source: AMrXdXvDhPBJIZ+E0FoPfewXrYweMlU/l4+RY/bsNUbu8cqmPky9X6H++s5bY2nvviwUmzzUYAd2Tw== X-Received: by 2002:a05:622a:580c:b0:3a8:2b87:9fd8 with SMTP id fg12-20020a05622a580c00b003a82b879fd8mr98712581qtb.48.1673275357707; Mon, 09 Jan 2023 06:42:37 -0800 (PST) Received: from [192.168.1.3] (68-20-15-154.lightspeed.rlghnc.sbcglobal.net. [68.20.15.154]) by smtp.gmail.com with ESMTPSA id q8-20020ac87348000000b003a8163c1c96sm4611187qtp.14.2023.01.09.06.42.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 06:42:37 -0800 (PST) Message-ID: <7d1499fadf42052711e39f0d8c7656f4d3a4bc9d.camel@redhat.com> Subject: Re: [PATCH 08/11] cifs: Remove call to filemap_check_wb_err() From: Jeff Layton To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig Date: Mon, 09 Jan 2023 09:42:36 -0500 In-Reply-To: <20230109051823.480289-9-willy@infradead.org> References: <20230109051823.480289-1-willy@infradead.org> <20230109051823.480289-9-willy@infradead.org> User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5FF8214000A X-Stat-Signature: 8ggn6kpesrduy93ws1ktssf5fmtyign1 X-HE-Tag: 1673275569-148196 X-HE-Meta: U2FsdGVkX1+NQhOf9cqF3vi+ed7BfVpJmM2W9+7odadXtmaJIcM8EmksALTbhhKrvXmFBeMQljCxfeOSU7TtcHaUyOtQbnQggV2NEnzn9gQbQb473DSK1vaOxKeZZ8PH0V+5W1U81tzDmq5q+58erlGznXtdQvsozjiwKx070lIB1weDsehY+BNLi1Sg20od9CM4T+g9lFZs+8PYu63zqED0hI/wpdOj//jEu/NM5ssVhjR976RV9CVs77vE0TCfsNb7AWbS7X3o7tjB18nzqRuaQXnf/W6BZ//oL/CCUvw+r0ReAROdaO7VmZ2mmkgU/E7T99IDHsW7py9M2fOnuiFHmclZ+QO21HAoyaPKZe4If+PPC8Q4QXS9gpfMvc4XTVo/ihN+guDLc/NXBp6DvA5ZOWUCROQLe4BQmfibjVE07mI6+SIAaelqWmNtUbh44ap5XomcIoroex2glSSJPypqa98+Xa7hptUEXTUTyyBP5PKEIx89RGQ0KM+kaZiPwW62QzqSyirp65gZIJxx111yOrn0rlkOUmIrNkusPcJHOX/nT5EM6/Vu/3vgnkMN7/oFfO8XArAnLW6drhqZdwlu4pt8P0d8vTGA383kgf8wwbyyOiGHHYcbgFGgHEFqwDDzwOW31rf/Q6AYIfKpvD9vUD4bPOKS0W8J5Q7S8+Q4MffWwL3qJGmIPYbg9hIDkeTChUQ+UT+q+aihbhsWcGTxwoU6AFi3cIovk3OsZp8Npxucm5oYZC5Ypujrl0Jt84RZtaAND/IASapMR7ROqtnBFFTpFtIxnsgI0Q8XrRHBAhyYeQfet+FXW7LjYpzwsPi2ok9VMnz4WFLv/YNIK3/mUYiCCyjDQYk3Jsv0fuHNkVr6dSAru+WRckpTPQzaKEhpBD9BhKhi5sW1CC+w2naUdiJQnb51ThI+u5BjRQw3GdslMBAc5HcKKClC/iEUaEXUvsziRgcHnwl1g6K QJ5ArAJ3 N3bEb3mmIi5ZMa82Dzb6peYlv9uo9KI801/G4Ey+M0O2ie+EKpGYK7IlpGswFLNIp1P0s+Y+lDPH9MD73VwzecWeIyA3CX3TPCiwkRk5mBeo01ND1YcNBsOYThKSypZwftKdAa5ebYGiZMWSLaSfHf62S6A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 2023-01-09 at 05:18 +0000, Matthew Wilcox (Oracle) wrote: > filemap_write_and_wait() now calls filemap_check_wb_err(), so we cannot > glean any additional information by calling it ourselves. It may also > be misleading as it will pick up on any errors since the beginning of > time which may well be since before this program opened the file. >=20 > Signed-off-by: Matthew Wilcox (Oracle) > --- > fs/cifs/file.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) >=20 > diff --git a/fs/cifs/file.c b/fs/cifs/file.c > index 22dfc1f8b4f1..7e7ee26cf77d 100644 > --- a/fs/cifs/file.c > +++ b/fs/cifs/file.c > @@ -3042,14 +3042,12 @@ int cifs_flush(struct file *file, fl_owner_t id) > =09int rc =3D 0; > =20 > =09if (file->f_mode & FMODE_WRITE) > -=09=09rc =3D filemap_write_and_wait(inode->i_mapping); > +=09=09rc =3D filemap_write_and_wait(file->f_mapping); If we're calling ->flush, then the file is being closed. Should this just be? =09=09rc =3D file_write_and_wait(file); It's not like we need to worry about corrupting ->f_wb_err at that point. > =20 > =09cifs_dbg(FYI, "Flush inode %p file %p rc %d\n", inode, file rc); > -=09if (rc) { > -=09=09/* get more nuanced writeback errors */ > -=09=09rc =3D filemap_check_wb_err(file->f_mapping, 0); > +=09if (rc) > =09=09trace_cifs_flush_err(inode->i_ino, rc); > -=09} > + > =09return rc; > } > =20 --=20 Jeff Layton