From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35A76C25B74 for ; Tue, 21 May 2024 15:37:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A853F6B0083; Tue, 21 May 2024 11:37:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A34826B0085; Tue, 21 May 2024 11:37:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94B0C6B0088; Tue, 21 May 2024 11:37:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 777F16B0083 for ; Tue, 21 May 2024 11:37:01 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 005631A10FC for ; Tue, 21 May 2024 15:37:00 +0000 (UTC) X-FDA: 82142806200.21.46AD001 Received: from out0-211.mail.aliyun.com (out0-211.mail.aliyun.com [140.205.0.211]) by imf23.hostedemail.com (Postfix) with ESMTP id 906E314000A for ; Tue, 21 May 2024 15:36:58 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=antgroup.com header.s=default header.b=1PDxK98a; spf=pass (imf23.hostedemail.com: domain of libang.li@antgroup.com designates 140.205.0.211 as permitted sender) smtp.mailfrom=libang.li@antgroup.com; dmarc=pass (policy=quarantine) header.from=antgroup.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716305819; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0F8utKmHBsqT5aaZ1shtTgjkR7zRzQ1wD7Atj7HfE5s=; b=l6YXKXTRbbW0KUiAplYEBoc6gQqyS6elONrJ/Bh1RC+u70KvQXtDCI5s9ljL1m9B1KtUR9 jlk73YlMpgVrp/yg9e4iMJt2kRKWJXXWy6g9rikLWwmHYyeRfV/yt2wE1R9QpH99pbHOWI cujUZTbvTdDrpgV5JZ8mY00SsSsPrac= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=antgroup.com header.s=default header.b=1PDxK98a; spf=pass (imf23.hostedemail.com: domain of libang.li@antgroup.com designates 140.205.0.211 as permitted sender) smtp.mailfrom=libang.li@antgroup.com; dmarc=pass (policy=quarantine) header.from=antgroup.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716305819; a=rsa-sha256; cv=none; b=ZZFbtNBq1dkx+nOE9UmCB3L+fPx/Tv7/ir736F9QqjSRcyeZveWGFydPd9xdq6xDlKdfnF oFxq1q1HQ/+3RGguFYBqeqvBouLmZH649zAN5rIGrAVVkp+5gR6gAsOw3+BDTitj9MajOl BmGxf8Q0TCR0Z3t6rpODOUr+j4jb1bU= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=antgroup.com; s=default; t=1716305815; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=0F8utKmHBsqT5aaZ1shtTgjkR7zRzQ1wD7Atj7HfE5s=; b=1PDxK98ajQsWd/viW0gggAq08f+ifUj2FceeJqLSs6nXi9MYzV7VPNV2Xk9K12oxMUybl/GA+3vakqhG03qn7nKdVet9x3d0hHzLCDRhuWiC6UUebIWMacK+eYVsAJPFBDajnhr0FHKUcbAuLKmkt0cFS3VN1292lk/1uyNsYPU= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033038033188;MF=libang.li@antgroup.com;NM=1;PH=DS;RN=15;SR=0;TI=SMTPD_---.XjOK43f_1716305812; Received: from 30.236.49.195(mailfrom:libang.li@antgroup.com fp:SMTPD_---.XjOK43f_1716305812) by smtp.aliyun-inc.com; Tue, 21 May 2024 23:36:53 +0800 Message-ID: <7d00705a-8a6b-48a5-8aba-7e789c536e2e@antgroup.com> Date: Tue, 21 May 2024 23:36:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] mm: Refactor update_mmu_tlb() To: David Hildenbrand , akpm@linux-foundation.org, chenhuacai@kernel.org, tsbogend@alpha.franken.de, paul.walmsley@sifive.com, palmer@dabbelt.com, chris@zankel.net, jcmvbkbc@gmail.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, ryan.roberts@arm.com, ioworker0@gmail.com, libang.linux@gmail.com References: <20240518074914.52170-1-libang.li@antgroup.com> <20240518074914.52170-3-libang.li@antgroup.com> <4650b888-d90f-40e3-8c53-c9949e539959@redhat.com> Content-Language: en-US From: "Bang Li" In-Reply-To: <4650b888-d90f-40e3-8c53-c9949e539959@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 906E314000A X-Stat-Signature: 6k4qnircnpk3nag76ipe7o5oaeoy8r9h X-HE-Tag: 1716305818-891774 X-HE-Meta: U2FsdGVkX18KpohFX6nwRH8rG+CdWkWwWuJZE53KvZ4btXdomuIBuZl7xBLDp7Rd7dcvSio0aRogOd91rrpqhuHnyA1eb02zWX7Dt720Io0ukE/HGqV5wU3uSllP5aRK1y2fKqkmIm2NTdwXbnHwZpJYgCxtGnGK0by9eWGRo+KLsDWhrjaAVSSsty+KAurDW6Sjzj5agHFufFxuKnENr11u1Yf8wawlptCnGPxgpR94I5giFuoyuhIKxix8gcZILNrn/NgZvTc1f+epTZRDeBYPuEFm/fz7GykIqETBWfpjFdE6ajeyS35jtnbb75AeOntA7H8qPFvCM3VNiIvfjVvFH8K36Th2iYVByX11+ykwEtIP6tcysiNFWX23AZgVAWwwXq8mIL/qvDmrKpT9cpIWi60FTDKXphPKZcY2MEK91vQOg1c5riXjKLxZJNJt0CBWFahi1lrz86n/iQvSirzqS6tcfF94nr40IUSVfJGPVjgXJXN6GfUlzmQOZyRNlF+w/x8nReiJGVyF2IeUih3WFa8E5G5KxU32wz5XVNjxOmMD+hH30TCa848/CIOmYGgvdQVtjbN0jef9LVcQItexvAqF2U/CUqG1fpQdd0/imQCs1VL4yQLG7Md+A5dmdwCJ1qsNHPcq0PAH5LPV05cc6dEeZckJ9yjSP4lPaL05+/Oh6Auk/vyUV0vuUeNS1hf3BtsmQfcTC8UYZ96iGxVpWqh7dXdyac13NYkH2FJnZJyRcPbMzgHEbD/04z/D78pXqgrAXDqImHrJdfr+WqAdB+TY6kZqa4MtzJPMBVPGpY94LvTVgXFOVloXQSoeKVfxCQQCtdcH8UnxgoNAuRDXDSCA9wdH2d//8V9WagexBUbpzfYqynEmEuB0IDZWTNWF4Xw2Ml1Nr+oJYunPzKHLAgiiBri10FuBthdcdJcdaGHXdgZdO+1mjz2UzYgpsG4N7qb6D/Osm9iS8zP eVVbzJG5 B/hRTDVX2hcZsEmWNm6swP5eQ8tGZ06znJ2HNLNQkH/zp22pQ2M2QZ1Gm5TpgzB6I9TPWDjHMFH6dJ3VOq+opyvqffdWY46ZEKQnqpKGgaAOHKsCeXR7D5ycEom3iM8V4j6oB4VghgPiKnh6hctajS/yKLZRpFXgEynPSU64QKN1mwujtDYIOPU29Vgwi1kExvMlpyYmQuU/w1sPFFC9sDDawsVtHauuGJbGa65tUH09HxTdvJUIODKgquo8eQopCgrMh0qgAo6/tEtfujT5yhz/jWWGkg+nddQohGkNJd1zhSg77HXvWgvDnee7AtqmLOaKzWAOmiBfCtcDBjDLjdbQ0OUEorTClbgQlDCq7Qkw1ltcv8/NgvdqHfjKeTMp+khV8+j17uR5gG0cHQJ5ErbZ3nfMwrHSkuPKNjj55SXf00SkoAm9K4EQHTSz9EUTFtLCu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000414, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi David, Thanks for you review! On 2024/5/21 17:36, David Hildenbrand wrote: > On 18.05.24 09:49, Bang Li wrote: >> Remove update_mmu_tlb() from those architectures and define >> generically via update_mmu_tlb_range(), removing the ability >> for arches to override it. > > I'd suggest something like > > "mm: implement update_mmu_tlb() using update_mmu_tlb_range() > > Let's make update_mmu_tlb() simply a generic wrapper around > update_mmu_tlb_range(). Only the latter can now be overridden by the > architecture. We can now remove __HAVE_ARCH_UPDATE_MMU_TLB as well. > " Agree! Thank you for your suggestion, I will modify it in the next version > > [...] > >> +#ifndef update_mmu_tlb_range >> +static inline void update_mmu_tlb_range(struct vm_area_struct *vma, >> +                unsigned long address, pte_t *ptep, unsigned int nr) >> +{ >> +} >> +#endif > > With that in patch #1 Thanks again. Bang > > Acked-by: David Hildenbrand >