From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BCBEE77188 for ; Wed, 8 Jan 2025 08:31:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D54086B00A9; Wed, 8 Jan 2025 03:31:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D041A6B00AB; Wed, 8 Jan 2025 03:31:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCBB56B00AD; Wed, 8 Jan 2025 03:31:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A029B6B00A9 for ; Wed, 8 Jan 2025 03:31:20 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2960D160F77 for ; Wed, 8 Jan 2025 08:31:20 +0000 (UTC) X-FDA: 82983615120.14.E9DB895 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf21.hostedemail.com (Postfix) with ESMTP id 60BEF1C0011 for ; Wed, 8 Jan 2025 08:31:18 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736325078; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lom+i4v3PxfHxmognsFk46EQaMmrjYMhI/xbLHGccvw=; b=mDrW6XtFDNRQGAWhPSs+CpgohULNv638Cf3mRzRraXVOWDE90FV3IZICI9Z20o9ZGaTMAz L/KcO226hBtmgUwsvt1qFFXA7FqrScG4kof7701U/6IefAVs0zG/dGIIwQt1OvycGyD1t/ oTqD8560WzCJA47ys2bTgBbXQhWudGA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736325078; a=rsa-sha256; cv=none; b=2R89SkPYFoZ/hxiJRc51aAJTp8gXd0tdy0HSceTZLWhG24UDtgEPRa/RELgwU/67lTfQvp umCyvLIzyK5MdCaBiwxuj3laheoj1OMu/HkfSDKA4EY7UFGRr1frXJ9YbC6hipwMteWCrP J0HpkXi3CGX2morAwcVfHFvuKFYZQqA= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A875312FC; Wed, 8 Jan 2025 00:31:45 -0800 (PST) Received: from [10.57.94.52] (unknown [10.57.94.52]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 28A753F59E; Wed, 8 Jan 2025 00:31:08 -0800 (PST) Message-ID: <7cf8fa3b-799f-415a-82a1-eee6b7b2e0f5@arm.com> Date: Wed, 8 Jan 2025 09:31:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 11/17] x86: pgtable: convert __tlb_remove_table() to use struct ptdesc To: Qi Zheng , peterz@infradead.org, agordeev@linux.ibm.com, alex@ghiti.fr, andreas@gaisler.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org References: <39f60f93143ff77cf5d6b3c3e75af0ffc1480adb.1736317725.git.zhengqi.arch@bytedance.com> Content-Language: en-GB From: Kevin Brodsky In-Reply-To: <39f60f93143ff77cf5d6b3c3e75af0ffc1480adb.1736317725.git.zhengqi.arch@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Stat-Signature: 84zt63gf7f99fjuxnptuneor3mdbo9n9 X-Rspamd-Queue-Id: 60BEF1C0011 X-Rspam-User: X-HE-Tag: 1736325078-184079 X-HE-Meta: U2FsdGVkX199uYPm40uvSTFkLpE36EhKar810Viq8ppiwnZGj3DjzSqxU8CFsewwyK7kt6P1DYE35vcBtKHxBG1HuOKy8SI/Us0mMgfOU3iw32EubVdJNRS86aSUZNOU/1auZDPab5t+VLXFC0XxPXc7rqPTWs8ZHwefBZIGh1qKG6ltZuyHXQAiNpme6tTcThnB6+NlnTe7x36wD/D8qaCki/K74JinNngvKJFUYemQsR6FhUi5JMksWJQ31kyXrj5DN42OSYetJBUtwcDdZGI+PTsQpwPnYLC1jl3kWHYhUJdjyCbRg0+vf4GuRZdKupjI+CCJ/vL2EaVi/4fP9Lcm2Fs2++9fe13lOD15JDgNprwbz/Gn/1w/6o9U7nVvgQgJeBs/pbuccjp/HhjfCZTxq0I8wNP1H/jcDmuqXqhuN59I2CFF3mHOu+/MY50V/Ey4XMxK1vEwnF2yje0n2rg+8oZNJndkB4RbTojHjV/dToQJuFatbXTpR6+0wA4U3bbCuxtYxhGqIMfABaxjvQ1LUok3UByn3h3A+Jh08ra8iQ+7pUw4fwGYFNb15J+xeRhgi96BLhlldZM7qKsG3rynv4cJTDLhmg/h1NpGiBH9+Crsn/Fe2aWAVRn7cVUekXcF+QuBI0HYtEPcEJE8BE7jq8SKsdtTrXjWGjW7fzlsP/1jl1+5qQZdH1fjxrQPSvPLy1N1DpbpAswkDw0sJycSovbgQjztlV/ShXtsjQf/ddWrNAlI6SWT6Qvv7Oe8pTgYaropmhbJWl4KaAUOdBejg24JHzz+GIprZuWgacpG87mTJ4RAuEvWnrRU42QsoyvqEIsoSwVwe37ZZPw+Rp44X08AMakt4akEmytIvXiQbJ1fPPsHA7fW7csTkh46a4UeYZgVFn98k4M7FlIH+JdxcdtvGVJ3em5o5DUZfKuFtFUgK65HVkVfGtRN8gX3+hLatpbbaHEtd5PPVih PYx/lZjR gqXjd9LiOzeb6j0rpjJtlDVBQcFO3UHTU54GXmXXo1fojPUqTG5AmKWjLoYfvQ2+VP0lWpBSA+svFXM8qgNbqBrWEQV3ZeONOYFFMMejst/yc2zrz2ZwWLFsfGW2f7P5WP1j1Y4dFpydtYMfo7Gs9UnzBO6FkqUKAmj/9vkrPU4+lRimaAJxSep64CsQnX5YhoPaF2KgGIOXDFyoFqUep4tFAmIwpzr2tugvvjA91fyvLyAoS6hCwuZtoqloQsemuVAZLU1Bp1Amh5UtQdIOmuL4vVLvY5sSTQEL9THF0XPHmhyL+h+o+Slv5BWsqEyLYlsF7hyHiSX0MdQE6L0oKLGk3nw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08/01/2025 07:57, Qi Zheng wrote: > Convert __tlb_remove_table() to use struct ptdesc, which will help to move > pagetable_dtor() to __tlb_remove_table(). > > And page tables shouldn't have swap cache, so use pagetable_free() instead > of free_page_and_swap_cache() to free page table pages. > > Signed-off-by: Qi Zheng Definitely a good idea to have split patch 11 from v4. Reviewed-by: Kevin Brodsky - Kevin