From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE428D3C52A for ; Thu, 17 Oct 2024 17:41:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DF706B0092; Thu, 17 Oct 2024 13:41:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48F136B0093; Thu, 17 Oct 2024 13:41:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32FDE6B0095; Thu, 17 Oct 2024 13:41:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 134846B0092 for ; Thu, 17 Oct 2024 13:41:40 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C957EC0134 for ; Thu, 17 Oct 2024 17:41:27 +0000 (UTC) X-FDA: 82683811014.09.5F5B217 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id E85BC1A0003 for ; Thu, 17 Oct 2024 17:41:24 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X45UMVh4; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729186751; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WD58NFKSUJH1beOCgQ9bzXn281RIMWfE6n+jlFoZf6k=; b=gdHfP3acYNTSPZpWjI01ERxnFKZ6ocOq5brGzvXvEifzrR7OKUmVBPthUDRdJi63muju5X D4OC9Inxy4Z8NRTY6U/NM7vDyn+Q7W3pGflirWCOiBMFt1NBVKms1NfjU9OAAVZjC7N+ru 6kuwWiDKQVJUg3HwzQt8GGhu+tcR/q8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729186751; a=rsa-sha256; cv=none; b=nCV4hY0mePp8fGRtk1GNvTNJqleE6FA5hZcweax4/LXrvfgmKgzwQ5JHqn7ztAnlHNb+w1 uGOJza1Mgw5mxRdO7l8N1GrTJLL79Wbi16IpQDaNesjg8X8fRFpBqy17yTTJDWnFHk77Qf FlfQQr2kZY8un3gKyf3FkZVyeC30wy0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X45UMVh4; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729186896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WD58NFKSUJH1beOCgQ9bzXn281RIMWfE6n+jlFoZf6k=; b=X45UMVh4pxAr3z2hR9uDRq13FTjh/JX7GPFKFFKZGCv7gJD0QFSXeizIOHSmllIxHqQa/o UwDTwZfhBcW0r2ZlhmIf1AFG71ZnkXv75f46ipRQXU+NSLIupGJFVuxrxGZPoaqdYYcYaB uOYV8GtpJb9XMIJuzGdCVLyeeGdqELI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-404-DXQa-h0DPoewZ_r27csWCQ-1; Thu, 17 Oct 2024 13:41:33 -0400 X-MC-Unique: DXQa-h0DPoewZ_r27csWCQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4315ad4938fso7170215e9.0 for ; Thu, 17 Oct 2024 10:41:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729186892; x=1729791692; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=WD58NFKSUJH1beOCgQ9bzXn281RIMWfE6n+jlFoZf6k=; b=FVkFi3pZJnCOknYW2h8pUQ7r0PB0uR5/5Wg9ed5UhC7k3XhkpKIIZvDfA/ahzqyfWr EKQxldofE8sl01YYMAtqeetv9UmIDdGibe44veWY1F/R5y8U+8kwiAl9IfO2jgbi5UOy y9ejgX8wR06rnI2uX1p5bU+vpyxNNQ5OySLl2Jacfjgq9mNneC78wWu5EziX24Z0E2Ug wBWujzPJA0aG/lxygpF4V98i2p/vzhhzYHRXQQp+SoHWEnQvbs2TYQFt2l0Z1rNaczjg eFPye68Qf9SqGKuiu/3tyAHFhp40dUnRuCgLMh6l5LQx1XQA0H5WT2c2HKANDn5D6K2n 9u8w== X-Forwarded-Encrypted: i=1; AJvYcCVUi3LNQlLj3JVE9e0lew8IbbEHV6J/OG/wmHs87o15n4pqS7VYV35SccS3SzEPA1MZ9RlGTZRJkg==@kvack.org X-Gm-Message-State: AOJu0YzIsY+XiYN4hmD/riBSUMSygFEgdZcrcnIfK1YDHsDhlQlps2gi cbmV5+gBHY0c17LSi+/qDA127KmKZXkY519Kg8P/GtOcmaiNLGsXZ0DLr55UxOuGc903EJDKb2d DWVX49yaifoULOZoV3Be+3SlwAJA1tqjNFt2b8JGLCulFsPC+ X-Received: by 2002:a05:600c:5012:b0:426:8884:2c58 with SMTP id 5b1f17b1804b1-4314a284c97mr57092355e9.4.1729186892457; Thu, 17 Oct 2024 10:41:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF7Q8YV/bGvfsCWvSINswHl70oDdqfQTkQjXHzNMfSs6dkZIcmzxKrDlRzD2VLugx0b29PmbQ== X-Received: by 2002:a05:600c:5012:b0:426:8884:2c58 with SMTP id 5b1f17b1804b1-4314a284c97mr57092185e9.4.1729186892001; Thu, 17 Oct 2024 10:41:32 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:7600:62cc:24c1:9dbe:a2f5? (p200300cbc705760062cc24c19dbea2f5.dip0.t-ipconnect.de. [2003:cb:c705:7600:62cc:24c1:9dbe:a2f5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d7fa87bd7sm7872082f8f.35.2024.10.17.10.41.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Oct 2024 10:41:30 -0700 (PDT) Message-ID: <7ce32d37-18ef-493d-a698-42ee8a7421ab@redhat.com> Date: Thu, 17 Oct 2024 19:41:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf] lib/buildid: handle memfd_secret() files in build_id_parse() To: Shakeel Butt Cc: Andrii Nakryiko , bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, martin.lau@kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, Yi Lai , pbonzini@redhat.com, seanjc@google.com, tabba@google.com, jackmanb@google.com, yosryahmed@google.com, jannh@google.com, rppt@kernel.org References: <20241014235631.1229438-1-andrii@kernel.org> <2rweiiittlxcio6kknwy45wez742mlgjnfdg3tq3xdkmyoq5nn@g7bfoqy4vdwt> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: wsfn9s11n78ozsn1nan161a368stjrmc X-Rspamd-Queue-Id: E85BC1A0003 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729186884-377174 X-HE-Meta: U2FsdGVkX1/s4/nxVxsRTIUJVHNt18QfvI6cContMW64vbLSiw8Bcf8eavO6boRMrheC9gWwqd3pMUd0Br1aEYriJMt5zRZqTprWHtjAjj8gKZYz3GAWL08agGnHOz4DVIpJ9eG3nRS0x8j9Ofrr1j2RsJKRpXx8OUZfUKJtunC6lClpnxkFvg8uHp/obFdS1V9Oz/MI1luXeZMlGJE0g2ZNvEo4u5YYbQC53MGnzrxsuLoh8gb79O4pl8BD0t1h1Xooew6I6J9AjUmxqJPivQ0GM7Ejy3u8FYfYgQVFmrf+zI8PYEX9K6/B49h2FpbqxMJl/gHytl2dFFgH8aL5sHxfFNJKQJ43qVTM0B1R8yKKEJ8SoQ9cEbCDb1Bp8MNSTBO1K2RTB2a+3PrF/dZgzncTcUCaNMhhq/Kjmmb2l/eDGFDUhbgWGI/j32V0Qb16C6a++gDoFJ0ljnNFPf/wMnWRGx3OjsqsnQAjQ0YwJpMtBt/l6pdWcUBFc4a6WtPHUV9nkn+DSoVfU9JE+mgkRQTMGPmr2BtuDS8AVNMUmAZydhZbtqijtdaFq4Cy/6Gtk8AEjI9KEoJeCk1u8Atx/PTSDXCUwSOnjtaHr+cqQ9K6EBiqCfZYmlC8G/6FoFyDJ690bMnW7dnz+UDsBmGrgjDbHq22x1mWsyBeFms2NCcafg/Kxur0uFfOlvM6cfdld7M+ttMw6m5bUk0CA08HcN99s5yPAgfhbC8JL9mGRGh4fQ9uPKmXvPMUR/AQbganNCNawbCZD4cpSN99ILygdEbRLtoRPIYWKTiR3+pd48rVzZUfLFCuwhYXhub1KUOMxlRT1YyHauuNG6H5zrPZ+UnQXv7wANv+FeT2uzJCRCbPOpZVAMvqGPyJfbilKvONJ6/drDUbm270GcVAIS8ZfK58lU7ShIeaNVdL0DH6yxDLzhMQOJBD+c4dkQ3QZcVBBEUFS3JlvnnQGaafRLE GdSTlG/l iAC26bpi8Uptv+t619oobzG94h8h7h4q38Ce1C0RemLhtjhoZMj34UVc84h2HMckllksP6yyvnkkRVMk0o+oQqH9aMicpIO7lMsz+bDMfxlBTLVOW1nNTyxMF45A5pqqWYsqgH3ei7IXGuzjuru1WJPD8Kk9TeoynrKZdMD5GPjhViu6IVvvOgNUKF3tcrkYLDascYogdECTvnaSycfPyE0FGvQvHuqB+z0ermsiWyYDRO3Hj0sKomBiNlL3i4js4leHGmvxZZSv37i72vwpny70gQiOPaHmuS79UVD7LXKByv5ClQk4UkPWVTC7ajLegrenWVVyfWbyisKQS6z4tOis35KEZHywhXceRRgyhMf/JIAJTyGNiWi85rYAad9WsUUHf9z6ogjx+c5BnsnVQSJNrbXdYzrEPr61CH11fOR5/80QnGQnC0nnDXEomeKfhs7G93de0skZW2mpQ7ZiFbwYoYPQcivI4VDBdp2aDhtUBm5SmwuENSz3M4g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.10.24 18:22, Shakeel Butt wrote: > On Thu, Oct 17, 2024 at 11:17:19AM GMT, David Hildenbrand wrote: >> On 16.10.24 20:39, Shakeel Butt wrote: >>> Ccing couple more folks who are doing similar work (ASI, guest_memfd) >>> >>> Folks, what is the generic way to check if a given mapping has folios >>> unmapped from kernel address space? >> >> >> Can't we just lookup the mapping and refuse these folios that really >> shouldn't be looked at? >> >> See gup_fast_folio_allowed() where we refuse secretmem_mapping(). > > That is exactly what this patch is doing. See [1]. Hah! I should have looked at the full patch not just the discussion where I was CCed :) > The reason I asked > this question was because I see parallel efforts related to guest_memfd > and ASI are going to unmap folios from direct map. (Yosry already > explained ASI is a bit different). We want a more robust and future > proof solution. There was a discussion a while ago about having the abstraction of inaccessible mappings. See https://lore.kernel.org/all/c87a4ba0-b9c4-4044-b0c3-c1112601494f@redhat.com/ It would be a more future-proof replacement of the secretmem checks. -- Cheers, David / dhildenb