From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67B05CD11DD for ; Thu, 28 Mar 2024 19:36:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE8336B0099; Thu, 28 Mar 2024 15:36:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E98836B009B; Thu, 28 Mar 2024 15:36:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D116D6B009C; Thu, 28 Mar 2024 15:36:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B41026B0099 for ; Thu, 28 Mar 2024 15:36:42 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 595A21205F1 for ; Thu, 28 Mar 2024 19:36:42 +0000 (UTC) X-FDA: 81947455044.03.C88AB6B Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2123.outbound.protection.outlook.com [40.107.223.123]) by imf14.hostedemail.com (Postfix) with ESMTP id A51D210000B for ; Thu, 28 Mar 2024 19:36:38 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=memverge.com header.s=selector2 header.b="FDfw/8XR"; dmarc=pass (policy=none) header.from=memverge.com; spf=pass (imf14.hostedemail.com: domain of svetly.todorov@memverge.com designates 40.107.223.123 as permitted sender) smtp.mailfrom=svetly.todorov@memverge.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711654598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gb55yIJlgNqmxhFt0idp/5w0vzManHZ4dSyW2+Wts3E=; b=mbQw4iKsXELW2nuNQ1eaFfOXJjqdjC8g29re8wA7MlHsdu+pGrj40yP7E5IGI3/ibKb9GE HpeuyGjHA8VxsKiU59XF5/V5nrjrZuIz5Yvn9umRJd7tANMlvKxW/GyogMOK5uGotBb5Pa ZsQI7l3kgiu5sAerVInSoAkxPbS/if8= ARC-Authentication-Results: i=2; imf14.hostedemail.com; dkim=pass header.d=memverge.com header.s=selector2 header.b="FDfw/8XR"; dmarc=pass (policy=none) header.from=memverge.com; spf=pass (imf14.hostedemail.com: domain of svetly.todorov@memverge.com designates 40.107.223.123 as permitted sender) smtp.mailfrom=svetly.todorov@memverge.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1711654598; a=rsa-sha256; cv=pass; b=sfabCW5hDBZmO9iSizL5pAdYFmqoKKM/9ThFb+Fa5nkGqvMPKjT7nUcNWrzg2J7nbE93I8 iv5VCSJasqGjMlhr43Vf08uT69+1HiQWsROCz+poac8o+E25IujyBmPoNA3bZ7QEZ+RsAi cHPqbzJ78FA7+3Ad+nqhsPElTi32kRQ= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RiHnTyQ9DXH5wYMuSj52nTsd0mAHeC78c/jG33OteclWUp7FlfnF8O1d6GGNitxatsEkr3hPT4SF/gQw6ut+ty/1pG2PKx4q4mbcFrMR7Tfmto3eq51USySB3h2kZrkphLmznI0VG4+F9phnNR4Vyty8Zv7EgSng8PvTh1o9XECIBhbqRo7PRLPiw+bzmBC5fXofyrwdtWWaEHTFg3W+tKEfrsntnP1t9YH2G68g8qZMS4BQB+282CiTYc0t5Eryk8URLz5kTgzCDcTEAWQ6KinaPKZojiC3RJ73Ls8FPkPTWiD3xvuOMUHsuen7AiSLMmklz6nNgqSaDh2DVx3D9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gb55yIJlgNqmxhFt0idp/5w0vzManHZ4dSyW2+Wts3E=; b=ic5Ot6ddbnXGew2j1sPIS5sCjtchSHAEg0Y02pqFQ9J3GwokWo1q9B4QZh+8OPF0Dm44op7s1v6BwboUBS54Y0NLDwPhyOOhL+AOo4uE4rwx2CvAEFfWcoaKeiBAmTY89+Jp4HtiHFYnZibUSlTdHhkpicNbQPRUEgooeIT5MDW/9M+SoMnr22mgrFznmwlDuZnNXde+M8UMRIGo53G3FR2RZmzNjekLlZMVSXzAKcKu8YShjo3/rpCq5XOj+ctQ1IF43AnZ4tAmffGLwAdKaP0GSWjDFuQRZeGtCADOi0ojibMS2XjhIuc19GcdU+4HP0m4yFDGLN1o2BtSymJp1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=memverge.com; dmarc=pass action=none header.from=memverge.com; dkim=pass header.d=memverge.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=memverge.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gb55yIJlgNqmxhFt0idp/5w0vzManHZ4dSyW2+Wts3E=; b=FDfw/8XRGikp/FmJbdMOiHxDUBOAyidISlW2WWJryJTFSAfQAZUNvLePPgBBHAdNpn914W/07tKezViCaV3eQCP7tFTldg0KDi2E1m126a7+3yxiIHGvyzXLN/xsipmHXVFT2IF2jmI1sKIVADKbk2vRwVGTA9vvFROlPfgzMAM= Received: from IA0PR17MB6347.namprd17.prod.outlook.com (2603:10b6:208:435::22) by MW4PR17MB4465.namprd17.prod.outlook.com (2603:10b6:303:7c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.33; Thu, 28 Mar 2024 19:36:34 +0000 Received: from IA0PR17MB6347.namprd17.prod.outlook.com ([fe80::200e:df84:29a9:8c9a]) by IA0PR17MB6347.namprd17.prod.outlook.com ([fe80::200e:df84:29a9:8c9a%6]) with mapi id 15.20.7409.038; Thu, 28 Mar 2024 19:36:34 +0000 Message-ID: <7cdfb64c-c751-4a59-93fd-4bfa625c43ac@memverge.com> Date: Thu, 28 Mar 2024 12:36:30 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/10] xtensa: Remove uses of PG_arch_1 on individual pages To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20240326171045.410737-1-willy@infradead.org> <20240326171045.410737-3-willy@infradead.org> Content-Language: en-US From: Svetly Todorov In-Reply-To: <20240326171045.410737-3-willy@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR02CA0059.namprd02.prod.outlook.com (2603:10b6:a03:54::36) To IA0PR17MB6347.namprd17.prod.outlook.com (2603:10b6:208:435::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA0PR17MB6347:EE_|MW4PR17MB4465:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Sa6FR0xonOv1XQD4GPoQWoGXsBXw0q5EppAbRICxVALlNpHXzKNAwNN1zmIKshpSj0OC8StX9cenmsfwuoWy3p3+95kMrb7A/4BnwrHL6RxsqUdQYYeGp45xD1dYzm+pDFlssVSQfdaRekWa/YYSrqRbPIYUJvGRwRR8yjTdwK1NyJDPs3FwElRJ/We70NhEQij28I05z83XRfLqgxlBkmJP2Olg+usb+M7EOKhSgsLbioQM+L81g1b1pGUpx6JItlXgwwPGN8AmB1PI9yPu7vk5lLVcb4CBcSWt4zJn/js4E9eUE1bpy6jocn4gz7LD/VD6FyFfovIG77D+YBL2luAsgv7Sgm0K+mu0ZdpGviR+DhbMv2l9rAGRXTNqAANZWaHrIQTAfWIuE27G9/oPPZBK4D+v1e9h3RtXeGFRZpQ2gZv3VX0eWvxrtX50ktUFVawwbr0lUZxgpVZ5KXimeGGEXQ1Iosorh0U3xn8tiOPfARkfdnJpyI4BnibbJ2M8+IjScA1AlW2M8AW9NBt0CWXr/3IlBs4Y1NYwkZ9l6IBmGbGjqMbpIqM7kaw1wmN1ZG7Lat8vVLNAVnjKNFpRL2lRjuNNSMV8AfjVdaTFZc+NiDR8kPacsqznRx380NmCAgFLmAWb19on4sDJD4y/Dkv4aoTELx+YL0TODU4yJdI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA0PR17MB6347.namprd17.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFg1aTU2TmxXOTY2WmM1L29ESFRFaGlQVFh4Z1RhTUk2Umx6UXZWUGdwRGRl?= =?utf-8?B?TFpoYlRZZnQzaS8wL2dOUklTZktXWmhNSzMyTUprN24zV1pNaURtVGorOFVj?= =?utf-8?B?bWoyZlVFSTMxL013OGg2dEM3Wm5yZ3dOd0hvRmFnSVR6NU9BaFFFeWcrTzBF?= =?utf-8?B?Sk1PNDdDMkk5T09NcnlRY0JIR2FmWDl1L0ErV0RqTlF1QjBqVHN3ZHU4UXZz?= =?utf-8?B?WVBjNFJZaW92aHZETEljbnN6b2ZqQU5tcU90elJoekpFNVNXT3pYUytlVzN1?= =?utf-8?B?cm1yeDVvK3A0eWJvajFsckVLYXR2c21OdmpPQWViTHUya05uNWdQNTA1Qlgx?= =?utf-8?B?cXhuTjljcnNsOGpxUUZXdFRPL1ZDVm9VZ1M3Z2pWeHNrdFcxLzdXeGx4U1M2?= =?utf-8?B?cWxBRy9OeGlXLzBPMW5ncGlncW9UNTdLS2xzNnlxeXJ1QTEwbnAzb1ZiSVZM?= =?utf-8?B?TDNlODNyeTJmc1pVSGhSanZUYUNwRlRXWEpIZU5VSFBOVTJUNVpqOHpnS0d1?= =?utf-8?B?WTAreW40c1FhTDJ1ZVhtaHArTVFwODZjNjdrZDFnaEMrU25CaGlVc202dEda?= =?utf-8?B?bWxtK0djMzdVNUgvZVpsL1dFa3R0WThXaVpSMUxMQnlZbHhMZW5zVzlnaDhV?= =?utf-8?B?b2ZHK1lXT2VsU2dCSFpiRVdKUVFISjNlbHliVytvUFd1WWlyZ1grRWRFam1l?= =?utf-8?B?V004S2I4MnBSb2JaQWJ5amRHTzZpTWc2MDVsNHZOcThhclRub1JqcU1sWGxs?= =?utf-8?B?RXJYajVXKzNCcFFrc0ZsaGxsanpFbjBMMUgzcUhnUGN1WDlhRlZYdnhUQ3RC?= =?utf-8?B?ZDdic0RZbHVWUzl6eUFNaThieEpiTmpqb1NYZU0yWVg3QXUrNWsvY2xVOGlZ?= =?utf-8?B?enJhSjJTVEN0ZTl6a3RlMlBDYk8xbDk4NU1Ma3VSTXVFTXo5SzhkZ0xiaktQ?= =?utf-8?B?YXVGMER6QVdaakR0UGNpcW5yM3hERW1hREFGeWJ2dlFPY1FPNXdvK25hTER1?= =?utf-8?B?bGdUdmp6ekx5a0hJc1g1K1YyVWVTMThJa2hQMTNybTRpOWx4YlE2Ulk1UW1n?= =?utf-8?B?bzZ5NlpnR3d4alVYQUE4SEo5aGFXYkhQNFpLUWZtdk95ckI3NkV3QW90M3Bl?= =?utf-8?B?aVRFQkladk9vVW11VDZwbm0yUFRINzZ5Q1IzdDJCM1JiOWwyVUZRUXNoWFRV?= =?utf-8?B?YUpySUoySjRhckdnNGpDdXpMK3A1cmNNaG1iQnYvK2lDWkJTcWZDT1phcDQ0?= =?utf-8?B?SlhPZkphTVE3d2R2eVJXcW5RSUQwVW9PVHRrblEzaGxrOEdPS3RsNVY3YXg2?= =?utf-8?B?bDNLU2grR2ExNHdNMWdhUEkzT1Q5eEsxczhHVHo4aHVxb2pYM0FydnJGWll0?= =?utf-8?B?clNmZVh3TVhJY1ZIeFV6TlRhMTVaa0taajczcDBrdVpudm9mdTJndlJhLzdt?= =?utf-8?B?bFJTZVp6bTdhZmJ0UUNMYnZ2aFowZElTNnp3VTBlZ1JjZXRSOWFPb1lEbmJv?= =?utf-8?B?WXpueTdJKzkzN2tOeVJ3RDFEOE9WNzM5VE1rMzdQaCtRZFR2YXIxS2dnRVhi?= =?utf-8?B?NmUxTzc5ZG9PV3hlU2R1RDB5aVhXdHVLVHMzT1YzclNtUFhweGhrVGd5V0xU?= =?utf-8?B?aVZjbVFCLzY5Rmt4ck9aSTZ1TnZrWHJnc0QrTTdaMC9mQ2J5cmJuYTkycnlu?= =?utf-8?B?WXJhdGw3bERINExVei9TbWVyei9aL1hhK1lXL1hYZXVMWHBDWjJxZmFaSnJ0?= =?utf-8?B?UW1NMUlhRFN6OGxmQU5JdUFjQ2U5QTZ6ZFlPTnNpVXlRZ2tSR1pSYkNkN2VE?= =?utf-8?B?NDJuTjdtcWhRWkNOWVpUNmlQTXhWSXd4YXJvQW16alRqTjhxc2FFVk1wVG1H?= =?utf-8?B?L3BDM2MxQ2xySnF5TTlaRFgzb2IxUzU4QWt5UVo3eFVrWEcxZ3l4cjFwSmtz?= =?utf-8?B?aGJoOWdQZUVGcWhGVGlzM3UvaDJYdzVhaVBBZ2lTNDVma2Z1WDYzMlBLRVYv?= =?utf-8?B?OEYzdFR0RnNnWkZiREI0eFphaEJVVkhXeXhoTlBPdWpCejhIVGxCYS9tK2lr?= =?utf-8?B?Q0wvL2x5SXVGbjdBUWVldEgyejJCUUs4UnZ0Rm01dXVxSGQ5N1prbVg4NDRU?= =?utf-8?B?SG9WZFgzVzMzZEJTNnRndmVLeFJBRXJLalM2OWhnR3ZHSnptY002MnU1b3VS?= =?utf-8?B?Z1E9PQ==?= X-OriginatorOrg: memverge.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45410f19-2309-4a35-5ba0-08dc4f5e5feb X-MS-Exchange-CrossTenant-AuthSource: IA0PR17MB6347.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2024 19:36:34.1915 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Eumi3vLyuYoj9qr9d7+DnN4d4ANXmBwwsubAbW4vE8HeGSi0Bm7W4kml13N88r6b9GTmLC2ha8Wwk/0wpdxcxDx9juhuv9DpnD64gICl51M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR17MB4465 X-Rspamd-Queue-Id: A51D210000B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: qag1ngeo5uopjd4iqgijjatui6quzfmu X-HE-Tag: 1711654598-293635 X-HE-Meta: U2FsdGVkX19MdwqpMj40rjrPXw8p1phbKUJ9A07maa0YEokBd2/S4ToPhwY60mbbwKo8QmEz11k6MnJrN8UWpnrpNguSmKARVjOyWYKfUjMTDSkTgfS/TM19baOuHshxfLdNAVNKygbxOJ4twPta002uEHLTMkedw9M8MOzsWWh8RxDm2IoJu1P1xq4eLednVoHZCHuv3DMjstzn1yTTF/oIMvhGx0rpMnUadpEzj878/zjFgbojF41qnVhBqgEsuR/iEhj1das6NaDeHy1aeduREnJjuVXWhQ+l1J03ot/viOaU/MDPAaJguIMzKsW4mTLrtQAtMmBtCRozYSbomFN321V2gshxv8giGOXs+qhf/qd8Vcayv83ix/lKT0hfBDWOjREtv4qPgfdvXnlSm9R7sSbK81S9pARYUXdZB0wo2TE/a3aNY/0Ub9PWUZAKCw5fVxnmGT0PGjNuE8SbJk1WPagVLdbyJ1mD9GLSdO7mnBvBR5TucHKQdmWI50m8bNnhOM/XR5vSeusONU+vN010OKSR/hoHw51IGudwdufOZRcwjAIe+IJ7OtnhOeILgviF2mgYmV/d6PNMEPG4FEZcS2Z7XhCWDKTwNYia9FSRlrbyJ6MG9+y+KfeXTyLiE9Sf5jJ2/EzHzxpgCgcyVeyNH/OLWH1TfQDkTXQRw39e/xKPph1waPy0+XEt3wiPEATRqGpyoTbEi5x/8YRZrzgqI2cYW0rdRM4VTqUXbn+5C6yJvKiQIGNWsdWRL23V9/L903SnDBLC7JG9eHJf9pnRysf6+/fRa1p5siSgq7aQ5/a1ztFHjHnTuxTWq8HRoTe/yKrDIwa1rCK4Ty/HnlAGIx+rXNMjRsCI1yzi3D33Y7/Fkc2n9zvwFvtc2/IELDMoiU+yfwF1DmPw1fSv51HPF9sTwm3j8/FcojbW0VsgNdKJpuHQx8UHXxkJgEGpHELKD5I8nGUYw7QPovQ VqS14DN8 frtGuiCH4IAGuCJXrle0FYeOEKw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The fix for this particular file looks good, but some other architectures still use page->flags to test/set PG_arch_1 aliases: ./arch/arc/include/asm/cacheflush.h:#define PG_dc_clean PG_arch_1 ./arch/arm/include/asm/cacheflush.h:#define PG_dcache_clean PG_arch_1 ./arch/arm64/include/asm/cacheflush.h:#define PG_dcache_clean PG_arch_1 (in arch): grep -rI . -e 'page->flags' ./s390/include/asm/hugetlb.h: clear_bit(PG_arch_1, &page->flags); ./s390/kernel/uv.c: clear_bit(PG_arch_1, &page->flags); ./s390/kernel/uv.c: clear_bit(PG_arch_1, &page->flags); ./s390/kernel/uv.c: set_bit(PG_arch_1, &page->flags); ./s390/kernel/uv.c: if (!test_bit(PG_arch_1, &page->flags)) ./s390/kernel/uv.c: clear_bit(PG_arch_1, &page->flags); ./s390/kernel/uv.c: clear_bit(PG_arch_1, &page->flags); ./s390/mm/gmap.c: set_bit(PG_arch_1, &page->flags); ./s390/mm/hugetlbpage.c: if (!test_and_set_bit(PG_arch_1, &page->flags)) ./sh/include/asm/hugetlb.h: clear_bit(PG_dcache_clean, &page->flags); ./sh/mm/cache-sh4.c: test_bit(PG_dcache_clean, &page->flags) && ... (not an exhaustive list) ... But at least for xtensa, this LGTM. Reviewed-by: Svetly Todorov Svetly