From: Svetly Todorov <svetly.todorov@memverge.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 02/10] xtensa: Remove uses of PG_arch_1 on individual pages
Date: Thu, 28 Mar 2024 12:36:30 -0700 [thread overview]
Message-ID: <7cdfb64c-c751-4a59-93fd-4bfa625c43ac@memverge.com> (raw)
In-Reply-To: <20240326171045.410737-3-willy@infradead.org>
The fix for this particular file looks good,
but some other architectures still use page->flags
to test/set PG_arch_1 aliases:
./arch/arc/include/asm/cacheflush.h:#define PG_dc_clean PG_arch_1
./arch/arm/include/asm/cacheflush.h:#define PG_dcache_clean PG_arch_1
./arch/arm64/include/asm/cacheflush.h:#define PG_dcache_clean PG_arch_1
(in arch): grep -rI . -e 'page->flags'
./s390/include/asm/hugetlb.h: clear_bit(PG_arch_1, &page->flags);
./s390/kernel/uv.c: clear_bit(PG_arch_1, &page->flags);
./s390/kernel/uv.c: clear_bit(PG_arch_1, &page->flags);
./s390/kernel/uv.c: set_bit(PG_arch_1, &page->flags);
./s390/kernel/uv.c: if (!test_bit(PG_arch_1, &page->flags))
./s390/kernel/uv.c: clear_bit(PG_arch_1, &page->flags);
./s390/kernel/uv.c: clear_bit(PG_arch_1, &page->flags);
./s390/mm/gmap.c: set_bit(PG_arch_1, &page->flags);
./s390/mm/hugetlbpage.c: if (!test_and_set_bit(PG_arch_1, &page->flags))
./sh/include/asm/hugetlb.h: clear_bit(PG_dcache_clean, &page->flags);
./sh/mm/cache-sh4.c: test_bit(PG_dcache_clean, &page->flags) &&
... (not an exhaustive list) ...
But at least for xtensa, this LGTM.
Reviewed-by: Svetly Todorov <svetly.todorov@memverge.com>
Svetly
next prev parent reply other threads:[~2024-03-28 19:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 17:10 [PATCH 00/10] Various page->flags cleanups Matthew Wilcox (Oracle)
2024-03-26 17:10 ` [PATCH 01/10] sh: Remove use of PG_arch_1 on individual pages Matthew Wilcox (Oracle)
2024-03-27 18:45 ` kernel test robot
2024-03-27 18:49 ` Matthew Wilcox
2024-03-26 17:10 ` [PATCH 02/10] xtensa: Remove uses " Matthew Wilcox (Oracle)
2024-03-28 19:36 ` Svetly Todorov [this message]
2024-03-28 19:40 ` Matthew Wilcox
2024-03-26 17:10 ` [PATCH 03/10] mm: Make page_ext_get() take a const argument Matthew Wilcox (Oracle)
2024-03-26 17:10 ` [PATCH 04/10] mm: Make folio_test_idle and folio_test_young " Matthew Wilcox (Oracle)
2024-03-26 17:10 ` [PATCH 05/10] mm: Make is_free_buddy_page() " Matthew Wilcox (Oracle)
2024-03-26 17:10 ` [PATCH 06/10] mm: Make page_mapped() " Matthew Wilcox (Oracle)
2024-03-26 17:10 ` [PATCH 07/10] mm: Convert arch_clear_hugepage_flags to take a folio Matthew Wilcox (Oracle)
2024-03-27 13:02 ` Ryan Roberts
2024-03-27 14:37 ` Matthew Wilcox
2024-03-27 15:48 ` kernel test robot
2024-03-27 17:01 ` kernel test robot
2024-03-26 17:10 ` [PATCH 08/10] slub: Remove use of page->flags Matthew Wilcox (Oracle)
2024-04-04 18:29 ` David Hildenbrand
2024-03-26 17:10 ` [PATCH 09/10] Remove references to page->flags in documentation Matthew Wilcox (Oracle)
2024-03-26 17:10 ` [PATCH 10/10] proc: Rewrite stable_page_flags() Matthew Wilcox (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cdfb64c-c751-4a59-93fd-4bfa625c43ac@memverge.com \
--to=svetly.todorov@memverge.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox