From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7FC1C433F5 for ; Mon, 18 Oct 2021 06:52:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8CB5A60E97 for ; Mon, 18 Oct 2021 06:52:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8CB5A60E97 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 221D06B006C; Mon, 18 Oct 2021 02:52:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D2196B0071; Mon, 18 Oct 2021 02:52:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C0C8900002; Mon, 18 Oct 2021 02:52:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id EE7BB6B006C for ; Mon, 18 Oct 2021 02:52:18 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A6BEF2BC35 for ; Mon, 18 Oct 2021 06:52:18 +0000 (UTC) X-FDA: 78708639156.29.D416598 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf30.hostedemail.com (Postfix) with ESMTP id BBEDCE0016B0 for ; Mon, 18 Oct 2021 06:52:14 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 79547106F; Sun, 17 Oct 2021 23:52:17 -0700 (PDT) Received: from [10.163.74.6] (unknown [10.163.74.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8AB0D3F70D; Sun, 17 Oct 2021 23:52:15 -0700 (PDT) Subject: Re: [PATCH 2/2] mm/memory_failure: constify static mm_walk_ops To: Rikard Falkeborn , SeongJae Park , Andrew Morton , Naoya Horiguchi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20211014075042.17174-1-rikard.falkeborn@gmail.com> <20211014075042.17174-3-rikard.falkeborn@gmail.com> From: Anshuman Khandual Message-ID: <7cd5c685-834f-46ce-969d-7dfc2d1368a8@arm.com> Date: Mon, 18 Oct 2021 12:22:14 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20211014075042.17174-3-rikard.falkeborn@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BBEDCE0016B0 X-Stat-Signature: gwx1trkuaendu6qxdogd4859q44ejs3q Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Rspamd-Server: rspam02 X-HE-Tag: 1634539934-518995 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/14/21 1:20 PM, Rikard Falkeborn wrote: > The only usage of hwp_walk_ops is to pass its address to > walk_page_range() which takes a pointer to const mm_walk_ops as > argument. Make it const to allow the compiler to put it in read-only > memory. > > Signed-off-by: Rikard Falkeborn > --- > mm/memory-failure.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 92eeb317adf4..8d5faf347ed1 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -674,7 +674,7 @@ static int hwpoison_hugetlb_range(pte_t *ptep, unsigned long hmask, > #define hwpoison_hugetlb_range NULL > #endif > > -static struct mm_walk_ops hwp_walk_ops = { > +static const struct mm_walk_ops hwp_walk_ops = { > .pmd_entry = hwpoison_pte_range, > .hugetlb_entry = hwpoison_hugetlb_range, > }; > Reviewed-by: Anshuman Khandual