From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1AD4C4167B for ; Wed, 29 Nov 2023 22:19:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 634646B03F8; Wed, 29 Nov 2023 17:19:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E50C6B03F9; Wed, 29 Nov 2023 17:19:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AC896B03FA; Wed, 29 Nov 2023 17:19:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 390226B03F8 for ; Wed, 29 Nov 2023 17:19:59 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1E4571A065F for ; Wed, 29 Nov 2023 22:19:59 +0000 (UTC) X-FDA: 81512410518.02.0306EFC Received: from mx.manguebit.com (mx.manguebit.com [167.235.159.17]) by imf10.hostedemail.com (Postfix) with ESMTP id 3475FC0003 for ; Wed, 29 Nov 2023 22:19:55 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=manguebit.com header.s=dkim header.b=qygnQJKX; arc=pass ("manguebit.com:s=dkim:i=1"); dmarc=pass (policy=quarantine) header.from=manguebit.com; spf=pass (imf10.hostedemail.com: domain of pc@manguebit.com designates 167.235.159.17 as permitted sender) smtp.mailfrom=pc@manguebit.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1701296396; a=rsa-sha256; cv=pass; b=uqHL3DjkfOr9j14NzzUKYkcX9S8IALCCVJH5INJR+qFp6h41cWJm1ko3h6nIe4mezWkeWP pcwPixjV1cBAnlce1e5dTsosUzxkT+D89m+a1uB6dG5k53sEm6AaIMeaITGyEbubjx/4r8 0dqtt4oN2FqfME3NcC0xyPbb+BvaCgE= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=manguebit.com header.s=dkim header.b=qygnQJKX; arc=pass ("manguebit.com:s=dkim:i=1"); dmarc=pass (policy=quarantine) header.from=manguebit.com; spf=pass (imf10.hostedemail.com: domain of pc@manguebit.com designates 167.235.159.17 as permitted sender) smtp.mailfrom=pc@manguebit.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701296396; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zTq2o1qJW8tbvbraXclVNrWBgCIFYure9jsTVRDRcDo=; b=1EdJzEDu1TOe8G8ZyaPvwlxY7XX3vnOA0w1O6BintaitEFn6txJmoi+P9u6uZ6hQxyVeWb W0jTY0SR+q2FOTfSYQNiz572X6tbgkhgJa2eOKgB+ewcm+M8i/OywZ9mBWR57MZiiGdEFJ /t0zJo096kraIPp4z6l4WGLJ6w/2yOs= Message-ID: <7ccf5315d932b5a628d952af6e8c1460@manguebit.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manguebit.com; s=dkim; t=1701296393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zTq2o1qJW8tbvbraXclVNrWBgCIFYure9jsTVRDRcDo=; b=qygnQJKXqycrwPfZX91uR9Q6V/Ivfas22DnJzN2ItfbHx5xxCJ5a0iWB7lQeXA+Dl/A2lJ Gj8KtlF0dgOej/nHI65XhRqvPTe8EDgXX8ewzPgT4MBliIRVThyFs4zyurPtBqvUTwLDRu m6RB9DtXed0Ssm4lVQz6soOdKs0GpdlTKYGugkqc19Grj0iJP8JRdtc/MQVRvwlw39ZXfO dSV3D//ioJT3i42zKUp8ZseHyo0g+ajFaBpe3beKsrMj3BRp1QpXbRqmwPkvq5k7FQmxvC PonQ/W6O6W50VlOn+0uodf8sbOA3HILLiJddtoz2YqFAqgAVEbiM3xz6TtbxoQ== ARC-Seal: i=1; s=dkim; d=manguebit.com; t=1701296393; a=rsa-sha256; cv=none; b=qoN1/zv1ZjR6Oq+WpjypKc6Bywff/JRtgCKyoXpoq6grWDMI94EnLZwYPTt1AyK6C9oBZN ei794EyexFOk79ynA7HH0ySRsGhpL5LjxxP9N9VIfAofw9faQUOmdvT//Pchmd1rvIPFQm D33tSbzQHZSUVYPi2IMbQuKuGNXS5yRbGNEzjjrs3kJgDo2j9CkQVcYDccJG/77eOkjF8c 02ATCf3M8MQ1rk/r7MpJpcDTJcLS9gYklHgzEfVJ6LqAjfrRwaxVt8qAIF92W0A9XgmUUK uEic364znqXhynIhTi2j6o9L6ywFzXyOlptSsA8tAVoi/4ZW6uR67y7sSh1Ovw== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=pc@manguebit.com smtp.mailfrom=pc@manguebit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=manguebit.com; s=dkim; t=1701296393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zTq2o1qJW8tbvbraXclVNrWBgCIFYure9jsTVRDRcDo=; b=TWEQeMx1iL6K/3Ht6TjjtG3hIRLhcU7WtrajdKctWxK4EtKcNNgTfWuQQRBCwgFMKWxLNx EkcjiHUBdq+pPfcdAX/+fJy8jF+aovg/LBaKPn0UzFPEysx5/E4FL0CDOwrmuNTLewzALo V4ceKGNI3Xgsut4S/xJTYGZig0ckCF8e1mh6+YaU8xP/x0SQRjoayfOeUIyGT9kzUKn479 hBF7jDOLQVzak2kqVBOkh592mZMUQnA8mAkPXy9D3pFQJLHdByiKoOAmXJ2PzqY7h8PkSX 0pFsdJ9PuLb+44nBf/9DUN0RhZaLdo+bL/fE0owcw55AkmHCyjHMTE/flxNDmA== From: Paulo Alcantara To: David Howells , Steve French Cc: David Howells , Shyam Prasad N , Rohith Surabattula , Matthew Wilcox , Jeff Layton , linux-cifs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/3] cifs: Fix FALLOC_FL_ZERO_RANGE by setting i_size if EOF moved In-Reply-To: <20231129165619.2339490-2-dhowells@redhat.com> References: <20231129165619.2339490-1-dhowells@redhat.com> <20231129165619.2339490-2-dhowells@redhat.com> Date: Wed, 29 Nov 2023 19:19:49 -0300 MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3475FC0003 X-Stat-Signature: 7g3dmw5gh48sjimfjwy837443ijwouxa X-HE-Tag: 1701296395-257011 X-HE-Meta: U2FsdGVkX1+57G4f+zRNqrwdlvZ+zY+nBpICgXDq0jJyY6NY7PukCWj4nTDafQjeXQsm0mzsA69BGzs/ZbC5H3dcey9m5gmHtRHaLX4hoiop4BQiKP06lpV6t2Q366HZDYD+8V1E4O0uhM1NG46Bcbx8RH0wj7wu8fYkk95iQeIUMUmn0VXiASIwRBNxEbohde4mV4HaEm+1jSMQgA5d9tCVNa5LBSxvDdNvl2/BvzJhNwWBYr6pcgD/8HanhmU/K1IvrjFcXOlWxTOm48EXFA6fLtDvC7W6PCvSx5/E0x5MF0jmQXCqIu+1bqr775jWeXIFYu649rVsDvgIPjZHpLOke2ySamRMIFztBbjYkmHuLISAL3xicy0Y0MMLXv/q0FIMTFLtb94iF0ouLAPNJWqJB6PtoFyw9KgvwecBnAqhP4b9eJQYxUy3SjrPRpnE//iXnYIk7XqeBN2po5acvYnS9ypoEUX3jFER81KZVbUI7OoGuaxF8tjCbMFLw5HqZ6beKuQDwWuqtpZR2XQwcvMKx9KLCBkIj0lhc9bbLnndcvRpYfhIzNyfC8JoqWdrRbAXBZt3nd+z+eOOAik1HpFVGnMHg7SOqVAr/Nvbf6SWHDe/NcXLv87K4cAMluy7Wopn/hWiqMMgHmcGbuCt3Uqru6FEKJBRzYjzIbSgKdlY3AL0lBp/YRY2o7Q+VeWdoySjIr4vWfD4KduV3kPiIDO1RodQuP0WmkNu9hArPx+RwPBk8J5attfZ2h+/S9s+4s1lYchD5l7gWiV6i6s/aJYdIPRXAcOn9qe6mMp8/Dw30G9t+x1UXuC27GVCEPkCZbOIr2j8hMZWMWt+/Lwjo5fqMc8UdvXigVxTcbsBP1Pn9pQHgtkTdTlzTZfFdN0SlAlLkNnbQkG0115IIsyp+kNc0XFnsBjMCMJVdVChfMcy2g4p3W/pX7iaHN5Bb+7X/Z+cpr//OPz6nP2DR6L CxL2uEXf 6uwnACGlyCglHmS/dS7ePGS2e9lOZQJ4sO8BF4VGup/xy7trwK5wPJ8Z6Gr1Ijd5rLqQWLuj8fvmykQOf8Sv7c5RpHbXQ5TRvUbyQRFEyEpePvJ8bMYHmLsXXd5lKgKQZYA1b1XRKCUyZzlTKQK2eOTDpCILfCYI6BrDXkPTuKzWbrMaNb3A6mNT+nNN0xUa5rZaJQSfUT6w4qWmoKZhGgUJ4/dA979dKQJtDsfpHtonba1sSi7Sx8gBO8PbeGtIbjgsk0C4dj7JDB8E7AIcFsrN8cssdhSUc2JzO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Howells writes: > @@ -3307,6 +3307,7 @@ static long smb3_zero_range(struct file *file, struct cifs_tcon *tcon, > struct inode *inode = file_inode(file); > struct cifsInodeInfo *cifsi = CIFS_I(inode); > struct cifsFileInfo *cfile = file->private_data; > + unsigned long long new_size; > long rc; > unsigned int xid; > __le64 eof; > @@ -3337,10 +3338,15 @@ static long smb3_zero_range(struct file *file, struct cifs_tcon *tcon, > /* > * do we also need to change the size of the file? > */ Perhaps remove the comment above as we're now updating the inode size? > - if (keep_size == false && i_size_read(inode) < offset + len) { > - eof = cpu_to_le64(offset + len); > + new_size = offset + len; > + if (keep_size == false && (unsigned long long)i_size_read(inode) < new_size) { > + eof = cpu_to_le64(new_size); > rc = SMB2_set_eof(xid, tcon, cfile->fid.persistent_fid, > cfile->fid.volatile_fid, cfile->pid, &eof); > + if (rc >= 0) { > + truncate_setsize(inode, new_size); > + fscache_resize_cookie(cifs_inode_cookie(inode), new_size); > + } > } > > zero_range_exit: Looks good, Acked-by: Paulo Alcantara (SUSE)