From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BD71D68B19 for ; Thu, 14 Nov 2024 13:48:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 241196B0085; Thu, 14 Nov 2024 08:48:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CA636B0089; Thu, 14 Nov 2024 08:48:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0436A6B008A; Thu, 14 Nov 2024 08:48:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D5E4C6B0085 for ; Thu, 14 Nov 2024 08:48:04 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 95980161147 for ; Thu, 14 Nov 2024 13:48:04 +0000 (UTC) X-FDA: 82784827608.25.BFAA58E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf18.hostedemail.com (Postfix) with ESMTP id 989521C000E for ; Thu, 14 Nov 2024 13:47:42 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gbU7YX0a; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="qwKLoy/i"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gbU7YX0a; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="qwKLoy/i"; spf=pass (imf18.hostedemail.com: domain of hare@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731591938; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DUjIzgo1/q6wmPt3j3IRmdHoMb98/6oVGe67aiYYv/I=; b=fOsVPUkLeg5Y1t1Nq3N9J8dTsIX9zHxfFFPbJsD7w7T86Zwlc0Kq6g648KT6jTniv0gR7L DbwKFi7QEPVp/J/1K7TljLWqhaMNvE/DOLYrEoXDIja9mobrGnRbXoWYp67IMBslzgfVhx 8bqoKwURawSs+SGPyHJ0h1YoYGvrgzc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731591938; a=rsa-sha256; cv=none; b=LCwXeNnF/nhoyZW9yNVHNmwgf3B3671tW1awfGEMMJvjCXWySMwm6MXZr0xezIXs+qo/bU QXE8rMwl6Svg2fETJzZ6p0lhuzVDvvyv1Sb6OT67naty6UrxcQJNFnrwL6xatG1hJqqfwS nOZH+YzDGJzIwthT6PU7k5hGp7Dz0So= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gbU7YX0a; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="qwKLoy/i"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=gbU7YX0a; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="qwKLoy/i"; spf=pass (imf18.hostedemail.com: domain of hare@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6C1C41F395; Thu, 14 Nov 2024 13:48:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1731592080; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DUjIzgo1/q6wmPt3j3IRmdHoMb98/6oVGe67aiYYv/I=; b=gbU7YX0aK2DMwfWKyI22wCpxlAylAYGuTj34yv87OtWi0JQa5xVU4nagYes3DJtflsYwhm t0rxqEkk4fqZS7erDiOpXHQvt+5NcYJbJuKmSjG3xwVfD9PCyxjPz/MIRQE6jD9CU4Z/le 051p6wEuWrSI5kZo8LAbUa6kUOOFyF8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1731592080; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DUjIzgo1/q6wmPt3j3IRmdHoMb98/6oVGe67aiYYv/I=; b=qwKLoy/iki4X6i7WkAROAZFROb4gIdq0hloTOI6CBRu4QQYOz5Lc6DJz8lYL/4/35wFhHX yuTdmpUbPyrQrXBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1731592080; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DUjIzgo1/q6wmPt3j3IRmdHoMb98/6oVGe67aiYYv/I=; b=gbU7YX0aK2DMwfWKyI22wCpxlAylAYGuTj34yv87OtWi0JQa5xVU4nagYes3DJtflsYwhm t0rxqEkk4fqZS7erDiOpXHQvt+5NcYJbJuKmSjG3xwVfD9PCyxjPz/MIRQE6jD9CU4Z/le 051p6wEuWrSI5kZo8LAbUa6kUOOFyF8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1731592080; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DUjIzgo1/q6wmPt3j3IRmdHoMb98/6oVGe67aiYYv/I=; b=qwKLoy/iki4X6i7WkAROAZFROb4gIdq0hloTOI6CBRu4QQYOz5Lc6DJz8lYL/4/35wFhHX yuTdmpUbPyrQrXBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 358B013794; Thu, 14 Nov 2024 13:48:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id R/KdDJD/NWe7ZQAAD6G6ig (envelope-from ); Thu, 14 Nov 2024 13:48:00 +0000 Message-ID: <7ccc2ab3-4f04-4c4f-abc5-cb3d7a393031@suse.de> Date: Thu, 14 Nov 2024 14:47:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 2/8] fs/mpage: avoid negative shift for large blocksize To: Matthew Wilcox , Luis Chamberlain Cc: hch@lst.de, david@fromorbit.com, djwong@kernel.org, john.g.garry@oracle.com, ritesh.list@gmail.com, kbusch@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com, Hannes Reinecke References: <20241113094727.1497722-1-mcgrof@kernel.org> <20241113094727.1497722-3-mcgrof@kernel.org> Content-Language: en-US From: Hannes Reinecke In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 989521C000E X-Stat-Signature: m4176j5t4parqkgn9hpiaew8jkiwfsj5 X-HE-Tag: 1731592062-287333 X-HE-Meta: U2FsdGVkX1/fW0PnB9cwdn68capWp2WqG4VAHPwLROC324H99lM0zWoichQMO+t4jLagKcN99omQAvCwdiZnHLgkg7PFwOBfHg5THQ+bK4PANca8nsxtAJDVVrx2gHD9m8BhTOY7J8sKhNPXslc21+NwlVEde8YrCzbwF9/Sm4MdcfrMtxfDtA7kXVBZKPZywY85CC4KjpjqiTpvETWhd/Q1bzem5N4p4Kyc1f40bgvgcsp3Sssp/bdDooo52Eg4bkeYXo9jOohfr5xK8btC2P82gC7qY0ZttrgzeqnHAMkoOntKWETqnIy1FL2OxCY/PARw59WdZNNKaO2n75YkIQy5eWi95f0hMPDMy/NAyeU/0EF+heOcPxffWBkHJwnssNy0a0YyiqbEtKOGO3fL/aOrduHAY68eXpqnSIgI94VvbTfCtPE3vVHtgTM1GwrhB37G/ILW5huh6YCk3i5xFU9HhNgmt8D7A+6cZ0pg6ZRBhfRd0SgmBqfH6n1408+H9+NalXP8vZHltYeS8FVHH3DOwi9yICYn6woTtzNki6xmOgyURL78ROg8Z11LWT5wYZXBAMGBo+FMVbB/ZplqVrMb2KQCY8CzP9MEjH/flU9KE+e96f0eNtM0EfFfhuAQanuFIZPs8Bwq9bmAfRMzjYnfHAbSsFHbrs7X3/aa9HZufyvPNP1yzjjCWeTZe4bfKiHe4nfa6KJAh9+u9hSLKKt+AheRbLqxQaJ8qJnXlJEXcjx3vuC9mKzV4W0imbEkbZq7pgWzfIIlDZlpAH99329Quct+K4cTaRb7aMvfQncyXHZDfKpXiqqVWzjTHnjZrjuAC2XW1Gycb7IrGK73x3oahrGg7GCdu7uL+ATeIHPjwW6ME2NcrYwSzT+KxhmUjhuraoItx9+yTl+FXFUFnOceAdveaqpWgvldN7Hf/jPVPcgrDLtj7+cRquFkJO4//HVMcIWR8rW6Y4IsBWl oiJmQwj4 J0rqN9/LotuqDfvImZCcZq7kkFV99AzFlCqk1jP+7Bw0iLMqTNZyNcYm7d0n8oq8gwdSOUKMVef4d2ffgN7qQf2PDoLStgDzEaCZfZbHuOvvfu4SxXhRw5d7JV6G7dtI+qkex0R9OtTxQv4y3jYPKD2sIZHNJu3avk9RpxlLoSP8AGS3bdMrtyugNLdvUvRZX45B/ebZtFQZd6MogHeZmw3KPsmR9+4VkXcqz552bW8tPwBdB2F8SdCRZ77/otAOHFsjGuDeX1NQCSrEJnGlfesWa02eGK8KEHBol1c4ENQuWv0CozC8P0P7ZCIYCL/MTdDtVZTrz6NGkvj1IJTnO8I0VZa4SLW02S9jJqxATjsdFlztKk7Ywg7eJT0R2NKY+rMvhSVXlBGWIyRnTfIqjNCBYNg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/13/24 15:06, Matthew Wilcox wrote: > On Wed, Nov 13, 2024 at 01:47:21AM -0800, Luis Chamberlain wrote: >> +++ b/fs/mpage.c >> @@ -181,7 +181,7 @@ static struct bio *do_mpage_readpage(struct mpage_readpage_args *args) >> if (folio_buffers(folio)) >> goto confused; >> >> - block_in_file = (sector_t)folio->index << (PAGE_SHIFT - blkbits); >> + block_in_file = (sector_t)(((loff_t)folio->index << PAGE_SHIFT) >> blkbits); > > block_in_file = folio_pos(folio) >> blkbits; > ? > >> @@ -527,7 +527,7 @@ static int __mpage_writepage(struct folio *folio, struct writeback_control *wbc, >> * The page has no buffers: map it to disk >> */ >> BUG_ON(!folio_test_uptodate(folio)); >> - block_in_file = (sector_t)folio->index << (PAGE_SHIFT - blkbits); >> + block_in_file = (sector_t)(((loff_t)folio->index << PAGE_SHIFT) >> blkbits); > > Likewise. Yeah. /me not being able to find proper macros ... Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich