From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88D6EC021AA for ; Thu, 20 Feb 2025 01:16:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07972280280; Wed, 19 Feb 2025 20:16:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 028BA28027D; Wed, 19 Feb 2025 20:16:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5A1F280280; Wed, 19 Feb 2025 20:16:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C8CF828027D for ; Wed, 19 Feb 2025 20:16:54 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 48993C064A for ; Thu, 20 Feb 2025 01:16:54 +0000 (UTC) X-FDA: 83138558748.23.091C483 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf14.hostedemail.com (Postfix) with ESMTP id 5762810000B for ; Thu, 20 Feb 2025 01:16:50 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740014212; a=rsa-sha256; cv=none; b=Zb4Xf4e5Rgua9exdsW0xyDISSmgh7WouKJeOsnlkOh082rku+l2KQsbvKFs2GBhruL6nsP 3c+cV6FM4hY1vsuNe8L48x9Hl7N3xJmudpcNCVtmZlyqZgpFoaazLRtCVClRkL/RBpsTeg /luCsXoq45wctkSAgHmo9s5hi6FPoeQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740014212; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dN1us0wEd/Oah5Qg2m4zJI9yOI1c8/llqoElDuKRf+k=; b=F4+xPYjMH7DPWr8eodJRwk3CZcWs44PfwyBdw8DtsKvCBPSSV6QGQqy6XuCEkeS5RMsNvU eyUtXx7QqxvM1hu3sWGqfI0pcWzxADAwQUV3gFjlvElTonsAJ6JVgyMPeqaZv1nqXcNwGc v29GcPKzhif9oLNT28rtOxDIjc461Ow= Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4YywJ95WGvzHr9Z; Thu, 20 Feb 2025 09:13:45 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id 062FF140203; Thu, 20 Feb 2025 09:16:47 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 20 Feb 2025 09:16:45 +0800 Subject: Re: [PATCH v2 4/5] mm/hwpoison: Fix incorrect "not recovered" report for recovered clean pages To: "Luck, Tony" , Shuai Xue CC: "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "akpm@linux-foundation.org" , "peterz@infradead.org" , "jpoimboe@kernel.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "baolin.wang@linux.alibaba.com" , "tianruidong@linux.alibaba.com" , "bp@alien8.de" , "nao.horiguchi@gmail.com" References: <20250217063335.22257-1-xueshuai@linux.alibaba.com> <20250217063335.22257-5-xueshuai@linux.alibaba.com> From: Miaohe Lin Message-ID: <7cb06f0b-dd90-506e-64f6-d3bbcae8c95f@huawei.com> Date: Thu, 20 Feb 2025 09:16:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemd200019.china.huawei.com (7.221.188.193) X-Rspamd-Queue-Id: 5762810000B X-Stat-Signature: shccsgaqrxrgg838ehe7t6p97o9mcfpf X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740014210-251260 X-HE-Meta: U2FsdGVkX19vIfk/dAtEfzP8qbq5tKbgruHJMrdW2uoKaMFRHu7ioATYlitOeIrR1CWIrUCCB/VlC8hdx84u+T2GTtLl6taf57zxkYqT9r399ZExzexVkIpIpi47IBQbvPh41TSggnur2orGcgbv8zFQJqGzX1Fz20RRDgBuFIdb4ZReGUWM635JbKC1faJMYyx5wUPwWXatLRqvSvzD3uRQO5zU/L+fhKVLCRbNmE2Vm5bHsXB1PLPLjGJB4VLUfTTImo+47eWBWM257Cg/Dz51fxe7OwdEhgHeTnX9Sc44mFfqTYdhJMxhZgSqnIJn6wsxrzXdFYJvK68wIqbUC5p6J/L3pvzt0BrvkNVGOG6X1jeVEw5wvExOXiLQP8ABGw7zVq3iTXFFCHGSGJy2whVJiPSSr3KmKonoWfuUWLT2bBpGNX2GESFZbxg/9qMLIOmu/KR8DDL7ZE+XfoiVv02KCgm4BXnWGU/aYuaTguwWuMfy/9VW+OHi8U3M9hNrWN4zHMJzPgXOoGbMuRV6YaHdrY7Kf/01Rcq5qp9ZXwC8RrUuHyeBWlViLhVIBUNIytHLc8IA3sS4Cpmyn2iev+mBduK9/WuqJ0k7nWuIpy2RBQVuakiNAlmg+m+sxI0DzuSFSxOFLbUSfUjNVvbX3FjXIIoWHE9Uz9OGvTI2v9IrAYXDACvicPJAvgQF8jZKGLjDCHolmmPOdOFvwWheASaXRlWooBRAkdP8HO38pXh/eeVixy5HjNyc3MjzBA6wsLcK7SVtJ7WPal56eKSP0KH8MnWECtGiIWWFmvlInq9L5tzkXlGSqE8QqWjsGaIioOXaCdUwcuVP57wtJRIP79+CDyY7RED3U8ThhXfMIZkYT9PJtvmBfK49nI5bfwIW3G/eBBHfYh0c88/LXx0lNo0wEVAsH6dHxvKr/AOfVteT/G8ZlR6F4J0oObR5U3OG4nNn/nIunOkEhCbaX7e Z292K6NL u1ZHSbduF6ElSzw2sz4ifXRrdToX/azssx0l3FE9XnXYVU//5Tlb68WQSuhqNfZDVTXOQI0QZi4H23vC+pxDjVXfcfsDk11ceQAF9OQ2KkaTVqlaVkBJf6N5tWqVqfMEIZ78IhJnLWNoBW6cN6GJjWDLDIfpN4DgeA7ro15aqQppj5xgNnZH9555tGgkK8qJ8Wy9Lcdj01Q2QEfUHA91KbXaVDlyYN9JjQV1/1sFsEpmn5fhhjlJJ073fqEb5eH1fzpdV/tobLTmFxnLnDa7ASOgUKyrpzhJytq+K X-Bogosity: Ham, tests=bogofilter, spamicity=0.000054, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/2/20 1:15, Luck, Tony wrote: >>> The caller kill_me_maybe will do set_mce_nospec + sync_core again. >>> >>> static void kill_me_maybe(struct callback_head *cb) >>> { >>> struct task_struct *p = container_of(cb, struct task_struct, mce_kill_me); >>> int flags = MF_ACTION_REQUIRED; >>> ... >>> ret = memory_failure(pfn, flags); >>> if (!ret) { >>> set_mce_nospec(pfn); >>> sync_core(); >>> return; >>> } >>> >>> Is this expected? >>> >> >> the second set_mce_nospec do nothing and have no side affect. >> >> sync_core() is introduced by Tony [1]: >> >> Also moved sync_core(). The comments for this function say that it should >> only be called when instructions have been changed/re-mapped. Recovery for >> an instruction fetch may change the physical address. But that doesn't happen >> until the scheduled work runs (which could be on another CPU). >> >> [1]https://lore.kernel.org/all/20200824221237.5397-1-tony.luck@intel.com/T/#u >> >> IMHO, I think it also has no side affect. >> >> @Tony, could you help to confirm this? > > Correct. Re-runing these calls is harmless. Got it. Thanks both. > > -Tony >