From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D067C433DB for ; Tue, 9 Feb 2021 17:37:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D6B5D64E9C for ; Tue, 9 Feb 2021 17:37:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6B5D64E9C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 03AA06B006E; Tue, 9 Feb 2021 12:37:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F2CEF6B0070; Tue, 9 Feb 2021 12:37:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF2C26B0071; Tue, 9 Feb 2021 12:37:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id AD6266B006E for ; Tue, 9 Feb 2021 12:37:00 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E62734DDB for ; Tue, 9 Feb 2021 17:36:58 +0000 (UTC) X-FDA: 77799434916.03.year69_440dbc127609 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id D065328D5F9 for ; Tue, 9 Feb 2021 17:36:13 +0000 (UTC) X-HE-Tag: year69_440dbc127609 X-Filterd-Recvd-Size: 2994 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Feb 2021 17:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=Xo7XyHvMTDXEt/s7IZOh7pRGS7mOTP+ADw1RfpB6oT0=; b=QosAN4Q/U1UNUh0klToH9fA++S 2zFN0hY1m6qduLhCkbUgOhTD4p16f6mrlZaynaMaCnIz9wW+NKqSVnjMOd9toGdhxXS7f1b67KoHb AouSTnnSCYyBcXrddZ7y+OtauCOriMcR5Tlf9KXIb8GB11te50RJOWkvpLZKa8vXI4sTydZJy7Sw7 s5wbcbeUvXsG0VZS8WD3Qwi3UqF134CKXphxA9ejTmf5Do5XCktBKe2rnskihKBlB3e53DRWe77uF OuBy0NKdTD3P5RvN0Rz6spI6e90Qiagwxh5TMSWXCYLfkHCin7IdCDaEQ3lalMrYUkvNDbadBdlK7 M7shtH+w==; Received: from [2601:1c0:6280:3f0::cf3b] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9Wvl-0008DO-HE; Tue, 09 Feb 2021 17:36:05 +0000 Subject: Re: [PATCH v2] mm: cma: Print region name on failure To: Georgi Djakov , akpm@linux-foundation.org, linux-mm@kvack.org Cc: pdaly@codeaurora.org, linux-kernel@vger.kernel.org References: <20210209142414.12768-1-georgi.djakov@linaro.org> From: Randy Dunlap Message-ID: <7caf3642-4283-4288-45c1-fcbd17d8c84b@infradead.org> Date: Tue, 9 Feb 2021 09:36:00 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210209142414.12768-1-georgi.djakov@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/9/21 6:24 AM, Georgi Djakov wrote: > From: Patrick Daly > > Print the name of the CMA region for convenience. This is useful > information to have when cma_alloc() fails. > > Signed-off-by: Patrick Daly > Signed-off-by: Georgi Djakov Reviewed-by: Randy Dunlap Thanks. > --- > v2: > * Print the "count" variable, as it was originally in the code. (Randy) > * Fix spelling s/convienience/convenience/ in the commit text (Randy) > > v1: https://lore.kernel.org/r/20210208115200.20286-1-georgi.djakov@linaro.org/ > > mm/cma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/cma.c b/mm/cma.c > index 23d4a97c834a..54eee2119822 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -500,8 +500,8 @@ struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align, > } > > if (ret && !no_warn) { > - pr_err("%s: alloc failed, req-size: %zu pages, ret: %d\n", > - __func__, count, ret); > + pr_err("%s: %s: alloc failed, req-size: %zu pages, ret: %d\n", > + __func__, cma->name, count, ret); > cma_debug_show_areas(cma); > } > > -- ~Randy