From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6AB1C2D0A3 for ; Fri, 6 Nov 2020 21:09:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1CB8B208C7 for ; Fri, 6 Nov 2020 21:09:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="FulphIc/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CB8B208C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 235176B0036; Fri, 6 Nov 2020 16:09:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E6306B005C; Fri, 6 Nov 2020 16:09:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D45D6B005D; Fri, 6 Nov 2020 16:09:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id CE6FE6B0036 for ; Fri, 6 Nov 2020 16:09:34 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 632C6180AD811 for ; Fri, 6 Nov 2020 21:09:34 +0000 (UTC) X-FDA: 77455234668.15.boys02_331112d272d5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 3FE591814B0C7 for ; Fri, 6 Nov 2020 21:09:34 +0000 (UTC) X-HE-Tag: boys02_331112d272d5 X-Filterd-Recvd-Size: 3636 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Nov 2020 21:09:33 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 06 Nov 2020 13:09:30 -0800 Received: from rcampbell-dev.nvidia.com (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 6 Nov 2020 21:09:27 +0000 Subject: Re: [PATCH v3 4/6] mm/thp: add THP allocation helper To: Christoph Hellwig CC: , , , Jerome Glisse , "John Hubbard" , Alistair Popple , "Jason Gunthorpe" , Bharata B Rao , Zi Yan , "Kirill A . Shutemov" , Yang Shi , Ben Skeggs , Shuah Khan , Andrew Morton References: <20201106005147.20113-1-rcampbell@nvidia.com> <20201106005147.20113-5-rcampbell@nvidia.com> <20201106080147.GD31341@lst.de> X-Nvconfidentiality: public From: Ralph Campbell Message-ID: <7cac5437-c5b1-25e2-f98a-c0a6c9af7ac6@nvidia.com> Date: Fri, 6 Nov 2020 13:09:27 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20201106080147.GD31341@lst.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604696970; bh=9yPdLjLMk4VDQyCtkT8t7GZNpDCZAji0utGt1xU6RII=; h=Subject:To:CC:References:X-Nvconfidentiality:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=FulphIc/so5+6aTPESZcFxW8h9OUZ2iyqmutRPbl18GBVLgAyX6fz4lJiev0O1YP6 q/LNpjbRlW3SKWvukveekDhx0gjNTyauAUv90vIV2i9n949F8fptDvzdatTN74Gl7/ f/PC1ihNAUIC/qOVlVty9n9Gv7EjknTWE+2q/GosGmlHMzqzSzMcN6nR1s0OIgCca4 6FVZ7++xm6YWl9ul+2YLkZMvUsD6rl4gbVZX0+FR9xXlYHr9pjH9J0BMXIsVl3xfcX BMkE3aZvmR0guP2wjHWUqdDJJ5GlhtqIrC+NpmZfIIYGBbHGCrNbb22hcdjF6jg8XS Yq5UDWS1nzT6A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/6/20 12:01 AM, Christoph Hellwig wrote: >> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE >> +extern struct page *alloc_transhugepage(struct vm_area_struct *vma, >> + unsigned long addr); > > No need for the extern. And also here: do we actually need the stub, > or can the caller make sure (using IS_ENABLED and similar) that the > compiler knows the code is dead? Same problem as with prep_transhuge_device_private_page(), since alloc_hugepage_direct_gfpmask() and alloc_hugepage_vma() are not EXPORT_SYMBOL_GPL. >> +struct page *alloc_transhugepage(struct vm_area_struct *vma, >> + unsigned long haddr) >> +{ >> + gfp_t gfp; >> + struct page *page; >> + >> + gfp = alloc_hugepage_direct_gfpmask(vma); >> + page = alloc_hugepage_vma(gfp, vma, haddr, HPAGE_PMD_ORDER); >> + if (page) >> + prep_transhuge_page(page); >> + return page; > > I think do_huge_pmd_anonymous_page should be switched to use this > helper as well. Sure, I'll do that for v4.