From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ABDAC432BE for ; Wed, 1 Sep 2021 10:11:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0D71660295 for ; Wed, 1 Sep 2021 10:11:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0D71660295 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 98CC16B006C; Wed, 1 Sep 2021 06:11:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9142F6B0071; Wed, 1 Sep 2021 06:11:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DB356B0072; Wed, 1 Sep 2021 06:11:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6FE336B006C for ; Wed, 1 Sep 2021 06:11:12 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1E1298249980 for ; Wed, 1 Sep 2021 10:11:12 +0000 (UTC) X-FDA: 78538586784.32.4EF0185 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf24.hostedemail.com (Postfix) with ESMTP id A129EB0000A2 for ; Wed, 1 Sep 2021 10:11:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630491070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5Qvu8f0am/SlQm3BBQ8kcFlHtYY52i34qaBeBiT+B1I=; b=Pi9k8rF4TLswhmotvnhtUqI3Dqj5QUIklqYtgohKESQjnbXFMkohkEk39RWrB4hU9q7EiB J7hpbzCuazjc77uIGEAnGUBsXaTW2OkfYwa8b3nYi/BZlpz7W6D6f71XZkNi/FSm3DvgEA 0SABXHj9WrCHVbg/LoD1XQyuBnyjYgg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-585-3Kw0EhKQOKao-tRZeAtwtQ-1; Wed, 01 Sep 2021 06:11:07 -0400 X-MC-Unique: 3Kw0EhKQOKao-tRZeAtwtQ-1 Received: by mail-wm1-f71.google.com with SMTP id u14-20020a7bcb0e0000b0290248831d46e4so833921wmj.6 for ; Wed, 01 Sep 2021 03:11:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=5Qvu8f0am/SlQm3BBQ8kcFlHtYY52i34qaBeBiT+B1I=; b=XLjytSFJw7gzM74qIpooBBuD52kNzTrnT0f5JMT5utwisdevQTgLP/r4fSYLV1o7WM howoFIfbVGVgEqKPzZluDx0JHB2qCJje/C9bqh0D5lKPTFTf415CARYBl9V+OrgrDItV llhnPDMT45bdiZXMuMqtVlHMI4cZExgDM/9bwPd7KocDBPaXTZa+U+uof3R2U6ULwTQ7 JzFu5DH7gRJlxVCwW5JLpFbvktZbKHteJAlbCqCOyaocCoHQwbTiZ38Hc11SBVKyE6vo 2eKyg9BibLXg0m0O/fM2vy3sljN3nE7wpZUb0J9taFjXuCF+3taZZmRy+AfICG0oG5bX 6H5g== X-Gm-Message-State: AOAM532Nw3n1c84PK9zaLn15beQQBU5gjydI+VQDlyUsGFnnvOZMX6NE jx5jfC6kPvy2jixQvXsW6S0y5nhTvHPEnoGHMsgFHyyDar5QGU81ukK2cwmIHhMpZhZPBjWXU0j 1ajqJZVQMSwtxM8vC68Rog6wlgG54FhuYeaF5S2Vw1p4beGC6kZV6SphdeME= X-Received: by 2002:adf:dbd0:: with SMTP id e16mr36434449wrj.402.1630491066782; Wed, 01 Sep 2021 03:11:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoJvOC5ivwrzHTukER5oblEKCEnKLApZDh0Fa4VvnmniV9qnGBK5T9FaXi46sq4fgGHu226Q== X-Received: by 2002:adf:dbd0:: with SMTP id e16mr36434410wrj.402.1630491066497; Wed, 01 Sep 2021 03:11:06 -0700 (PDT) Received: from [192.168.3.132] (p4ff23f71.dip0.t-ipconnect.de. [79.242.63.113]) by smtp.gmail.com with ESMTPSA id u26sm19587498wrd.32.2021.09.01.03.11.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 03:11:06 -0700 (PDT) Subject: Re: [PATCH 1/1] mm/early_ioremap.c: remove redundant early_ioremap_shutdown() To: Weizhao Ouyang , arnd@arndb.de, akpm@linux-foundation.org Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20210901082917.399953-1-o451686892@gmail.com> From: David Hildenbrand Organization: Red Hat Message-ID: <7ca43a9f-b62d-26df-0b9c-1cfa2f7dc611@redhat.com> Date: Wed, 1 Sep 2021 12:11:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210901082917.399953-1-o451686892@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Pi9k8rF4; spf=none (imf24.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A129EB0000A2 X-Stat-Signature: bxdaortajuyt7j5pfh7emkyhwgr7a5rw X-HE-Tag: 1630491071-185241 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.09.21 10:29, Weizhao Ouyang wrote: > early_ioremap_reset() reserved a weak function so that architectures can > provide a specific cleanup. Now no architectures use it, remove this > redundant function. > > Signed-off-by: Weizhao Ouyang > --- > include/asm-generic/early_ioremap.h | 6 ------ > mm/early_ioremap.c | 5 ----- > 2 files changed, 11 deletions(-) > > diff --git a/include/asm-generic/early_ioremap.h b/include/asm-generic/early_ioremap.h > index 9def22e6e2b3..9d0479f50f97 100644 > --- a/include/asm-generic/early_ioremap.h > +++ b/include/asm-generic/early_ioremap.h > @@ -19,12 +19,6 @@ extern void *early_memremap_prot(resource_size_t phys_addr, > extern void early_iounmap(void __iomem *addr, unsigned long size); > extern void early_memunmap(void *addr, unsigned long size); > > -/* > - * Weak function called by early_ioremap_reset(). It does nothing, but > - * architectures may provide their own version to do any needed cleanups. > - */ > -extern void early_ioremap_shutdown(void); > - > #if defined(CONFIG_GENERIC_EARLY_IOREMAP) && defined(CONFIG_MMU) > /* Arch-specific initialization */ > extern void early_ioremap_init(void); > diff --git a/mm/early_ioremap.c b/mm/early_ioremap.c > index 164607c7cdf1..74984c23a87e 100644 > --- a/mm/early_ioremap.c > +++ b/mm/early_ioremap.c > @@ -38,13 +38,8 @@ pgprot_t __init __weak early_memremap_pgprot_adjust(resource_size_t phys_addr, > return prot; > } > > -void __init __weak early_ioremap_shutdown(void) > -{ > -} > - > void __init early_ioremap_reset(void) > { > - early_ioremap_shutdown(); > after_paging_init = 1; > } > > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb