From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76436C5AD49 for ; Tue, 3 Jun 2025 12:36:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D66246B042D; Tue, 3 Jun 2025 08:36:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D165B6B042E; Tue, 3 Jun 2025 08:36:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2C9F6B042F; Tue, 3 Jun 2025 08:36:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A60C86B042D for ; Tue, 3 Jun 2025 08:36:14 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4D9171D4379 for ; Tue, 3 Jun 2025 12:36:14 +0000 (UTC) X-FDA: 83514037068.01.E97BE3C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id B856840004 for ; Tue, 3 Jun 2025 12:36:11 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RLf1QUm2; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748954171; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/tQxECYS1/smC9hMUUweuEWVJJtPYjs1Zxiotrh33KM=; b=Zn1PPkV6f6k6/56oClvDl2+bipyiKlhe7x31yE8Hugtt0qE+FnhEHtS2tRqWWcMF2ZrXE2 OWbISPAf9eAQQJR5OyjnhZBCHNDERieG+4LsG8zPi9bFqyqVLo4oJvQn/zx6SMNpeoIEET UZsgV9Y+ddXXPIg0iEvjvJV3zbkx/kY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748954171; a=rsa-sha256; cv=none; b=WoNgQZqUPKHtRzdaF1sv960xsJaKuIl8H02FI2S7Q2Plk12EvB0SxLiJDYssk5rWj74D/G TC9I89WvB3NiozNQ8oXewD7Yrrzo1ExroYlW5DoNYs+fagCD+alA78+bGlJ4XSFVDBdUyg iz9OxcmgND45wkZOVFv5ScNQBzDjR1k= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RLf1QUm2; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748954171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/tQxECYS1/smC9hMUUweuEWVJJtPYjs1Zxiotrh33KM=; b=RLf1QUm2yY2x7nVANYOA9O3z/mCiZucbMg/L81Llb1Lgmt0bCAExLa9x/kO7A96twAjPQr Nr2F72iEsrCs4kOpEKVwRkqZuXu8MB/L4L5l5DATSRikdXwoWiY5v71b7VsmA65TbOg4gO Jb3JBMyRLyjH3EzUKNhxOHgRV8yuEFE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-511-fIXBA8x5MhKKhaud9GS9QQ-1; Tue, 03 Jun 2025 08:36:10 -0400 X-MC-Unique: fIXBA8x5MhKKhaud9GS9QQ-1 X-Mimecast-MFC-AGG-ID: fIXBA8x5MhKKhaud9GS9QQ_1748954169 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-451deff247cso8193305e9.1 for ; Tue, 03 Jun 2025 05:36:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748954169; x=1749558969; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/tQxECYS1/smC9hMUUweuEWVJJtPYjs1Zxiotrh33KM=; b=sHIbMD0j6Y5l6gl4zNWUuRMtQa7ljkLgfcX0PszGXVSeDC/I6/mthWwJO3ZoGNm1HK CzvU8oBJrP6+nTnu4KS9fkkF/3M+vN6JMHh4O3m9MfuiVXuAmEoB+1LWfGMT2+cQFN7o oxjFloBKYaFft/Z8wQCyzHD1QSG9IUx0/iaiJV1TBzMnRLM3iOVUM17ns3+82aCU2jUK LH7fg3Hta1bOuEdgXz2HJtxFj3sREx0JB8kfahSWaFWeire9hHvVoGk3lvSDWLSkrUcE UAKT+r5Ypgn/JsXrQQ3nhN/VuYaiLf+rmHR9CSzn1l5oxcGsRaAVOvx9Jp0irAYFHSRF 7EqQ== X-Forwarded-Encrypted: i=1; AJvYcCWGrw/86p74Zgyg2FLbepdh3NjGqBCt1/xr4Fg4QMPoGi853s/qWT/Bcvo/aW/EA96akTBs915pGA==@kvack.org X-Gm-Message-State: AOJu0YyMDs24QqqJSqY0vugzwszontgX5w5ewVpZgyejRsgaZ6qyXB+V DvCgNvRsuPcH2zHpIL6ZCuIDp9lPBSzepysUab1svdkKg43PWx3H8qZA0NUZUgutu+G9v+23h10 EVdAHr6x5oBeSsssQgkvlgUupnK/orsltxFu65FjJMX7TV2BswHNU X-Gm-Gg: ASbGncuMDJQdMtSezeh0jlys/m6xjtuSKhNDHUguYFHK38AsrSRQrpkwzL7KN+/gmrp xt4lYPkPVPpBIYKjuXFcQEcUzhERBVYwLYUjQ2S+TRmGe7obvv2cKUtSjLcIuS1UoI31zOVZ2ho sljvz+0tFl8E9giXZ1EIs54q7naLO0Y3PG+nFdHMNJMAHr5LG828TVHzB8+GkZNQHuoCS3esUNH pagwCauMhWBLro3H/t3MRW2PZEuYvABxum+sJpazfoToPqHbFY1oQ8Jl9aVjfuFrBCKis3w9n36 rwIsO19T8G0DdvN8ZwLOaSu7rkbf34vVFpX75fS/R+QMq7EDZ258xII/8EtI/UWwrmQ1/ytApDA sfc3QhsNGF0yfmTLXncU7WFc4ppoF1n8Md6r0tyEAFAF+agkLBg== X-Received: by 2002:a05:600c:21c6:b0:450:c9e3:91fe with SMTP id 5b1f17b1804b1-451e6145d37mr18297225e9.0.1748954168760; Tue, 03 Jun 2025 05:36:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcMznGkf/3PuTOjTnCzKPSm+vpB95SJjFtp4NeDGhsc3C3lfBjzt4eDnWq3j8e6MwshfvgFg== X-Received: by 2002:a05:600c:21c6:b0:450:c9e3:91fe with SMTP id 5b1f17b1804b1-451e6145d37mr18296995e9.0.1748954168347; Tue, 03 Jun 2025 05:36:08 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0d:f000:eec9:2b8d:4913:f32a? (p200300d82f0df000eec92b8d4913f32a.dip0.t-ipconnect.de. [2003:d8:2f0d:f000:eec9:2b8d:4913:f32a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7f8ed1bsm167340075e9.8.2025.06.03.05.36.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 05:36:07 -0700 (PDT) Message-ID: <7ca09fbb-8b10-4dea-9456-dce21ade2099@redhat.com> Date: Tue, 3 Jun 2025 14:36:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm To: Mark Brown , Andrew Morton , Shuah Khan Cc: Lorenzo Stoakes , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250527-selftests-mm-cow-dedupe-v2-0-ff198df8e38e@kernel.org> <20250527-selftests-mm-cow-dedupe-v2-4-ff198df8e38e@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250527-selftests-mm-cow-dedupe-v2-4-ff198df8e38e@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: VJyAeGQv7Q2Dpj2iYSWHsqr7M5BLI7B2InhmafgcFPM_1748954169 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B856840004 X-Stat-Signature: 6wtwnj3txcyaw7qm3i188rjrf5ejdup9 X-Rspam-User: X-HE-Tag: 1748954171-998761 X-HE-Meta: U2FsdGVkX184rLcTx5JclI9eD5MSxb9ge01TgKWGik/k86387rQEiDgh+D4n5NNmPmytXTLg3KJpkO+sucI4eBjczzydf2QQrC0KOH05GmjmodLsYp6j0e01vJT1IAzMN3e+Lmi7GpIpiAuckNKnqT9PeaJ5/Rbfs1fKWPCPWVRLFpQA3m+I4BUmTpe+S4vPFbzyKZPWjC7CyW/d11e79ZMwnwazXphR8xCQOt9Al6Wf9Gw6oU1DEotH86S2MbGACfIBJmiiJYeyfC6PNtPBDpTl3NwG1FRU1FuLJdui0PDOGNvDQAIfBha7dFjPZTIN9f8MEMBv1pzPnIkRVK6GBdhYTS8y+M1Skd/b6kP8+bofBNkreisbYGKYAmDK3UCSXy+tZi89PrkJFbdJ2s9mT1CYNK7i99leuHThSowohrLVcqfZnUL1+cK+XMKeIRJVTaoycpeJBrIGf6gMCwhR7pWOvURmsdQI/zWnOa6zhpJBqR67RF+ZCYaL5qtIX9Uo9A/T2QC7UP6EFo57hu68qbSOPgE4TY2iH3L9eoyXQffoq2B+RGLILBv7Z8hle15ZEy9Q/oZu4hnQ42GuQtD2C+Rt4Px2ArruTFLJ5hSkPHEg4GTCL/1mRZSFTrDUzVEX4gu099Ic4z3LCptX/e5ahaoOx3hNDPxb5CZJgKDXkVcHRpFIb/qOHnkPrw7Su/dUh00BYPS1Punq0Osiz7RCwcxQVrJgs7HrqTsbDfgthlt5FkcpTbXhVOzaJbUuzZnUwZ9CKnV7G/GrL+I+z+RlF4Logamf7HaAI32sCyr8mRU7gum1iSdhHvFDufvEbFRNA58BdBQvXVuJBCKYzKI+WruvFxaYFh7IxkLw7Swe5J2npWiHYakogRxVwyyhcxzpm6ayepw3AhnKoqQLT90sW/GyrO62C3nH3ccPmzSBnHp4RXwP2oGXEZQ8omM4pJ9SBW1HBYm2LgiV8l68gO2 F7KVwYct P/xD5GTWtjXQ9tzQhJ4lVgL1RqRzF8jJ3RwfksxewrrJTXd+1M1q4+/9gRhkatfeDj+VShQaP7UtLnEPVGqxv9jnk0u7VUe+WRnlOzafGPvz0VSDetvb26SvVMV4in4Gg4vYKcznZN0N1IOap7q9vrLOBBncdMjLroFR+6IwzxxUE6mJUun3DrK4IUKBGHOR4vFAASTJ+Dl/1a67ZLi+n3uscRloev9z4F1GI9/p897dXHWUWBKhmQh+3sD2MjOEstnipkz3rclUEyzWGT7YS/VF4n5/KxqPG8iiFgM0vSYiIJ+bJggdlL/8S+GlDHxsAaomekzwbhKdFagIbfDWWA/YpnhSe7u9BGh5Y6vmVd6TnvjlRDojwm0CnDK/x7RMVRJOj6dnQgTVkOTqvqN3z2ROrwPSZmOIBxN3tnPO19pkn5HfV9Srdp9xiQIvSwwsYFTMVTRp2/nSj2Nz03BeYoCP4LIH8ro6wbvTE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.05.25 18:04, Mark Brown wrote: > The kselftest framework uses the string logged when a test result is > reported as the unique identifier for a test, using it to track test > results between runs. The gup_longterm test fails to follow this > pattern, it runs a single test function repeatedly with various > parameters but each result report is a string logging an error message > which is fixed between runs. > > Since the code already logs each test uniquely before it starts refactor > to also print this to a buffer, then use that name as the test result. > This isn't especially pretty but is relatively straightforward and is a > great help to tooling. > > Signed-off-by: Mark Brown > --- > tools/testing/selftests/mm/gup_longterm.c | 150 +++++++++++++++++++----------- > 1 file changed, 94 insertions(+), 56 deletions(-) > > diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c > index e60e62809186..f84ea97c2543 100644 > --- a/tools/testing/selftests/mm/gup_longterm.c > +++ b/tools/testing/selftests/mm/gup_longterm.c > @@ -93,33 +93,48 @@ static void do_test(int fd, size_t size, enum test_type type, bool shared) > __fsword_t fs_type = get_fs_type(fd); > bool should_work; > char *mem; > + int result = KSFT_PASS; > int ret; > > + if (fd < 0) { > + result = KSFT_FAIL; > + goto report; > + } Not a fan of that, especially as it suddenly converts ksft_test_result_skip() -- e.g., on the memfd path -- to KSFT_FAIL. Can we just do the log_test_result(KSFT_FAIL/KSFT_SKIP) in the caller? -- Cheers, David / dhildenb