From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8D8BC48BC3 for ; Tue, 20 Feb 2024 09:11:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E9F96B0088; Tue, 20 Feb 2024 04:11:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 79B296B0096; Tue, 20 Feb 2024 04:11:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 613C26B0099; Tue, 20 Feb 2024 04:11:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4F9D56B0088 for ; Tue, 20 Feb 2024 04:11:54 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0A055A0510 for ; Tue, 20 Feb 2024 09:11:54 +0000 (UTC) X-FDA: 81811614948.12.A339F72 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id CDDD840024 for ; Tue, 20 Feb 2024 09:11:51 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hVcyQQyi; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708420311; a=rsa-sha256; cv=none; b=Fhpx0+bl2Vs+ll9QCTkyTuEsTXXZTp39HoNb47xF7LLgoryUqCbs8O+QQojYJUSC2oAW83 uJGt9q9OmtT8bVrAd8y+fLx1dLjy6NsgUZREeg7ycxLyW+1XevzZ0jJbav9xCCLBohlIwc e87wQmVBCEQwanHlHx9dWE9aGesgR3M= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hVcyQQyi; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708420311; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ydpv7uzb+kCUFp13gnlTxWS2SWh+s4umAAY6DmFWn44=; b=zoJM2cJYk9BqiW26mJ2mLFcGdd/IfJetOJFixNvWvFDLrDLf0TSJn2F3CTn/B0H4MzHZu5 XjTpKDtCOzP4Sz2WtnMcAqxWg86PjlDqxYxY0HDAi/2CcGybE/AoDfZ1HVGV9W7Sr4Y79v kYpuCZGZAz2QrTXvGgXCfhrtgqANDQA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708420311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ydpv7uzb+kCUFp13gnlTxWS2SWh+s4umAAY6DmFWn44=; b=hVcyQQyiNVW1a6mIeMZlOQmA41PvZu3RI9aElsh0tOs/Zb7mj/d/cB3IfpuNl5lK6BKx0T AfR15ewoe0Z7AWFcSI+Q/3LadvOMRfyZEMVaiQC/UzrQlE1oYJ+2B0OX3CAe9Sl/2Jq29i GAdvzHQT5Jyj+GIORkW5hlpi4Y32k8c= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-O3qoyoi7OgOdvhWyDvFKDw-1; Tue, 20 Feb 2024 04:11:49 -0500 X-MC-Unique: O3qoyoi7OgOdvhWyDvFKDw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-41256ffe281so13710175e9.1 for ; Tue, 20 Feb 2024 01:11:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708420308; x=1709025108; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ydpv7uzb+kCUFp13gnlTxWS2SWh+s4umAAY6DmFWn44=; b=GoJeFw1GeZjXdZrInzbHbUW3IljYL1CHCe9/Tz5IEvNXVam/9ZVhanwJTKoqMRNGYJ lJSVQu3TURBhVttgfgAzzsUhWO51lry7uOv9p95qo5Y9yMfNBK22oPoq5C4u11vv2cCt pgBAsXb6brMeRhf3N0luQzWsf+hB5GLwC9or80nrrqk/hpBBK8hbm9p4qSKWFbXZAKqc pTnHHuPcF6v7zBKFRt9HlIUpxek04ZALsKAt7EiAGM588YjkXNSX52bYe3M+jAGMGVkK ggNJmnuPRSBlaNo9PP6a9b8DlM8rkb7mC1+oBW7NWedvtw7vuUZIDkWMAK5hH+AE5qbV 3u4A== X-Forwarded-Encrypted: i=1; AJvYcCW57Sg5tjC9APzTQ2CVu5pgD4yhwdMVgF4LcykmtJEQX7dzv4Og+aMRO/vwCKBEBYXc1FNerH5Hzzo5+w692MJXbKE= X-Gm-Message-State: AOJu0Yyyl6DB/a8/4MSRyNOlrwlfjwivzF9Qk36q63bQeC/AGSGLpTQS NOgfT0DhDXAa78JNazH1H6U18NakARtJhMzUhAUV/PXQAkwFEEw+VwCodNxEmhs3m0iLFw+gIGt XeBBEdR69u7xGWdiDUD+5EXGergg8CutgK8PrkjFXgFiDY7T8 X-Received: by 2002:a05:600c:4507:b0:412:6170:a178 with SMTP id t7-20020a05600c450700b004126170a178mr4893044wmo.29.1708420308562; Tue, 20 Feb 2024 01:11:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IFssF+sD8CPNhU1u7409oVIchgUTNyuXbMg8IQSuvbCAer9kgBnItgkaMXweVY12fvn+e4dgQ== X-Received: by 2002:a05:600c:4507:b0:412:6170:a178 with SMTP id t7-20020a05600c450700b004126170a178mr4893018wmo.29.1708420308218; Tue, 20 Feb 2024 01:11:48 -0800 (PST) Received: from ?IPV6:2003:cb:c72a:bc00:9a2d:8a48:ef51:96fb? (p200300cbc72abc009a2d8a48ef5196fb.dip0.t-ipconnect.de. [2003:cb:c72a:bc00:9a2d:8a48:ef51:96fb]) by smtp.gmail.com with ESMTPSA id u19-20020a05600c19d300b004126ca6c241sm2367328wmq.23.2024.02.20.01.11.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Feb 2024 01:11:47 -0800 (PST) Message-ID: <7ca085eb-baa5-4085-a2b9-7402bb3fd9e9@redhat.com> Date: Tue, 20 Feb 2024 10:11:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/4] mm/compaction: enable compacting >0 order folios. From: David Hildenbrand To: Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" References: <20240216170432.1268753-1-zi.yan@sent.com> <20240216170432.1268753-3-zi.yan@sent.com> <416d1450-6480-4113-b778-689a8f1d4e42@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <416d1450-6480-4113-b778-689a8f1d4e42@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CDDD840024 X-Stat-Signature: 1zt6tcezn5y7sckd6xwqu8hjbk7hdf74 X-Rspam-User: X-HE-Tag: 1708420311-680091 X-HE-Meta: U2FsdGVkX19ZbhfKxpzJyn9H+KkM00TtLahDKSX02MrxQmU2srg3w7osRbw1qrUn9W7Adljjwvj3OCVWoyWlcOJXt57630garooHJwSd0CQvMhI2hwUMuEZTqzo+DEfWR2Eg+ulKD3WucltldX8GCWcoltUYOwtnKf1p1QBpsqaGsun7CTnUHBryNmWi7JyyB+4dmqVgku33ppWgalY6KIA7SEGYgtysKU9XWLcoperO/VvnK/8nte378ftKozKpePQ2zhY+X8kjKu4xipbXlPK6Mo+6PD/d2Aw1kudovGWijZVp+XNc2IAQ6uYrPH2BZEOHCSFwBI3ldYJY97fGppAyebHI8iVut/glsASNycJxfe3d/ksoM/yJ91VBraWqBYh5iG2YhbGIMBTgfNpC8UeOJLFVptr0QBqWuMuTKTfrd+iXxG19oGnwNvZhbJXypa19mIIvrzJNGlZ7+IVnZNjo9DCIpeSIJ7AcZ5MoYfww6ViC+Ev+lnosEAt7Jr5BJzQyUoN+Y3IW+8r0isc/LpwZxt5AC0EJsDPldLOnKrBDk8PF33cQPzyYZm9XTt7t4myIwLb2RejKeIdnAWC7ZvzI9psiHZQrHSOg4SwYzCAWZIetavNxtWd6ZQP/oceMZPlkqNlIKXsCwz8/1LaPFIlekgCCzqrbYhTD7I38hrs4yjRWFLLGD+557J/iPJ9o6n1q703Xaa7rjJzgCS7dwGt9MhGSeARZhDGNoglTP/hHjHbdgiFXkPr+TmYHkl1gT7zGpDlO78VemgdSvlZd9faB1dtylvTiyNX4EBlaLNh9Hb7/zs2rwy7Ay9++Wfe7aK489vpuuhPec9dtTDaMpHlGymIr1zsUxh/zwIWMaEolDjVai8m/WTAJb2MoWgtQGMhY7O/Pt+23p0+KCzezCUH1ezSv6kKa8H9q5lQRhkC3GF9ZOP3Nte/YnYEw040qglEoXRgXSPKFsKNzKFo C7OgNWOA qt3y73buhg49ToPAjSqIryTOSFpIoAS3VWG103L4JBtSsne/x47tN6vhugUHrbxUVI6nGDg2ipfWxHAs+miZFZma3NYBFMfFHKfGYoR1md9klEQAVtNj1JD6xtSxN6VMD21kOuxmuDRi/8IU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.02.24 10:03, David Hildenbrand wrote: > On 16.02.24 18:04, Zi Yan wrote: >> From: Zi Yan >> >> migrate_pages() supports >0 order folio migration and during compaction, >> even if compaction_alloc() cannot provide >0 order free pages, >> migrate_pages() can split the source page and try to migrate the base >> pages from the split. It can be a baseline and start point for adding >> support for compacting >0 order folios. >> >> Signed-off-by: Zi Yan >> Suggested-by: Huang Ying >> Reviewed-by: Baolin Wang >> Reviewed-by: Vlastimil Babka >> Tested-by: Baolin Wang >> Tested-by: Yu Zhao >> Cc: Adam Manzanares >> Cc: David Hildenbrand >> Cc: Johannes Weiner >> Cc: Kemeng Shi >> Cc: Kirill A. Shutemov >> Cc: Luis Chamberlain >> Cc: Matthew Wilcox (Oracle) >> Cc: Mel Gorman >> Cc: Ryan Roberts >> Cc: Vishal Moola (Oracle) >> Cc: Vlastimil Babka >> Cc: Yin Fengwei >> --- >> mm/compaction.c | 66 ++++++++++++++++++++++++++++++++++++++----------- >> 1 file changed, 52 insertions(+), 14 deletions(-) >> >> diff --git a/mm/compaction.c b/mm/compaction.c >> index cc801ce099b4..aa6aad805c4d 100644 >> --- a/mm/compaction.c >> +++ b/mm/compaction.c >> @@ -816,6 +816,21 @@ static bool too_many_isolated(struct compact_control *cc) >> return too_many; >> } >> >> +/* > > > Can't you add these comments to the respective checks? Like > > static bool skip_isolation_on_order(int order, int target_order) > { > /* > * Unless we are performing global compaction (targert_order < > * 0), skip any folios that are larger than the target order: we > * wouldn't be here if we'd have a free folio with the desired > * target_order, so migrating this folio would likely fail > * later. > */ > if (target_order != -1 && order >= target_order) > return true; I just stumbled over "is_via_compact_memory", likely that should be used instead of the "!= -1 check. -- Cheers, David / dhildenb