From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37DBEC433EF for ; Fri, 1 Oct 2021 23:20:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 91D5161ACE for ; Fri, 1 Oct 2021 23:20:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 91D5161ACE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 23892940158; Fri, 1 Oct 2021 19:20:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E7BF940121; Fri, 1 Oct 2021 19:20:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D6D9940158; Fri, 1 Oct 2021 19:20:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0170.hostedemail.com [216.40.44.170]) by kanga.kvack.org (Postfix) with ESMTP id F1AAC940121 for ; Fri, 1 Oct 2021 19:20:16 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id AF4E4183C8A83 for ; Fri, 1 Oct 2021 23:20:16 +0000 (UTC) X-FDA: 78649439232.38.6025011 Received: from smtprelay.hostedemail.com (smtprelay0228.hostedemail.com [216.40.44.228]) by imf06.hostedemail.com (Postfix) with ESMTP id 5F644801AB3C for ; Fri, 1 Oct 2021 23:20:16 +0000 (UTC) Received: from omf12.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id F0649837F24D; Fri, 1 Oct 2021 23:20:15 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA id 3690B24023A; Fri, 1 Oct 2021 23:20:15 +0000 (UTC) Message-ID: <7c9103aee37509a28e426756bce7d6a5ae0ced16.camel@perches.com> Subject: Re: [PATCH] memblock: Neaten logging From: Joe Perches To: Mike Rapoport Cc: Andrew Morton , linux-mm , LKML Date: Fri, 01 Oct 2021 16:20:14 -0700 In-Reply-To: References: <623750dd31aa3fe5e45c416be98ab37707e2c45d.camel@perches.com> <6573ccd25ce80f5e28ed35e4c88c898b0f994fbc.camel@perches.com> <06ede4d0c1bf66614c9e9e013098a876aeec883f.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+KTZ1DsDiZZssa0mGFdbvEO+ae1Z6kjbM= X-HE-Tag: 1633130415-644694 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5F644801AB3C X-Stat-Signature: 4w4xqzupiqqdnz5p6f9uw8x8nhemushe Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=none; spf=none (imf06.hostedemail.com: domain of joe@perches.com has no SPF policy when checking 216.40.44.228) smtp.mailfrom=joe@perches.com X-HE-Tag: 1633130416-787486 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2021-10-01 at 16:12 -0700, Mike Rapoport wrote: > On Fri, Oct 01, 2021 at 01:34:10PM -0700, Joe Perches wrote: > > On Fri, 2021-10-01 at 09:37 -0700, Mike Rapoport wrote: > > > On Thu, Sep 30, 2021 at 06:27:15PM -0700, Joe Perches wrote: > > > > On Thu, 2021-09-30 at 14:12 -0700, Mike Rapoport wrote: > > > > > Hi Joe, > > > > > > > > > > On Wed, Sep 29, 2021 at 09:43:14PM -0700, Joe Perches wrote: > > > > > > Use more typical kernel logging styles. > > > > > > > > > > > > o Add and use #define pr_fmt KBUILD_MODNAME ": " fmt > > > > > > > > > > I don't see it as an improvement. On the contrary, the output becomes > > > > > somewhat tautological: > > > > > > > > And rather easier to grep as the prefix is constant. > > > > > > memblock_ is perfectly greppable > > > > Of course, but only when it's there, 2 instances out of 9. > > I didn't object to the patch as a whole. I just don't like the pr_fmt > definition. You should do what you like. I did what I like. cheers, Joe