From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C0EFE71096 for ; Thu, 21 Sep 2023 16:36:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A96656B01F1; Thu, 21 Sep 2023 12:36:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A46F26B01F9; Thu, 21 Sep 2023 12:36:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95C6C6B0204; Thu, 21 Sep 2023 12:36:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8779F6B01F1 for ; Thu, 21 Sep 2023 12:36:03 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 603D5C094F for ; Thu, 21 Sep 2023 16:36:03 +0000 (UTC) X-FDA: 81261156606.29.B590EF4 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 746B020028 for ; Thu, 21 Sep 2023 16:36:01 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695314161; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=61cvYkinR582ZFRp5+skker2ydBgKpbw8gJC9qrlf2M=; b=ictFpN13jJY4hK1Ic2hzpznhWaibNHNN5X9afNO2V1mMYSGvLChvTGzr4Ec7uk1+2FSmKS FP/u5+Q+rtZxRijTJ6uiSUYuW3sSH3z2pkbpQDexjTByMdRwdTk2J8kwvjb0oaut6oLTAw /bCHsnPKJW7A+epUIX5qxBpPRxnj0w8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695314161; a=rsa-sha256; cv=none; b=Dw92ZPDiNvUkcqiBlwUQZmYwIoie7udFUXEfCiJ003lz8sYxUgRy5VDjcE1h+WlR/+Kyxo gypqm9pJzofDl4NCLT69y0QUHln5xWhGTF24UQ/CN+wSlGMeN6Bcyuwp7T75c+incnXA9t EKHGuHpz5o+omCxeyK/Q2LtTsq2P0zo= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C5882176C; Thu, 21 Sep 2023 09:36:37 -0700 (PDT) Received: from [10.1.34.154] (XHFQ2J9959.cambridge.arm.com [10.1.34.154]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 82BA63F59C; Thu, 21 Sep 2023 09:35:55 -0700 (PDT) Message-ID: <7c5c2c00-d657-44fd-b478-743b43c57e8a@arm.com> Date: Thu, 21 Sep 2023 17:35:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/8] Fix set_huge_pte_at() panic on arm64 Content-Language: en-GB To: Andrew Morton Cc: Catalin Marinas , Will Deacon , "James E.J. Bottomley" , Helge Deller , Nicholas Piggin , Christophe Leroy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Arnd Bergmann , Mike Kravetz , Muchun Song , SeongJae Park , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Anshuman Khandual , Peter Xu , Axel Rasmussen , Qi Zheng , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, Greg Kroah-Hartman References: <20230921162007.1630149-1-ryan.roberts@arm.com> <20230921093026.230b2991be551093e397f462@linux-foundation.org> From: Ryan Roberts In-Reply-To: <20230921093026.230b2991be551093e397f462@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 746B020028 X-Stat-Signature: gpdkku43t5ka6y4beqrkeondymhcq4ph X-Rspam-User: X-HE-Tag: 1695314161-304954 X-HE-Meta: U2FsdGVkX19miZnaDDcodXuVt27mFh8m+yx7TmQP1UPNVI0p70WFoaqwL+dhFc4GcEdzOHz+VGV8BPniHB5RNQs0oWKRsOoJV6lDIqcvloSs6HirIFuoaAJFPJC/bB6nUnn9Vf9zYGoRudbM9Aps7avi7HL5r6ahRMLtEj5cTo7t8byf8qmCu9MfX4sMFV0x/MqAXs1ZUIOj6CbHz9jrhqGIx+G6We2k9ndwXcU9cCcO2d17V9fAW6pyeSs+KKXzwVaJEJCQxVOPld0HB//P06EKxVaPPSOLm4uQwt/pTcCQjQFpfO75V8QYkX87WWowjoiNG3XdNREfbNsh8tmU2wxr7PoQXF1GDG4hPS0pD1iQGVTyZqCg3VOfzITAkM2cUhywFddxqTYiPpvZa2Kr9JZ6s5d472eMbmLmUmWRw1HRpYHV4OUBC1rZCVegzaPKsTjGn/kY7GE89155aAMDXCxpB5BGcH0M3U4ikKqktenDik9i7/plRk0lelRos8BdvynEBsAD1Bdiyv4sM37cjreqb9r4Dfnt6ptVzcRsNGk8UH5lZNFIToxDG8gRhq3FGoc8/rPCaODsO2FLbgvvUrRQDMqrs3XIaTdYP1b/7MuPKKIqc4lZugbzm1xg/CpK/DpVRL9DU//trK+ZZBZHjfR3K2obvAjU53VhxgXBcmLb6Ayx3kfmS+mr39rIk1H9p/+AIeYvC0w4wvht67J+gJB7HrrTG1BL5lSX1t/A37ZZA/9fIsbYMN2PR84zJjCNwdw3OIK9GUbfXUvtrkiu8S8VFJXW7hKHpqHJIE1tsVz1Do1i6kegszx3N5UNHBzKJZZS8ME5L3LRzj1AhvNXWwLUJC4jfLauklESUdZmpEtXQkgrLx/ea28dI6A+g4Noc9jS+Y3j5/xzwAwdMfH7yTsyrN29v+ggAF+4IYqsrGHIYrec5j/JLYJf2/TFBjoy8g0Q3VoELI+sNfMi4+4 vqoP/7df n7sRyh2LZxYYEEpLKshEuKhsXEoQPzE+lsJUBSaU+5CxZQelbYwR+kRgrvb8SDACtYAEhGkH90+T5EU+FtUw/cmfxRXOGXTpIrSDEWB76YKpEqLuBYKNQjKoDXgT3PEbAaqH73RYI0pOQHWzNk1ROUoWEjhzCyj1ddLK8Emy2EKrYCyPPSIG6LddSQk+SzWtcJkzOJtp3Qqc+cUkFWjW+1McccWo7wuby+EFGXXpTzv0rFDMnsGNxm0vabuXLhpTrNDAd3HwzzCVORPvoUwDM43UbnqUN2moNp2n9DVqP2uSfyiuS9NX64ck9CC3+WcwwTjqY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21/09/2023 17:30, Andrew Morton wrote: > On Thu, 21 Sep 2023 17:19:59 +0100 Ryan Roberts wrote: > >> Hi All, >> >> This series fixes a bug in arm64's implementation of set_huge_pte_at(), which >> can result in an unprivileged user causing a kernel panic. The problem was >> triggered when running the new uffd poison mm selftest for HUGETLB memory. This >> test (and the uffd poison feature) was merged for v6.6-rc1. However, upon >> inspection there are multiple other pre-existing paths that can trigger this >> bug. >> >> Ideally, I'd like to get this fix in for v6.6 if possible? And I guess it should >> be backported too, given there are call sites where this can theoretically >> happen that pre-date v6.6-rc1 (I've cc'ed stable@vger.kernel.org). > > This gets you a naggygram from Greg. The way to request a backport is > to add cc:stable to all the changelogs. I'll make that change to my copy. Ahh, sorry about that... I just got the same moan from the kernel test robot too. > > >> Ryan Roberts (8): >> parisc: hugetlb: Convert set_huge_pte_at() to take vma >> powerpc: hugetlb: Convert set_huge_pte_at() to take vma >> riscv: hugetlb: Convert set_huge_pte_at() to take vma >> s390: hugetlb: Convert set_huge_pte_at() to take vma >> sparc: hugetlb: Convert set_huge_pte_at() to take vma >> mm: hugetlb: Convert set_huge_pte_at() to take vma >> arm64: hugetlb: Convert set_huge_pte_at() to take vma >> arm64: hugetlb: Fix set_huge_pte_at() to work with all swap entries >> >> arch/arm64/include/asm/hugetlb.h | 2 +- >> arch/arm64/mm/hugetlbpage.c | 22 ++++---------- >> arch/parisc/include/asm/hugetlb.h | 2 +- >> arch/parisc/mm/hugetlbpage.c | 4 +-- >> .../include/asm/nohash/32/hugetlb-8xx.h | 3 +- >> arch/powerpc/mm/book3s64/hugetlbpage.c | 2 +- >> arch/powerpc/mm/book3s64/radix_hugetlbpage.c | 2 +- >> arch/powerpc/mm/nohash/8xx.c | 2 +- >> arch/powerpc/mm/pgtable.c | 7 ++++- >> arch/riscv/include/asm/hugetlb.h | 2 +- >> arch/riscv/mm/hugetlbpage.c | 3 +- >> arch/s390/include/asm/hugetlb.h | 8 +++-- >> arch/s390/mm/hugetlbpage.c | 8 ++++- >> arch/sparc/include/asm/hugetlb.h | 8 +++-- >> arch/sparc/mm/hugetlbpage.c | 8 ++++- >> include/asm-generic/hugetlb.h | 6 ++-- >> include/linux/hugetlb.h | 6 ++-- >> mm/damon/vaddr.c | 2 +- >> mm/hugetlb.c | 30 +++++++++---------- >> mm/migrate.c | 2 +- >> mm/rmap.c | 10 +++---- >> mm/vmalloc.c | 5 +++- >> 22 files changed, 80 insertions(+), 64 deletions(-) > > Looks scary but it's actually a fairly modest patchset. It could > easily be all rolled into a single patch for ease of backporting. > Maybe Greg has an opinion? Yes, I thought about doing that; or perhaps 2 patches - one for the interface change across all arches and core code, and one for the actual bug fix? But I thought the arch people might prefer to see exactly what's going on in each arch. Let me know the preference and I can repost if necessary. >