From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C878FCF6491 for ; Mon, 30 Sep 2024 08:45:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DD038001C; Mon, 30 Sep 2024 04:45:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38E0880017; Mon, 30 Sep 2024 04:45:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E11C8001C; Mon, 30 Sep 2024 04:45:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F159580017 for ; Mon, 30 Sep 2024 04:45:37 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4AFC7AC8B9 for ; Mon, 30 Sep 2024 08:45:37 +0000 (UTC) X-FDA: 82620771114.21.53C53DE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 16500C0019 for ; Mon, 30 Sep 2024 08:45:33 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=isM+FchQ; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727685809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a/430ydxvfdkbT58361Uy7HVxy5PiphOwNV4mQnykbE=; b=6uMyZh30IqqsxCSNUcNNf9KTKETC/PgwzNY9f4gof6nHVtRUTBMlYpn7g/MNNSBA8EKKB4 0+kag5fgQUXd2L06BwwAOaAabIlfwFYUMAqzOU931tUzJcZLUOuel8cuQeL7O1zqNXHyAs ZHGN8nvj6nseBYqnzP4Rq7KwCIhyPuM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727685809; a=rsa-sha256; cv=none; b=gphyNw3R6wG7cKg5/u68C6C/l3Mh+MKNYxIvpZ84XonAqDBZzYJjsXHkLgMN+rlWUNnDiJ +9ipDsMUjBmtrUsvlL3+jK4TuU3hNEGeOXJEW7CH2NLrt/d95znhK5hGGzzvp9SF2yjI7J sbZBbyb2JPVlO99nAtuOdXaSettspyk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=isM+FchQ; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727685933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=a/430ydxvfdkbT58361Uy7HVxy5PiphOwNV4mQnykbE=; b=isM+FchQ3w4kdNfrAVFDjTLCPccIVM5F2/jnRqL6b0bh7g8Widtlce275cR6N9pvcDuf80 aEri6VlAO+hRETeW7bx+DU5X853EmdhVVTsOreqeZC/uqoiIVY9VMhxzNa6FpFU/3PC5qd MmQpvPbH9eNpmHMIic15QlUGdCp1E1w= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-299-MdH3KiTVOVKIMg91gboidw-1; Mon, 30 Sep 2024 04:45:32 -0400 X-MC-Unique: MdH3KiTVOVKIMg91gboidw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-37cd4ec04a1so1226915f8f.0 for ; Mon, 30 Sep 2024 01:45:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727685931; x=1728290731; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=a/430ydxvfdkbT58361Uy7HVxy5PiphOwNV4mQnykbE=; b=eoQ0XqyLA7Gkt6jbx4ECI3bWrvOT/RyGjPEEcMaPA2OtfxickP1zwNjnPeTo0Iou5o kezo/m4G5HdhZx2csQ7daW7n7C1W6JdochcDAd+az8hN2rn/LC36fmuuDtsYhZV2yYL/ RnQFTeuQ9qDboUgP4UnKQAOD+kdg9ZH/N/NG6gXcwddp+Lh8uYEeBznJFDqvyhPSes21 Ln0dncPkgW+R4NQHT1eFqmUS4vzqSw9K23eHUeIduuKTZnHn3hsxPlp/gUujU3q7ECR9 NpfeKzZ61ldO0PNryqauBhdkkvOH0HEkDiR2BHUKUTBj9NsjLZq2FUsuFUWoTiHEADnT vvRw== X-Forwarded-Encrypted: i=1; AJvYcCVytks6mpMmCcZIFeWREXc+KA5B8hsPdTYMgt6tSUg7ZZejvz7zdTU8jCex2ezdINbz8mIMYMRVmw==@kvack.org X-Gm-Message-State: AOJu0YxzmJxyyG9SCElNpSEAQPRIhXA83tT2pKqZct+PVx4m5xNCqUq/ QDPSZuwAhxSAYQvaEno2xvqwatgeKvcKuqAE97EOphQqBOBR/HixbIchJ/GjVKJ4G1Zx4saufen i+QfVPlwmzLquFDA8VXqC2RhoVAfE+X6lDX0Av0sxo7Re1nhF X-Received: by 2002:a5d:5548:0:b0:37c:cfbb:d356 with SMTP id ffacd0b85a97d-37cd5aebe7bmr5448127f8f.28.1727685930997; Mon, 30 Sep 2024 01:45:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHeSuLQ3p/3SAxtJdxkEgYzS17qTXoyQLqPyhHTyNf8v3bk3S9YMvLIsay3YfHKh3OtM/IwOA== X-Received: by 2002:a5d:5548:0:b0:37c:cfbb:d356 with SMTP id ffacd0b85a97d-37cd5aebe7bmr5448101f8f.28.1727685930545; Mon, 30 Sep 2024 01:45:30 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cd57423afsm8472938f8f.90.2024.09.30.01.45.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Sep 2024 01:45:29 -0700 (PDT) Message-ID: <7c563924-47ea-42d1-82dc-3597151998a3@redhat.com> Date: Mon, 30 Sep 2024 10:45:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/2] mm: Abstract THP allocation To: Dev Jain , akpm@linux-foundation.org, willy@infradead.org, kirill.shutemov@linux.intel.com Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, mark.rutland@arm.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, jglisse@google.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240930052812.2627395-1-dev.jain@arm.com> <20240930052812.2627395-2-dev.jain@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240930052812.2627395-2-dev.jain@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 16500C0019 X-Stat-Signature: ragtjk6whrr45oqosrqyke3sfapzseot X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727685933-681592 X-HE-Meta: U2FsdGVkX1/76d2T4TQ71H78HNnmJd7h0v5+HMIlsmDTmTq+MXzPXuT07BBHPnz5FIICFc1yX3J5mFM/Ob7F0UlsrZXYjOnf7+nU6o+OQ6bOZloDAe0N+mcvHIOGE7SBs7Pa+ANIkXvqj/MGUHXfMPdo9v6VH+8owLA7se9Ql52xf2H3WDHhnNNMkgfoQtzdgesO60CQj+NfU8xvmwKzCd4O8eInYWgXRuZSJIiTH86Memyr72UZ6RcadP+KDgqfXgVzCXtVcpiFnAHhnY5FHGS24jz/JNRDlLWtVP4GqB/58F78LA/PrW19B8TXykVPauyJG6iouybyGvgqD+VqDYVHovIz0qeganT8d07c1WSSvlw4/4qSoL/A6NuveDVZeMfdPqHruGCk8WQxfyYAzDVP7P6V6UApNU/Z96DwB5YltxWdQ7PmOuie+GIu3xyVlwsPLCppVbFTvVrG1FEcDeOdCK1QIXPYb19GkrLHG+8hys8QIoQrI8phAZzViTu/0H+SaErOla8/lMf0DNG8cKHGGyN6HDhYR7C/AtNf1SG9xiR3CFETTiNe3KMjf7Mlyc8StjS/odrhRXW6AGO2cSkYkkNm8r2B77FuZDlNwAkS0Z613s5sAVsmRntQLbMC6PdhAfc3f8DQEAw3PTWpDDx2P+dIClx62ckMk6XezbRhKwX5rKygIGePxcadltfm5HQFkjSdADnMXNIdG+U9E0oqT2KADXXQxy7hYi3CVM2EHK1dlUUEMBm/0PrCqYs9A+W21SSWaZc+k+byr1yfUvNmQV5Cbq15iHjVg9IEZtDJ3wEH56VhRqiwE2ruuW/RDwbFuQnlEHr2SOas4DROM6+RQltgMgY/lVCdR9cbdc186YqaczDOjGyzkkZi56dREPzN4xegTuq8BEY6FCos85xlSBBDO9Cz/kwQ/jJXe6rlx52ztE4LG0lts1FJXqaAd69M+KEVQyKtDaums8n xCuFcHrv tkR1jr1LQwDqVJxNqGEcDqKmYLSR/ItAJ1vRvd/eCV3y+FVjWRA6gebYZuW8vx988ZGdFKdi6MlvCIaDBuumx/wWImuCavmjILGUxsOlonXWP47uFA7hGV0YUOmgClFnktX8hAzmFykmqt387IdxtJB4p+JdygQQPQduQhN5L3A8nW7EWdhNOBwPRgmB80HDkWbP4ocbN/pl2nzcvsqUqog93glFlJZUEyHE3DwZwyYCBUAGS49Xr8OYh+Oulby3NbPbeHPItRKmhShdUurM0qR6nhO2j4upNu2yEFCqOM7dF0NKB6BXZZaMmHDdlp5armnoFiPvH/HHP0fKlpeNH/w27tpveG7+8uGswH2MbNB8rswd1yJpjmd31+0oyrSi8SoeMYYXxX4vaHiTnf81MNCNKCvQ5KzEa443aP+KmuB8XIJY6DCvzCVXuH/kJmVHS7ypUtsxVIT6NKelvbVA2ikGmoucsHZ66A00xfziehrZ0So/2tKb7iBsWo6NTvYLbQ4HxZ0D7CWNCd3YTtg/0V21QHa82rkIDE+OniKKc8lz1oRo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.09.24 07:28, Dev Jain wrote: > In preparation for the second patch, abstract away the THP allocation > logic present in the create_huge_pmd() path, which corresponds to the > faulting case when no page is present. > > There should be no functional change as a result of applying this patch, > except that, as David notes at [1], a PMD-aligned address should > be passed to update_mmu_cache_pmd(). > > [1]: https://lore.kernel.org/all/ddd3fcd2-48b3-4170-bcaa-2fe66e093f43@redhat.com/ > > Acked-by: David Hildenbrand > Reviewed-by: Kefeng Wang > Signed-off-by: Dev Jain > --- > mm/huge_memory.c | 98 ++++++++++++++++++++++++++++-------------------- > 1 file changed, 57 insertions(+), 41 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 4e34b7f89daf..e3bcdbc9baa2 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1148,47 +1148,81 @@ unsigned long thp_get_unmapped_area(struct file *filp, unsigned long addr, > } > EXPORT_SYMBOL_GPL(thp_get_unmapped_area); > > -static vm_fault_t __do_huge_pmd_anonymous_page(struct vm_fault *vmf, > - struct page *page, gfp_t gfp) > +static struct folio *vma_alloc_anon_folio_pmd(struct vm_area_struct *vma, > + unsigned long addr) Just a nit as I am skimming over this once more: We try to make any new code / code we touch to use a 2-tab indentation for the second parameter line. E.g., static struct folio *vma_alloc_anon_folio_pmd(struct vm_area_struct *vma, unsigned long addr) { -- Cheers, David / dhildenb