From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A856AC76195 for ; Thu, 23 Mar 2023 12:06:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 240B76B0075; Thu, 23 Mar 2023 08:06:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F0806B0078; Thu, 23 Mar 2023 08:06:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B82E6B007B; Thu, 23 Mar 2023 08:06:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F1D736B0075 for ; Thu, 23 Mar 2023 08:06:30 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C424A1202B2 for ; Thu, 23 Mar 2023 12:06:30 +0000 (UTC) X-FDA: 80600035740.22.E747BCF Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf04.hostedemail.com (Postfix) with ESMTP id 9D7754001B for ; Thu, 23 Mar 2023 12:06:28 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XG2LwzIC; spf=pass (imf04.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679573188; a=rsa-sha256; cv=none; b=v4xq5NeD0gIAMtyePJyKOQ1zCPeP4gpY34C3OrdIRur/maYSsbpgRU1vud7OaO5w9fFptj wzAUZ5pFHJlvsQJ4fHjeTXfWmO089GEzgNDU+uHXPDY7HLR3m7mQEPHCuSI6KYqy3PXVgW nhd/OWQ4UYjR66zXBvj7iYiMOgk+eG8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XG2LwzIC; spf=pass (imf04.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679573188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eJmH0tbrplX0qv721RuMP2KjLRQ5o8Lk2BVGq3s7CDU=; b=yjc1+KlrnA+VKtxCnwbG5y4Dho32sjvxniT37JYjaOOSbE88vV3FfsLZ1lx2N/xCrjV6Wp igu3DUFQNVTU69QWVixNtBUlo/kcK4T2y81btx8+iDxyTGglO8U6f5M9rjt9iOU4Z7w7mg clNpB+XVWY6sBDVISvq2uQziPxJieK4= Received: by mail-wm1-f52.google.com with SMTP id p34so8324656wms.3 for ; Thu, 23 Mar 2023 05:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679573187; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eJmH0tbrplX0qv721RuMP2KjLRQ5o8Lk2BVGq3s7CDU=; b=XG2LwzICxCaRM9ycw1fWtNQG6P3+zhAwsxST5yW5/VnrcJZjWOxyDmH64jCUkTwRn2 /EHy5vDoXRD/+4N4odlGGH/wpVRaDtB0b00kXoOpmYWcuVzXeg9BGevNP0gzImOsNjcT FqUfBCl/+Rtd3osQrnyntSmx6+FvS7V9zMDZRZCPWHXe/VUdB+ZlBfs6KuaNLUUQbZO1 kOHozu0D3xaclaOFJXwiq2GsXZx+3FCZ8XBBSeWZzahDqhvLeMBFSEMxpIDB+r7fZ1wi uUsd/8TjtAKPebY4zPr1PwnALRAK+bjC3mkmicfJDOPwxe2xpDDiIfckKx6A99Rf8E3h pXDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679573187; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eJmH0tbrplX0qv721RuMP2KjLRQ5o8Lk2BVGq3s7CDU=; b=myjKMzQeBYB/b/1J4AM7vr0di+RSmu/ZZoMwQBzS3qqOYVbf8QAr6YDmnZUjf42vWN MW7qqCpV3wDtE0GNKQItbRIPMzAZbpkZy2TVUlsscyt4U4Uu+41XBew/tg/3FolhmZst ofPfiaA+qiHOOa3umaTnkIbMd8pSxURpcHxZMsHc8bR2dmNxhxSYMlS4rdYiSplv0qQh qKG9ErMRe+CHvG85c3H8YDrlKB+o1iMHi0yVfO3VJLBmBJ+dY/riGVBerK7ek2/V3dfU QEKG4GQiJ/Xeggm1cyO56MIW1sc5WJbXjZ5JgeyeSCCdf1JqzEFxGULMpwnelMjaS/0V IQzg== X-Gm-Message-State: AO0yUKU4koPZ7k5ZLpIpbmIU6jPT8AgVt+zBAbFvXXWV608ngXF2NJcS eC0MrmHmY3+lsnxLN+cVDk0= X-Google-Smtp-Source: AK7set9omZEy6gYLfwYJZygbluVZwjWh333f+xm0NpI7MllGA2uLGa/nuHnnoFto0M3/bvmNT/KkgA== X-Received: by 2002:a7b:c448:0:b0:3ee:814b:9c39 with SMTP id l8-20020a7bc448000000b003ee814b9c39mr1656924wmi.18.1679573187039; Thu, 23 Mar 2023 05:06:27 -0700 (PDT) Received: from localhost (host86-156-84-164.range86-156.btcentralplus.com. [86.156.84.164]) by smtp.gmail.com with ESMTPSA id a10-20020a056000050a00b002d78a96cf5fsm8909979wrf.70.2023.03.23.05.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 05:06:26 -0700 (PDT) Date: Thu, 23 Mar 2023 12:06:25 +0000 From: Lorenzo Stoakes To: Arnd Bergmann Cc: Andrew Morton , Arnd Bergmann , Uladzislau Rezki , Christoph Hellwig , Baoquan He , David Hildenbrand , Andrey Konovalov , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm: vmalloc: mark zero_iter() static Message-ID: <7c5275c3-ec6e-4489-abd8-fba6e03fa2a3@lucifer.local> References: <20230323115903.1483668-1-arnd@kernel.org> <20230323115903.1483668-3-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230323115903.1483668-3-arnd@kernel.org> X-Rspam-User: X-Rspamd-Queue-Id: 9D7754001B X-Rspamd-Server: rspam01 X-Stat-Signature: g5drzeszzw4yx75tkgxcs3364113pkxt X-HE-Tag: 1679573188-420548 X-HE-Meta: U2FsdGVkX19sOTazq5u7ccpQ8P2rJxhgE6w2IbkIUrDebNfxbhBULtz5WxtUtwaYrGNt3NyA+nwldof/d+mi3CYbiP52APH7mHRYytphoVVHtRKx7x+bbkizk2xOjv1EShkMM1joYlaUkp4YQ1ocBKbs46XBt9ds3q5jLyuODMCFbNk29bMfZ0suaQImKjRGqyudCopQX3guLXlDNtJ1wyLBzCVEsImFCqQC8O6b1XUt7+bPE5vlVN1i4YYJcynHlkdvwzYQBGGQcPQ696C9qlD7F8SOGqJXCNq2SLQYjMLBidpqRDBUtOur75c6V3RPfcajIP2awRDRz2SOxhaXoNT+3wRp173IScgZaXpU5Hi3Ow5ZI8sNzwY9JIGR2iyiafxk0dCIo2KsspCjEQBBT3zjvm1tVw2qeC8YVVrkOOwFq9UUcBjYNW+JdZ8PgWESOt1viiYo2v4jgQCZ5J4E5JMahg8NlGzqN21v2hrBpbDrt8Mb5E5TZgcTrCH4kpioDgs1Nx+o1/PiXw83ba5SlkKcQqqae4Bx7bBbpn0Xp5HOgMbi4fwVDhNC6QpYhb/i8pWzdXePAhayxj6666sCEA6xL4gc40anv/xNTCUxzV8n8SR97o9zrnnMs+mUpQkIQiyg0srNP2Dxy1uo4iJWN4DDdeDGlHM5EQihJVi3skOY0f6UVo3/CBOBVgkbp4WJEn3C1XKp36fJrAcWirGqK/t1vPJlsgzEkM13/ygo6pfO89smzJSJ4AQ/PNRFBW/UO/e8UAtoTvz2y9SgH4OWzu2j6DHrk7YXdT0F/3DUcbJZDbXrXMNAsr8BV0SDKOXvuQemMc1TpTNl8/wzbQP88oubTKsYYOIwIUadsdAMxjdTH+a4vqE3ZsUG0XPAkGt0xzcKIZ9WRrq/OHvnshbz5AaYuHLLds91yt3d1E6MryJ/p0fpqU4tK3nPmlgg43YVpLohRI6d/j25qMj0cgM d61lpjQq BDmlGRwv8gq87UnZETs1vF+OGt65pR1YpqnlEhq6FPczxaDEBH8Ej1coNC2wpdmcFoG4mb57mndwI18zoo9Jx3wuT6H9EapPtDsD3oKJAVsZ6d8iOPO1KTZHxSJ003A8pT7jhyMbRkhLeTYY0AYB3INsQBAo6nr0yM91U899NJdnNbmXqWlJPexb7uwbY4cG2BHKlprh8O8A/48KMhAVhn6AFs4vdWF21B+JkuFzrOLsTgEd7EZ3v++svFTA1dtm9k+vu2Uc3iz3TZvHgbXzUYwRB/Q0NyT0oEv9Qw6fKJhJRC4mbsKV3yTCfOsGLfBx+fiFJKaKPcYAFYYKc8Dqt61wTu8UyRnCRt87sRDXMZeWgh+vF8pXHqlxnkunb5UOHe0q8mPDeAquKG+GYjyle+iELs6uG1YTLCZuOCjwDhXrCSweVP2kiWPWH/PSvkXKw4HNtYAA8LPd0S7Tw+eOee2PmPrkMI00H3ViPcWUgHhYyaIVvT45vDUN01pV70TlEHVDwBM8JpypJjXPa8q5tp6k4bnKm1fQVSitO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 23, 2023 at 12:58:36PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The zero_iter() function was put into the global namespace, > apparently by accident: > > mm/vmalloc.c:3448:8: error: no previous prototype for function 'zero_iter' [-Werror,-Wmissing-prototypes] > size_t zero_iter(struct iov_iter *iter, size_t count) > ^ > mm/vmalloc.c:3448:1: note: declare 'static' if the function is not intended to be used outside of this translation unit > size_t zero_iter(struct iov_iter *iter, size_t count) > ^ > > Fixes: d9cab54f7737 ("mm: vmalloc: convert vread() to vread_iter()") > Signed-off-by: Arnd Bergmann > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index fb216495fe5a..55f5d6fc8629 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3445,7 +3445,7 @@ EXPORT_SYMBOL(vmalloc_32_user); > * > * Returns the number of zeroed bytes. > */ > -size_t zero_iter(struct iov_iter *iter, size_t count) > +static size_t zero_iter(struct iov_iter *iter, size_t count) > { > size_t remains = count; > > -- > 2.39.2 > > And finally, this was also fixed in the latest version (v8) see https://lore.kernel.org/all/cover.1679566220.git.lstoakes@gmail.com Again do forgive the noise! :)