From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD809CFD357 for ; Fri, 11 Oct 2024 11:40:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C86F6B00B9; Fri, 11 Oct 2024 07:40:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7795D6B00BA; Fri, 11 Oct 2024 07:40:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 668106B00BB; Fri, 11 Oct 2024 07:40:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 498B16B00B9 for ; Fri, 11 Oct 2024 07:40:17 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EF71440D3D for ; Fri, 11 Oct 2024 11:40:13 +0000 (UTC) X-FDA: 82661127990.20.49AB1B3 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf03.hostedemail.com (Postfix) with ESMTP id 62EA020018 for ; Fri, 11 Oct 2024 11:40:12 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728646676; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WT9/t+aj83FXT54KF3aStr7jUJ3nHMQcz0IX8R7S81Y=; b=gKoitcNN+Zt7+xAgDA1rTm7Pv6yMCvkQmiB/ZfuF+NOavHSUPoLT3TTlIv0Ny2pHW3wMNG y6wVGo0TYjUNkLoaw5joxiEHEQP0KuhHdxmobn+YYCUF9iKvPA0joPHiGFHaiUL7NnmOxE lHMbyyBN96QFaHq21RiT5xpEFYNXq7I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728646676; a=rsa-sha256; cv=none; b=8XTaIzEb/Bg+pGJIachv/X3Uw5ZJP2Zh5hgog/xZ9oQp3CpQq6sqWqnj2/AMqTAQIgaMcS uDv/6yTTM75reOmtwPivcnPJr3r0P/RKohpVZbgVAtvQP1eXFlKM+6hHjhc5QCHhmO+QD0 84+k0c2VMxZDjUFTOI8tzuQy0zWTTn8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4XQ4R63z3JzCtBj; Fri, 11 Oct 2024 19:39:30 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id 863AD1400D8; Fri, 11 Oct 2024 19:40:09 +0800 (CST) Received: from [10.67.120.129] (10.67.120.129) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 11 Oct 2024 19:40:09 +0800 Message-ID: <7c4b8aae-dcbd-4d45-b7b0-82609cf8a442@huawei.com> Date: Fri, 11 Oct 2024 19:40:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v20 06/14] mm: page_frag: reuse existing space for 'size' and 'pfmemalloc' To: Alexander Duyck CC: , , , , , Andrew Morton , References: <20241008112049.2279307-1-linyunsheng@huawei.com> <20241008112049.2279307-7-linyunsheng@huawei.com> <8bc47d27-b8ea-4573-937a-0056bdd8ea2c@huawei.com> Content-Language: en-US From: Yunsheng Lin In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.120.129] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemf200006.china.huawei.com (7.185.36.61) X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 62EA020018 X-Stat-Signature: uq1bci5uf8ohhnpkj6ykr64m7wf31qzf X-HE-Tag: 1728646812-908288 X-HE-Meta: U2FsdGVkX187lf76aCWgGHiBnpH2iEFYP8X8vZrBkG5WOo/zyAG5RoBCGFOKPrxkey/OJXKEJJaiqdWUurfj18casJDoyLLyY2HTUIegV3vSH3bJA/+lkXsFkeliiDXy0344n4/0UnkyxldYjzTj8nnuysT6Ppz5qjDpdG9IHAZEOSB8LadZUpiJUyin9p4ifJ3EOM0DlPWFNOK9UuPN7QRqOJMMzt2z0K88CuCZxdRc+ngHIn5C0QWPfgqqSGcnPvf6cME7muT/Ifp5ZH8kEDUxwfuKGTl1dmDDb186HRKYciIa+rprYSOaz/TMzfiSUvbpq57/iW46SpIky6BYz63XKIclPUUnzxWaoVj91iEg1N0bC701El4FK+KTxENegi1ft57MivqGgXvRczYixT4ILcb8+6pAQtfg0PrKchnTdVjLH625WQB+D3HANyUqb4ebbT3imWydPMGZb+ZcneYxxmuypQU3wMJiPLMOEcE8Ec2kfX/CLPZv1rXJX2IVW4ABZ8UjX1F4cp0VfR/7nxadsbS7H69eprzoL+/zpPa63SHrwkg6HORcahvaQUxZJJ4L5R7mi2ApVGgFbkswOsg1WA9CPFlnB1bsD1PUA6k+wBZo8JBDTGEkO2v2MFvxRRb646uVJTtuHQob3VfguqPxAV3D2TU1Oqq15qR0gHDOYzGXIsvVVzOP5TLQu8MzZwq8vw/O3FmPtV9/vJ4pdonxdkEKHdXTzvM44H6FIR0hrxRzTU1wdP/CSzo6vbMd/3VRmyFhDoGfkGs46YArWR/dOE4lGMTRBu3hEWk9whzB4NA79nvFGN52TL8tsb9Yat2t0PZg5l3KY4iwwNNw8bkZX5C2hcc6FS7xy3tTzANnHVKnOF6LmdNjBhn8tHbxVSuqLVWZBB26SNEVlhj6Azs7+9nMHwa8qNkTZShOmrl+lbh64E9aIC9W46QV4YmbFi6zj/rPYgQGE/3JePZ libIRddx 1uKx8qEc/M21NMy/MYHXYJIeepYfWHom+jckSHZ3s/2sH3QpBBA1qIilKu11JrI9IgI+PuNyYEec5VK6n9UX1lqJ5MuaKewcGqX0aiQGuXhoulA150+F71TvmhSkmfjE+mLCc8c1jui7rrbn02/zkbMCgt26xw1FVq440Uch+dl3jJVKLfjJ4Cf4+64NZLskrcGqB13bmChV4i2Mlw2uow3B8Y/Egw8V8WgH11qYr/OD+7vHasr5Ys2kWlizUpEFP8SqSR6ZMBcZ2y3k2sZj8tOdNtY6KGBQvm8n6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/10/10 22:33, Alexander Duyck wrote: ... > > For the decodes yes. I was referring to page_frag_encode_page. > Basically the output from that isn't anything page frag, it is your > encoded page type so you could probably just call it > encoded_page_encode, or encoded_page_create or something like that. It is kind of confusing as there is some mix of encode/encoded/decode here, but let's be more specific if it is something like below: static unsigned long encoded_page_create(struct page *page, unsigned int order, bool pfmemalloc) { BUILD_BUG_ON(PAGE_FRAG_CACHE_MAX_ORDER > PAGE_FRAG_CACHE_ORDER_MASK); BUILD_BUG_ON(PAGE_FRAG_CACHE_PFMEMALLOC_BIT >= PAGE_SIZE); return (unsigned long)page_address(page) | (order & PAGE_FRAG_CACHE_ORDER_MASK) | ((unsigned long)pfmemalloc * PAGE_FRAG_CACHE_PFMEMALLOC_BIT); } static inline bool encoded_page_decode_pfmemalloc(unsigned long encoded_page) { return !!(encoded_page & PAGE_FRAG_CACHE_PFMEMALLOC_BIT); } static unsigned long encoded_page_decode_order(unsigned long encoded_page) { return encoded_page & PAGE_FRAG_CACHE_ORDER_MASK; } static void *encoded_page_decode_virt(unsigned long encoded_page) { return (void *)(encoded_page & PAGE_MASK); } static struct page *encoded_page_decode_page(unsigned long encoded_page) { return virt_to_page((void *)encoded_page); }