From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC580C43334 for ; Wed, 15 Jun 2022 05:02:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71CC56B0071; Wed, 15 Jun 2022 01:02:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CBE96B0072; Wed, 15 Jun 2022 01:02:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5937A6B0073; Wed, 15 Jun 2022 01:02:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4A1926B0071 for ; Wed, 15 Jun 2022 01:02:37 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 280E261430 for ; Wed, 15 Jun 2022 05:02:37 +0000 (UTC) X-FDA: 79579274754.19.ED9673D Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf07.hostedemail.com (Postfix) with ESMTP id 371C340079 for ; Wed, 15 Jun 2022 05:02:36 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5D00C175A; Tue, 14 Jun 2022 22:02:35 -0700 (PDT) Received: from [10.163.41.27] (unknown [10.163.41.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B80373F66F; Tue, 14 Jun 2022 22:02:32 -0700 (PDT) Message-ID: <7c363619-4159-8a21-d55a-535e21b5c8b4@arm.com> Date: Wed, 15 Jun 2022 10:32:30 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] mm/shmem.c: use helper transhuge_vma_enabled() Content-Language: en-US To: Hugh Dickins , Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220611022314.21593-1-linmiaohe@huawei.com> <8b34a515-e5fd-731a-4164-9080c275d4e9@google.com> From: Anshuman Khandual In-Reply-To: <8b34a515-e5fd-731a-4164-9080c275d4e9@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655269356; a=rsa-sha256; cv=none; b=d5t1EnfwWX6Js6QZ0PeBEvWsGNv2cCsGvl7WRJcM7f0yfugLmJ/McFmeG2B439l2/qBOq5 2LmcL6CdseIBtX2ws7nXtNcdshUWX/9sgz9JeQjokFaw0Kk3zdfnbVMHgM165wOtKft6xk tFQULS+6gwv4zQveCm51qWTjPwTTIGE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655269356; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9OytnPPbcOY/CmOnd6DH44zk2HMLwxqVQ1fL67N9SXw=; b=B0D1GdJZsmiAluO0zHas5oIj0ttJWmV+V8Ol3UVwze6RQrLAU3HyzDilB2f5RrRBCIRZo5 X/PjIyZl9MuOK5TsCA4oUciR/MbQD7+eoURsF2m5mHsxZFbGcS7Cvc8HNKPTG+GjlHEcMJ Rx3vg/duCXFxlxN6RxoTsyLMugrWufE= X-Stat-Signature: i6dh4f1agdu5kz9at1rkuu3pxzoru7sh X-Rspamd-Queue-Id: 371C340079 Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1655269356-301844 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/11/22 08:44, Hugh Dickins wrote: > On Sat, 11 Jun 2022, Miaohe Lin wrote: > >> Use helper transhuge_vma_enabled() to check whether transhuge is enable >> on vma. Minor readability improvement. >> >> Signed-off-by: Miaohe Lin > > No thanks, that's a readability regression, forcing reader > to go and look up what transhuge_vma_enabled() actually means. > > What you call a helper, I call an obfuscator - as I implied in > b9e2faaf6fa0 ("huge tmpfs: revert shmem's use of transhuge_vma_enabled()") The same reasoning should also be applicable for other calls sites for transhuge_vma_enabled(). Should not they be dropped as well ? > > Hugh > >> --- >> mm/shmem.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/mm/shmem.c b/mm/shmem.c >> index 133c67057d41..59cc2e980c95 100644 >> --- a/mm/shmem.c >> +++ b/mm/shmem.c >> @@ -480,8 +480,7 @@ bool shmem_is_huge(struct vm_area_struct *vma, >> return false; >> if (shmem_huge == SHMEM_HUGE_DENY) >> return false; >> - if (vma && ((vma->vm_flags & VM_NOHUGEPAGE) || >> - test_bit(MMF_DISABLE_THP, &vma->vm_mm->flags))) >> + if (vma && !transhuge_vma_enabled(vma, vma->vm_flags)) >> return false; >> if (shmem_huge == SHMEM_HUGE_FORCE) >> return true; >> -- >> 2.23.0 >