From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86BB9C36008 for ; Wed, 26 Mar 2025 09:34:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 304EA280071; Wed, 26 Mar 2025 05:34:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B44A280069; Wed, 26 Mar 2025 05:34:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 17E9D280071; Wed, 26 Mar 2025 05:34:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EF917280069 for ; Wed, 26 Mar 2025 05:34:25 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3B349C1F54 for ; Wed, 26 Mar 2025 09:34:26 +0000 (UTC) X-FDA: 83263191732.17.AEF4568 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) by imf06.hostedemail.com (Postfix) with ESMTP id ADE65180005 for ; Wed, 26 Mar 2025 09:34:22 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=uNVAsDJc; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf06.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742981664; a=rsa-sha256; cv=none; b=Xbgjf7L0hqibPqFBZFnQR//4gBl9zxIji73Ck3jV0T+relQK8KokB1/jt8ZpjSYAclrwpl 25nVMunzBrpYr/kLdutO4yxW2m3ET46eMQx7MTEEQW2PAngEoyAs7o1FXd/WsdV9h/vOT4 62E4hdxXayRHqd45tV/SCccCOcU4eBo= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=uNVAsDJc; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf06.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742981664; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wr6tnvD8lFLw5Hhe4KOCwyG97x90AeveFDRL5dwX+XA=; b=dZ6a6Nig1MyWy351bepq0dBbIeRAk8FfoVDVuzGKXkN5fpk2ykLXjzp9jXq04b1JbuLio+ lW2bx3RLatlwfHUy4AZtP7qYbj5gl7pct8zwrdgkIDSAoZcfO1Wtau5Jjw6GVCv9U6TXdc i4HdLYiVCRsCnMHTYDGS08OePyTLOyU= Message-ID: <7c278ba6-c1a2-4ef7-a4ac-48c233dce7a3@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1742981657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wr6tnvD8lFLw5Hhe4KOCwyG97x90AeveFDRL5dwX+XA=; b=uNVAsDJcZaCcBUTgirGJJBspvcP0Ni2j7Gv7hYYGAKHK6/RwHtH74SFnnjE0+1DDVZwY++ JcKlTG0lvs+lKK6f2fkCFrJ/CX7g0ODceEkrCXO84B2H+ELP0nlbXINTcTc/zqUi5Z2JHB 9TO7g8yp+a+kwyVWDLmnOkLBq8G2DQE= Date: Wed, 26 Mar 2025 17:34:14 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v3] mm/page_alloc: Consolidate unlikely handling in page_expected_state To: Markus Elfring , Ye Liu , linux-mm@kvack.org Cc: LKML , Andrew Morton , Anshuman Khandual , Sidhartha Kumar References: <20250326011752.917564-1-ye.liu@linux.dev> <0ceb4ab8-adb5-46bf-98e4-61a1bd908e20@web.de> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Ye Liu In-Reply-To: <0ceb4ab8-adb5-46bf-98e4-61a1bd908e20@web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: ADE65180005 X-Stat-Signature: r687ydt5mcxpgne8kqn8nh5cd5ux873o X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1742981662-20600 X-HE-Meta: U2FsdGVkX19IHxklX49v9oi7JdXyFyIkJz6/OpOz2ogl0DSl2NCeBa7Cx0Hm8taUbVQbOuZIX6zuwY3ZpF7aM/hdmNDxMt2+Et0rJe1Vk/KekvpD3h0+B7/AYiA+qNRjMdCXSogkj6QjdHDOIivHtBt8UqLOUOuDyEqDaFH7Fz0OsGvzYibev67mA/fii6gBzZcX91ggxfTJBCiXKWlTXWMp68+C6apjhVCaO/GkHBOFW8OdYATgvY4SoGR8wmv/lvTrCZ+c/+6c5LL0O29QqRYxAjEncSDk/fijZhlQsSjFHpwAwGQdG3eokY9WKIkii7qskzZletVx2nEdUF4uiwTe6ZaFPrWEpdkkCbL/C2Rj3c4QhEb/VZwAbt5c+nP0bTARNRYTXVRjOblxHIK3AHs1Ewby0Lb1tM5w8x6PvA2YWiZctf7WxvI3qGgNn2XpkWRXv5veWZVfubVJ410f4zQnXOthR+BwVu/tIiRxYYxiaxVslZXS5KnxNowPjz1YDsb+6El41RgLe02WTrCSxnPpLtpJ0GkhujlHwLbqBzUraXvVSd4R90ZHhF4zkLpvbvZE3VZdoe5C+Gubeoi/ZNFl6wbYHegFsdjEzbN4OuixxP3tgzbbWakEr31/H7Syv9lYa8yMvLIQbK7lv8MUy9OUhEnPQn3hQh/5C6FF8P0Xb2X9qLNdUEHbxq9/YFrRPgYI1dAcoijmrbFWbSPxmqTfT9PVK9XugpF9L237qp+B1Qo2jMcsmkGHoHWTsHc2wugkWnmJsUXBUE6/vlP34znOMHuKbRFoLwjJGxcD9Nxt88msNpW2Ys7VqB/DKErkwQme8xr2tJkiK6Zjcs/McQCOImYNeuE8T9QVPk4m33lHzunaJrHwLn9QysSj+yo6VzQIkYpouXjXCCsbeI6FMSgyVCRrPWxbbqsB3t/ULuCMAuPoQKghEVlagZIu1DbC0sF1VjVl2n9k3N/iktW 9RQ2Bqz0 E+vPNwaLEkZ6h6T/tH6aDuzGIDQbuMmdn3s2SyX/WcGRjUz2bBnNt0WAmlfRDMx16YERigcJkw6FqE+hVMr1hB8Oel4QqiEN/9AAP0Wtc0SGHNlX4aH8anvzCWB1v3fjHTkIrsVK+vggQ+T2l21QJ8cz5A6WVA2aPUiqw9pOb+5qiepvt4nFjEfXHq8uuNBSykjQ9lavET4IqSw1bbHe613fCFBjzGB+v9iSx2yGghqeu4DXTpb6iCgvuiG6M6I5KWVPlMP4tfzVb08IFc67xkQ6pcQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/3/26 16:48, Markus Elfring 写道: >> Consolidates the handling of > … >> This change simplifies > … >> --- >> V3: Delete 'This patch'. > How good does such information fit to the wording requirement “imperative mood”? > https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14#n94 How about this? Consolidate the handling of unlikely conditions in the page_expected_state function to reduce code duplication and improve readability. Move the logic for handling __PG_HWPOISON flags from the check_new_page_bad function to the page_expected_state function, and remove check_new_page_bad. Call bad_page directly from the check_new_page function if the page has unexpected flags.                                                                              Simplify the code by reducing the number of functions and centralizing the handling of unlikely conditions. > … >> --- >> --- >> mm/page_alloc.c | 24 ++++++++---------------- > How do you think about to omit redundant marker lines? --- delete this one？ --- mm/page_alloc.c | 24 ++++++++---------------- like this ? V2: return true instead of false in the PageHWPoison branch. ---  mm/page_alloc.c | 24 ++++++++---------------- Thanks for pointing out the formatting issue. I would like to get your approval on the above changes before I send patch v4. > Regards, > Markus