From: David Hildenbrand <david@redhat.com>
To: Zi Yan <ziy@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
Yang Shi <shy828301@gmail.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Barry Song <21cnbao@gmail.com>, Lance Yang <ioworker0@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] mm/rmap: do not add fully unmapped large folio to deferred split list
Date: Fri, 26 Apr 2024 10:26:03 +0200 [thread overview]
Message-ID: <7c233278-1006-4449-81b2-d473b18a66ca@redhat.com> (raw)
In-Reply-To: <ec4f9194-9ae3-43b3-8559-0b1f186c1d9d@redhat.com>
> @@ -1553,9 +1557,9 @@ static __always_inline void __folio_remove_rmap(struct folio *folio,
> * page of the folio is unmapped and at least one page
> * is still mapped.
> */
> - if (folio_test_large(folio) && folio_test_anon(folio))
> - if (level == RMAP_LEVEL_PTE || nr < nr_pmdmapped)
> - deferred_split_folio(folio);
> + if (folio_test_large(folio) && folio_test_anon(folio) &&
> + list_empty(&folio->_deferred_list) && partially_mapped)
> + deferred_split_folio(folio);
And now I realize that we can then even drop the folio_test_large(folio)
check here!
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-04-26 8:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 21:11 Zi Yan
2024-04-26 1:45 ` Barry Song
2024-04-26 1:55 ` Zi Yan
2024-04-26 2:23 ` Barry Song
2024-04-26 2:50 ` Zi Yan
2024-04-26 3:28 ` Barry Song
2024-04-26 3:36 ` Barry Song
2024-04-26 3:37 ` Zi Yan
2024-04-26 3:44 ` Barry Song
2024-04-26 3:45 ` Lance Yang
2024-04-26 5:36 ` Lance Yang
2024-04-26 8:19 ` David Hildenbrand
2024-04-26 8:26 ` David Hildenbrand [this message]
2024-04-26 9:33 ` Lance Yang
2024-04-26 18:41 ` Yang Shi
2024-04-26 9:46 ` Barry Song
2024-04-26 13:11 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c233278-1006-4449-81b2-d473b18a66ca@redhat.com \
--to=david@redhat.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ioworker0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=shy828301@gmail.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox