From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45C77C433F5 for ; Wed, 9 Mar 2022 17:15:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B21EE8D0003; Wed, 9 Mar 2022 12:15:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AD0A98D0001; Wed, 9 Mar 2022 12:15:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C02A8D0003; Wed, 9 Mar 2022 12:15:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 92FCD8D0001 for ; Wed, 9 Mar 2022 12:15:38 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 611B824C84 for ; Wed, 9 Mar 2022 17:15:38 +0000 (UTC) X-FDA: 79225499556.01.CC0BBB3 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf25.hostedemail.com (Postfix) with ESMTP id E7697A0015 for ; Wed, 9 Mar 2022 17:15:37 +0000 (UTC) Received: by mail-pl1-f171.google.com with SMTP id r12so2526657pla.1 for ; Wed, 09 Mar 2022 09:15:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=x1nQuY29Y8WhL6J/ZQu5YgDLTjawUkxAqLgbVJua3hY=; b=sW6xLDppPgAPFHE5BJhZvgdkYn+WY0Ji7Xmi9c2jOR3aekaQcdWza1bBOoxTKPJbx4 gDOSeRfJHfPlyPtj7QtPuZpGSH4w02ej9y+1xQcvW18a3w/N9SA+nGUJHGqfG9FT9eF9 b+4avAihGmhYWOUHYCRCMIMdvFUcaFrg2l6TOXgXBKnLiPBQEX1ZmG+Rv3OIz7RoU5Ln WJ6nlgKvmPWLatydS+0fok6yAP0je1KGuIYSHTImr9fRO0x1yMo82WDj9XbhXDipvk/6 KFbDLXNjvmkAEXlETavF0Sm1/pR1rw3WJWerbEohhaQMkJV6hNTztj1vJ7nJRIAYjgGR W4BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=x1nQuY29Y8WhL6J/ZQu5YgDLTjawUkxAqLgbVJua3hY=; b=RgdHQARD4nXDlGlN4l9+goQxFB89QY9Uha2ErvwgvkWWqVR0eCwkDbsooU8+TdEXA1 DVaVkaP6Fhp2yM/SN23xLlh4OOoc2epq/lz80gCz3Rwq281yh8ixnz7Z29IVaHoiy5MJ 9jHXpQuHJqSSKiWNRJ8cBQaXZ8hqUFEP1X9swoy2l32zDxJz/vO+/sina9vYhg8sa3N3 TJFNTjOWzvsUT1Dq6BDFXhecoU6jQko3S1GUKICV8cz9kWas9d77S/2EM4zwHnx+ySHj 3Y570qk2VQ3iHp139I06O80DRAR62D+Xq04qwQ4QdkyIdxM7K/dPMsmPY6IYkjpnkM++ +U1Q== X-Gm-Message-State: AOAM533u0d6jvqQE9Dh7IzMhigfy29aqkEmi/5FCLHyvS10w7AkaPkKE /akcZoE73V7XYdC3sV+IrnnRRg== X-Google-Smtp-Source: ABdhPJwxEOUetRQoNUGuPyf5nY5FxYlcAtJT5X0k/dNB2OOflWA0QnQ5xKw5OE8/vb7W0vyA7qq6Dg== X-Received: by 2002:a17:903:3112:b0:151:a940:1574 with SMTP id w18-20020a170903311200b00151a9401574mr660489plc.63.1646846136818; Wed, 09 Mar 2022 09:15:36 -0800 (PST) Received: from [2620:15c:29:204:b5b9:5c22:b3dd:17a2] ([2620:15c:29:204:b5b9:5c22:b3dd:17a2]) by smtp.gmail.com with ESMTPSA id y16-20020a056a00191000b004e155b2623bsm3934224pfi.178.2022.03.09.09.15.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 09:15:36 -0800 (PST) Date: Wed, 9 Mar 2022 09:15:35 -0800 (PST) From: David Rientjes To: Matthew Wilcox cc: sxwjean@me.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, longman@redhat.com, guro@fb.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiongwei Song Subject: Re: [PATCH 2/2] mm: slub: Delete useless parameter of alloc_slab_page() In-Reply-To: Message-ID: <7c116655-a4ce-5f61-2d98-e85c31e11184@google.com> References: <20220309145052.219138-1-sxwjean@me.com> <20220309145052.219138-3-sxwjean@me.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: 1j7dh5p7jpzejnns5duamn4kao8wfrno Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=sW6xLDpp; spf=pass (imf25.hostedemail.com: domain of rientjes@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Queue-Id: E7697A0015 X-HE-Tag: 1646846137-967865 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000037, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 9 Mar 2022, Matthew Wilcox wrote: > On Wed, Mar 09, 2022 at 10:50:52PM +0800, sxwjean@me.com wrote: > > From: Xiongwei Song > > > > The parameter @s is useless for alloc_slab_page(), let's delete it. > > Perhaps we could add a little more information here. > > It was added in 2014 by 5dfb41750992 ("sl[au]b: charge slabs to kmemcg > explicitly"). The need for it was removed in 2020 by 1f3147b49d75 > ("mm: slub: call account_slab_page() after slab page initialization"). > > Reviewed-by: Matthew Wilcox (Oracle) > Acked-by: David Rientjes