From: David Rientjes <rientjes@google.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: sxwjean@me.com, cl@linux.com, penberg@kernel.org,
iamjoonsoo.kim@lge.com, akpm@linux-foundation.org,
vbabka@suse.cz, longman@redhat.com, guro@fb.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Xiongwei Song <sxwjean@gmail.com>
Subject: Re: [PATCH 2/2] mm: slub: Delete useless parameter of alloc_slab_page()
Date: Wed, 9 Mar 2022 09:15:35 -0800 (PST) [thread overview]
Message-ID: <7c116655-a4ce-5f61-2d98-e85c31e11184@google.com> (raw)
In-Reply-To: <YijHr+kkp2bPE1dA@casper.infradead.org>
On Wed, 9 Mar 2022, Matthew Wilcox wrote:
> On Wed, Mar 09, 2022 at 10:50:52PM +0800, sxwjean@me.com wrote:
> > From: Xiongwei Song <sxwjean@gmail.com>
> >
> > The parameter @s is useless for alloc_slab_page(), let's delete it.
>
> Perhaps we could add a little more information here.
>
> It was added in 2014 by 5dfb41750992 ("sl[au]b: charge slabs to kmemcg
> explicitly"). The need for it was removed in 2020 by 1f3147b49d75
> ("mm: slub: call account_slab_page() after slab page initialization").
>
> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
>
Acked-by: David Rientjes <rientjes@google.com>
next prev parent reply other threads:[~2022-03-09 17:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 14:50 [PATCH 0/2] Cleanups for slab sxwjean
2022-03-09 14:50 ` [PATCH 1/2] mm: slab: Delete unused SLAB_DEACTIVATED flag sxwjean
2022-03-09 17:14 ` David Rientjes
2022-03-10 1:18 ` Xiongwei Song
2022-03-10 1:49 ` Roman Gushchin
2022-03-09 14:50 ` [PATCH 2/2] mm: slub: Delete useless parameter of alloc_slab_page() sxwjean
2022-03-09 15:28 ` Matthew Wilcox
2022-03-09 17:15 ` David Rientjes [this message]
2022-03-10 1:18 ` Xiongwei Song
2022-03-10 1:17 ` Xiongwei Song
2022-03-10 1:48 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c116655-a4ce-5f61-2d98-e85c31e11184@google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=guro@fb.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=penberg@kernel.org \
--cc=sxwjean@gmail.com \
--cc=sxwjean@me.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox