From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB231C48BF8 for ; Thu, 22 Feb 2024 19:12:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5485E6B0083; Thu, 22 Feb 2024 14:12:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F8616B0085; Thu, 22 Feb 2024 14:12:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C0956B0087; Thu, 22 Feb 2024 14:12:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2C3126B0083 for ; Thu, 22 Feb 2024 14:12:07 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0481C120EA1 for ; Thu, 22 Feb 2024 19:12:06 +0000 (UTC) X-FDA: 81820385094.16.49DB939 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf12.hostedemail.com (Postfix) with ESMTP id CDC3440012 for ; Thu, 22 Feb 2024 19:12:04 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="UuFDFpx/"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708629125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0Qks+DDhYCmzTTbFrd2ThMT4amH+aqvX5uPDsqGmmfM=; b=ATy9UUvwHplDthJ7utNdupXqduquMIjLcBmXYYOvZ8hU9I/1ak0rgupnXfOvnuGClA0i40 pmms3Z81F6WlYst8hVS2Ux0G8bO7WDLzpgPQPNYSimDyieGa5q4M9JIKGqQdUTxJk4qq1q 9k5fqJKnwszTxVaXqtebp7DPcJ3gvmk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="UuFDFpx/"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708629125; a=rsa-sha256; cv=none; b=KOVZzkWGMvihxmoPrBkawy+CIcPIb6loRsugSE+SGdoH0frlyHeN8gmCWQELq5ItDdZFDo Ckcsq+imac4qgJh9cdr0eMBhVqJDzbwZJy5VDtqb4GUNjWeT+WN6OcXP2KZYNN5ROpgRMo AawRThMIq1A3ZkQ19sIoGsQuOAr+CdA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708629124; x=1740165124; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=0Qks+DDhYCmzTTbFrd2ThMT4amH+aqvX5uPDsqGmmfM=; b=UuFDFpx/zfej6bKB1Xms9AXicfDRfwmckVwYBEXmdxbpYyyJUCVMRYVL KyQ0kIUGoK3eLmQ2xYY7LFSX5Zq4Hgd0MeT9QtY0oKp42k1zCxkTxuqAk aeqTGAdQX1wOu8A9Hi/uLdaiyFV2XSs0CfLJgz2EkaoGTr+9w5s+n2F3u a4MpCP5PTb4W/iUKMO+zp58rkNMeKLGzzd0dyqvGgiss5PQpqtjbiiuyk XL9loAtXlPPCPUvGgtb15ObsnH64sOQAlClFOOAXiQBfMD+5t/6IWDDIP r7V+5jrkFhrYCjzaHabI1wk91sT54aoMLWjETmC9/xmbs7BLByx9/Zjdt Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="13507561" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="13507561" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 11:12:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="10175034" Received: from jwbates1-mobl.amr.corp.intel.com (HELO [10.209.48.22]) ([10.209.48.22]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 11:12:02 -0800 Message-ID: <7c0b97b7-48c0-4f8e-829a-8e237808d47f@intel.com> Date: Thu, 22 Feb 2024 11:12:02 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-stable 2/2] x86/mm: always pass NULL as the first argument of switch_mm_irqs_off() Content-Language: en-US To: Yosry Ahmed , Andrew Morton Cc: Ingo Molnar , Thomas Gleixner , Borislav Petkov , Dave Hansen , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240222190911.1903054-1-yosryahmed@google.com> <20240222190911.1903054-2-yosryahmed@google.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240222190911.1903054-2-yosryahmed@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CDC3440012 X-Stat-Signature: zbbp7uad5ucce18xif5pirgtnmpg1whq X-HE-Tag: 1708629124-908902 X-HE-Meta: U2FsdGVkX1/7gsE/++yyO47Y5Hsv5apkb4WoBuxkc7Fq4J77Fg0P92frC+mT3ZUlwIO6i+2rX0UNDYnQ7R6C0d/5nwWPSNVWarHMSiEL3P4K7ktRP2tVW2wEjxuzDUXtWMuX8VchRummX61cpoM9aIlhBfzt3wjY1ECB3EBE1Rc4UO3nwHY8GGKiRjDJ+uG9Lsro5ZXOn94dpDKjdOpxXXbniNrbWgmDPGpdQ1ddaAUc++dqtQOuen47uaqGPAUKfUJMkzjReBMeXkSR3MzkoHnczYlQQBmwPwuBRDx1PUJpD2GWgnbkNeDEtSEJ8AyMzRNB2UcLst0IC6lhCpZNRJ3u4D9XN2JrdfKofqJ/1+CEL0+BhjR6HaGsNELPiF41Kbkgn23664/Nc/lJfXxlLg5COPPDsb6lFV59WI3jon0hPs8KcGSJ1U563c5qbQCF/YqLS/iKb4auH7iR7+agLfAWRzKAWb0YG+X5vZq0atgF6ZmAo0wwIDB4rdD46+Ff2SyG7OtfRj2q5gdJjq9l+7AMnahCh8tIHCnjhFAYSKF/5SCyUZNpfyf9KE8KM7Ilq99e/I4gkTrcO7tNZ7jPveDmDCqKmAHLy0U7LptzqrjiTNUvLzeoyezPCRhioiyyX8u15ZavnILYBd06/JaoBhm3OsYLxKE+4xMct4jJgf/oEfUaobs0Xpcq0bgumjKJOFzdwgV4NoO7g1efT9gKG+xgD6dxA84neFbsTPGRwkqDM1S/ogB9wEVz7BQ5eDbR41ACxWh83tecuIFlXQMDuE01Rrlw234+5YgOaLkt5Yf8KoeWEbvFPwICzamL3iUHFZ4EL1nAhwo1Q3sE4lIQ/XyJll4mKnXp315o7x+N12+X3wun1oY3tPafOlfSvnGQDqslJx7lducEmR95AkgsQwY9XlJgOgWDUVmJ/Xw1PRxTcoVaDUI3rr2HbSVQtf9nltGks39m++g9SFUWkCt 1/lx9lVn rknXeMAuwTMBxmzEPes7dLB373eF2HB2/gMDm0kteXtiG64Gndmy3FhxmhpMS1WZ/JWyC9ruueBIiLRSob1AlSmtu4M9ujB2+aH3CbQE9IWxnisMAvKFgq7oUD3OEg/6CJgq1djh8VbkbRm4tzDW4qHBHIDgPVJ200ZznNVaajMbsPVq7yjGtgNALvLZ8aQapXxT/H4+86nuEIM3jYqGGPv72K63ZeZ+7A6C1CIQIzfXgBmAU6IDvnyBsFHBRsEMkeIJbhVyxOCczflAv1sXLxPz2Pw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/22/24 11:09, Yosry Ahmed wrote: > The first argument of switch_mm_irqs_off() is unused by the x86 > implementation. Make sure that x86 code never passes a non-NULL value to > make this clear. Update the only non violating caller, switch_mm(). Acked-by: Dave Hansen