From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44B57C369C2 for ; Tue, 22 Apr 2025 07:04:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64A1C6B0011; Tue, 22 Apr 2025 03:04:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F9C16B0012; Tue, 22 Apr 2025 03:04:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44A846B0022; Tue, 22 Apr 2025 03:04:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 237066B0011 for ; Tue, 22 Apr 2025 03:04:47 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0E089140D90 for ; Tue, 22 Apr 2025 07:04:47 +0000 (UTC) X-FDA: 83360792214.13.4C333D2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id A6127140003 for ; Tue, 22 Apr 2025 07:04:44 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aZ0ygVp5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745305484; a=rsa-sha256; cv=none; b=UA1VSx3VU+61D1R/bz9F/AuRVRyU1zpPw4KWdNR6AQQA/uiBxXNTEOpXO4jIsKD90l51m9 przgDMqgWI8g+sPjACBeHh0yTP6oLq/5Z6rDKD2tcb4sQnFrs0tdPldKbAnRVcZCLEyFwU IR+f03BqnYyRf7ySxVh0+28RDxbwEFc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aZ0ygVp5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745305484; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RidtXoQ8utHmq+/JiDpAnUhpjg1f8nks6IGSAa7gnq4=; b=h9dQNT/duaZdSTnCPA3PGa4et9UOdR8yknULpgn7VbpN4LW/85M3ZaG95YfQCYXva51/li mUBNKHwJE+aTQlFi8Qz2daFG5zvf2Kx5Tj3qHEj/AaU3jaUbNahLRBAlVGHC6ER7YxfqST pj60V/6dnOsiQ44eSuOtJmA1ANDEswI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745305484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RidtXoQ8utHmq+/JiDpAnUhpjg1f8nks6IGSAa7gnq4=; b=aZ0ygVp5NJswNyjzcn8oGD74F6r76DSD2vy0RNo+TBIZftRNxR7pcqrqWzHRMmuLPXFdhz I2mgeMpo1lcRU2vK1unxOyF5vzwajERlslkVzQRiDGavyygNE8fquZJUxIuGU42hLtA7WQ soaHeg8OG38t35DcwrO5Zlu0+WmL4Ag= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-WMowyT_SMTumEvVjjkcLaA-1; Tue, 22 Apr 2025 03:04:42 -0400 X-MC-Unique: WMowyT_SMTumEvVjjkcLaA-1 X-Mimecast-MFC-AGG-ID: WMowyT_SMTumEvVjjkcLaA_1745305481 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43efa869b19so28808885e9.2 for ; Tue, 22 Apr 2025 00:04:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745305481; x=1745910281; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RidtXoQ8utHmq+/JiDpAnUhpjg1f8nks6IGSAa7gnq4=; b=rD0Cn6eWlumCF8Lb0JPBkTCwhSWoszi0Nc6FEJVGhO66mgWHDFHp6AuFe+NLzD1Hmw zEz/hVu150dwJ546Sx2nFlG0V/zHVpbmxrDP4OkmUX9ilbKYmwMx/cAPR1Ad/7+/sgTN aW7RRVv79vFQ7DFHFosNTtPKYUYN5dt44hM9hZRt1+8C8+cJ6ySTlFvXDq2CoyVFNZuR +LnoIEevLGB3rpYo37Ul6motn+5o05gA22kqkT3Z2OotMWdRGntdpPe7R/Zy1QwALAGx LKOb3ccmqK/kij9GrOHAA4xaspzV3zXgvEyqbEwpXkaw6K70MX7XuzadRtzIU1L6NCdN G+pw== X-Forwarded-Encrypted: i=1; AJvYcCW6z+LZNvmWlyB8Iv9WeJpa8UxVFeBn9ggpCLOPWL3QUB7k9bPJjopDiaBoADeMLTiFFjwVplo8Gw==@kvack.org X-Gm-Message-State: AOJu0YzkJmhxj4gUBSxPLZo6/5U4yuQZSpLMru7QY9bb6WdoWGd7WREf PLjxOrpqyJCWA0iec0D833yxduin2T+V95XnP936Bea2eGHhqqhRO1dTc04G0T6WqINu7RKky7u 4TuwtHjZtUkPemHVXe3j5D62qnmUdHSLlK4wJu81UhxhA7KK/ X-Gm-Gg: ASbGncuOIc6WFL4Q3R6HLmXEKEQnF284YRWILDUb0LSRq920v5uIUQ9OvojXWPqo9Ts w2UCyNvbTSYDD1cZVEpxA2cugsE16GrEKemeSvzxaOWd535WZ+TlwcwbpTp2QuKXcGLcFdMoWqQ 3QMJbHOJnjVG/N+lD87zVyCKprR0Ufsr/EbzYkPMx+nFOqVQt9FfHCSCJlbGkCRgQYKckcyW140 XHDFB67vLvIq9Gitkz8R4RoihIjfoGDsOlOIr5/68XpeUre/iKVSk3f+pRp6cpbkTfBj78CaL1w 0C+M6K8Is/Ph4hg/Mo6za0S2T55bl5/XdxawpAPZxc51wP0HIiwUrhoIpbg+aBzXXYt0FKorCPC rnlTA0bBck/9sSBer5zzzh+zwkcNHZwcg6TmG X-Received: by 2002:a05:600c:54c2:b0:43c:fc0c:7f33 with SMTP id 5b1f17b1804b1-4406b92b57emr98154405e9.2.1745305481134; Tue, 22 Apr 2025 00:04:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHgWBX/11P+U8H33SSNxBptWM+XbQuz66XnLNKZuRxp5LsWM8rUt1vY1NxeviT6YKW0WfkWQg== X-Received: by 2002:a05:600c:54c2:b0:43c:fc0c:7f33 with SMTP id 5b1f17b1804b1-4406b92b57emr98154055e9.2.1745305480787; Tue, 22 Apr 2025 00:04:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c731:8700:3969:7786:322:9641? (p200300cbc73187003969778603229641.dip0.t-ipconnect.de. [2003:cb:c731:8700:3969:7786:322:9641]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4408c8b0ea0sm5846715e9.2.2025.04.22.00.04.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Apr 2025 00:04:40 -0700 (PDT) Message-ID: <7bf68ddd-7204-4a8c-b7df-03ecb6aa2ad2@redhat.com> Date: Tue, 22 Apr 2025 09:04:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Please apply d2155fe54ddb to 5.10 and 5.4 To: Qingfang Deng , Greg Kroah-Hartman Cc: Sasha Levin , stable@vger.kernel.org, linux-mm@kvack.org, Zi Yan , Johannes Weiner , Brendan Jackman , Michal Hocko , Suren Baghdasaryan , Vlastimil Babka , Andrew Morton , Liu Xiang References: <2025042251-energize-preorder-31cd@gregkh> <2025042237-express-coconut-592c@gregkh> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pGEUK7sZs7d0UlGXVFwxDjiZVevBmuaphofNcV584x4_1745305481 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A6127140003 X-Stat-Signature: sybq6hgidiyc4oo4kpdhshzjjiogdjdu X-Rspam-User: X-HE-Tag: 1745305484-185727 X-HE-Meta: U2FsdGVkX1/AtTeFppZ7bf9PoHW6kr4k5Jlm+yILAMiH/6VO8L6BbtA730foTlGzgJGmBTCJTJr8GhgEi/thcGagw7F4dagpXf0ph4NRzzbLFEcp9YcpYqBCHgcyRu9t8HrpMSQHmPyz4uSz3jqJIpQnP961kyHDvZaodOWN7SatD4huIhbO/wkZ/IRRkyk609F9BqtNPKfs445HwObvWtuPI7iF2pwaoIjd3YNxSDdckxw3MlAJLK5twC9V0sZ4J/cXwL7KR0OZTlQvbHJHicCbT4evqUUuBgdtWs9rVbMi3AtUbMICKhLOxRBVqtMFliCWifHnCbtbk0lJGKN/d0gi2ePMBQq2A8m48lLfYLm9+FHfNGHGvWSWMJEKB8xKt1FWvyC2V1P6PuF+TzKJHRIavqwzX8UhX1vGGz3MSeU336uF67nvWjEXG4M7cm3iL91ZCiBhnZQ/Bf5Z4Cei2LuMGXl8VOUCpnu0NTvlelsgBhy521mHq8KYllTwrpV4Xb0S1S+yDT+t/gu+Ef/lApgWqRywRPUOpHdsNUXDA1eyWyI9cyT261BnC7IdB2GvNiMuywuM9YwIy7wxgGPoPyjaYyUCB9bqZQR+0mbgf5b5h0N7cr8bhf/TOcntdlSKMlzlhbmauOoZLGdrDqqZhnmRub22o21MYGUjo4v6zjb4li0f7pdHUK4fCnIgH+ZQl/QN72VFL2IIQ0V1NU4NSjg5KWd+YI1l3Gx0k/KtuiOhDu8akWUuaId92/A9Wz6C1DmwBMCgk5j/HympXbEDZETMpeekDyomb0ym0D8dqBLVjlD/Xm0SIiVX7nklyg9md50OjnN1AZk0SkeWsx5MpW6wdhNbFhz9enQBepskxzVRrcniRVW5PWhfulqVnAj4NHugA6JdVenjGOTpDqm18ghynOmPyq/seNk9fdTwKqdipkVcianfQXwEitEwKNGzYu6dK5+SBoOsncGTPTU BTjZ+9i4 YV5IVAlSC8O3B5Whq8Fk/xCaz+XPpbXbFqFTGViDJ5YN5RFCC7rdr7lvJavetAQ+eq3PqGigzUhcH9oxCbe/z1n2i+IK2cP7e5IfAEVLDsUBDVVLKGgMCIgm60gpvouqPJg+rLgTLs2qff+3pNgVNuQ//iJM2UOaOqf3FoOkyL3c8NDb0/gug1g2FFqooV+UqmQ221VsSb/LjoQwtf2ku4ku64Zh8txDrXQJ4dURhR5rzazs3y6dK5yF34k7nbXbin9VEKp2Bf3tdMKoGDa6oYb1UNNrXtbg08S+ixUC7VKIbsPBeTaBf1KHDo6OtJ7JJk9f5qsJkEJERS+rCXvLWRNYmGHz5AwPe3dGyEkT1mNxhsARNeThl+pgri3KRB0UY410FA4l04fqw2CJIewIPuIEDpMf78KJBvP0OXfa/PslWpwufbo5sGehsjQf2CJQyPyGCXlqcY30iISAs1UqFLJsL2RQFtbLwY/IT8BRn8jJPDGc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.04.25 08:34, Qingfang Deng wrote: > On Tue, Apr 22, 2025 at 2:27 PM Greg Kroah-Hartman > wrote: >> On Tue, Apr 22, 2025 at 02:10:53PM +0800, Qingfang Deng wrote: >>> On Tue, Apr 22, 2025 at 2:06 PM Greg Kroah-Hartman >>> wrote: >>>> All mm patches MUST get approval from the mm maintainers/developers >>>> before we can apply them to stable kernels. >>>> >>>> Can you please do that here? >>> >>> Sure. Added to Cc list. >> >> They have no context here at all :( > > Let me post it again: > > Please consider applying d2155fe54ddb ("mm: compaction: remove > duplicate !list_empty(&sublist) check") to 5.10 and 5.4, as it > resolves a -Wdangling-pointer warning in recent GCC versions: > > In function '__list_cut_position', > inlined from 'list_cut_position' at ./include/linux/list.h:400:3, > inlined from 'move_freelist_tail' at mm/compaction.c:1241:3: > ./include/linux/list.h:370:21: warning: storing the address of local > variable 'sublist' in '*&freepage_6(D)->D.15621.D.15566.lru.next' > [-Wdangling-pointer=] The commit looks harmless. But I don't see how it could fix any warning? I mean, we replace two !list_empty() checks by a single one ... and the warning is about list_cut_position() ? -- Cheers, David / dhildenb