From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DB14C7EE2F for ; Mon, 12 Jun 2023 16:27:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD7756B0074; Mon, 12 Jun 2023 12:27:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B62056B0075; Mon, 12 Jun 2023 12:27:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DA9C8E0002; Mon, 12 Jun 2023 12:27:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8A62F6B0074 for ; Mon, 12 Jun 2023 12:27:05 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5B5B11202DE for ; Mon, 12 Jun 2023 16:27:05 +0000 (UTC) X-FDA: 80894625210.07.745E888 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf30.hostedemail.com (Postfix) with ESMTP id 0FF0080020 for ; Mon, 12 Jun 2023 16:27:01 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AO+L8aK2; spf=pass (imf30.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686587222; a=rsa-sha256; cv=none; b=kkXDJ/w08copYK0F5+Ngw8sbCZGTrjfIzBYuli1SkeHJiyEBPy+g3tzRX/+5Huj1YYmroG 43Jp8mOTy3KvxEewRFPmlFzJylgDyCuo/T970P1gFsaK015sY6uxrrDyRrYSpcP3K8/8hN C+bkflcNTj3PekfnB1IxXOxEz2oDz4k= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AO+L8aK2; spf=pass (imf30.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.115 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686587222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dvoNRNyXH2LUp57kkmgN9yytx5K5bZW5vd/ok4CJv4M=; b=fpanemx8k2LcO46ZM/zfkqaq/6SE5kjJEu9v62lO1N0UKsOQ+Vrj/oIdFuG5/zq75nLr9v GAOP7tYoXOhVLVUk1+TfQgtJ9OueQCz8cmf62CmsT+iZnd8uluqv5SiiUs3l2u1mBRKrG4 fqcaMig96JVpAZQQg+n9CAK8aWNQSJY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686587222; x=1718123222; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Uat8NMUncmqciNyRT9NRmiG7E1sO/Fvnt3OOx8fsnxw=; b=AO+L8aK2+8G9QXQAf+tzkMR0DhzTfDmS+UpJjRvTTsyQaEvQZ5dIqyDf R6KKXp556PSTAQlbmEwzEmUZTJGmwLCjvb5udoFJgn67p4X1pqSBg0SZy cTqT64mCkhnrqxAx70h1P/iPSzCt8amSD75g6N1qJCj+l4tV45tAzlbsq 8XOgnrBfR60NSGOvEzUoqb9Wzl/UOiigCH1hax2STqTEj0lMysiZtoDFd mBGthPwg4f+w0L8CwuGv44J1/w6W14ewq8aeL4N2d1Y3llFUDY20aCkXB v8csrBf9AzCTYJMzlBZsiO1IEF+UG8YxZGMw2xgiGhVtmSdwBcLy4/+NN Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="358089508" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="358089508" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 09:26:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="661638856" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="661638856" Received: from spmantha-mobl1.amr.corp.intel.com (HELO [10.209.43.2]) ([10.209.43.2]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 09:26:58 -0700 Message-ID: <7bf4b9a6-d75b-8e96-14cf-79df2fae8694@intel.com> Date: Mon, 12 Jun 2023 09:26:58 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH RFC v9 11/51] x86/traps: Define RMP violation #PF error code Content-Language: en-US To: Michael Roth , kvm@vger.kernel.org Cc: linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh References: <20230612042559.375660-1-michael.roth@amd.com> <20230612042559.375660-12-michael.roth@amd.com> From: Dave Hansen In-Reply-To: <20230612042559.375660-12-michael.roth@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0FF0080020 X-Stat-Signature: uk8ay39fkum7dfeyaickkmoqrpzo58q4 X-Rspam-User: X-HE-Tag: 1686587221-94607 X-HE-Meta: U2FsdGVkX197JgfjMODXk9s7IVpAbMpYcesJlGx7iKNU+uiqVR7utacgrbm0VLmfke/P6k+/sefAOIsxtXQgUZ42EbWrPjZGmQ0gZ3Tq1KS/+7Z44cpxFp80JjCdEhfWbTDhHe7i+HMijRD7N3ptVVpXwnjYL5sy9YuAk1AONBIAiVsiYBWUfH5Vt7DxtO6MJ1u1UPY0YDVbn3NzD0tvIfvXXsIQwziNQrDuV5chDyiBHZORQJdZQ93SX/ZBpCL5mwv6PMlBA4vA9yXjuhKO8MPrrZ26z5Ewc80TtgQM0Jsbq5zVWNWZvUNVyUcid2strhh2HgmqVtCNtCykquCu6bVeUTYEnc/B24yKfgEM8ElRY45VB4A+ducqDSzw26v3ZDiBfJkxJiXkJJI4ZBn0xDVNkYtKqJ1kVX2qIJ6VFjvmIALv3OcHMHGj93DVL5IW4/AmrYLUpalL6j2suLKdV2h3BIz3TN2roOcGR/vuyTvQirnuEK0bInVqbmM59q3FWRvdkBUMjcmhGLzxY3AnwQTmaJKdPFtTjNFbmMJQ633qiSNN2JsVzS136DBmNiTUQO+9diS1t3UIKEOibShSOoatTsgyj02FkQj74MlDZfHVCTj4c/e4ffzWABQzWfb5Yw5gNmz6F6SSWSM/TJyotfZ7kBZ7BWw1S8NpxR3AOei8o2fQ3jZn+a4smZ7jsZ7UYaFmvkMno2hxVdjbOv+2p08lwu6sHALf5x5B7QpotkXMv32Wx2JKQnyf13UhonmZXPFwTbsbgYy1MZSKkkrJkYta6DmG68VKn3b6SlYJQA0CYI7iLjAr3QAYMhRD0Mov4Ft844gZbOUCBOgTvtVW4vK99TeJUNt4OgmXz7Lk66b0lAjU2GWfWbeSJ2J1HpVmb458UJTHUARHIr1E86mHUAM8KDNaPkYcwrXnjwuJX5B+sVzDDm+iBMtgO7kZJ4nTcpZZTp6/n8qWQ7jZeWh vdAKhB0W rJcCUVLJy8HORJKWP3RpTL+g4GzhYORksZJ0gFSD+c2XxGEW2gtOPnyDHhxPLl1xpZIQymsSLGIrdf3cpNZ7L0gUVHZFXhoFa/0JBNPvZHn7+1Adx4IsMm5JmBa/5t7wbTlhAcI1LdbtpQ6n1x/ExcOLXb+jFd/dvL9dsdkG3K3g+K4PurGgdjdjBvbimA01PErOA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/11/23 21:25, Michael Roth wrote: > From: Brijesh Singh > > Bit 31 in the page fault-error bit will be set when processor encounters > an RMP violation. > > While at it, use the BIT_ULL() macro. ... > enum x86_pf_error_code { > - X86_PF_PROT = 1 << 0, > - X86_PF_WRITE = 1 << 1, > - X86_PF_USER = 1 << 2, > - X86_PF_RSVD = 1 << 3, > - X86_PF_INSTR = 1 << 4, > - X86_PF_PK = 1 << 5, > - X86_PF_SGX = 1 << 15, > + X86_PF_PROT = BIT(0), > + X86_PF_WRITE = BIT(1), > + X86_PF_USER = BIT(2), > + X86_PF_RSVD = BIT(3), > + X86_PF_INSTR = BIT(4), > + X86_PF_PK = BIT(5), > + X86_PF_SGX = BIT(15), > + X86_PF_RMP = BIT(31), > }; It would be nice if the changelog "BIT_ULL()" matched the code "BIT()". :) With that fixed, Acked-by: Dave Hansen