From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33110EE4996 for ; Mon, 21 Aug 2023 13:58:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 802FB8D0002; Mon, 21 Aug 2023 09:58:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B2E86B0081; Mon, 21 Aug 2023 09:58:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62C3A8D0002; Mon, 21 Aug 2023 09:58:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4F25B6B0080 for ; Mon, 21 Aug 2023 09:58:02 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 104D2C049C for ; Mon, 21 Aug 2023 13:58:02 +0000 (UTC) X-FDA: 81148265604.05.AC2377E Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by imf03.hostedemail.com (Postfix) with ESMTP id 78C312001D for ; Mon, 21 Aug 2023 13:57:57 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=n2LwNA0+; spf=pass (imf03.hostedemail.com: domain of aleksander.lobakin@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=aleksander.lobakin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1692626278; a=rsa-sha256; cv=fail; b=YyQJ0EloYbzhkGmtgKUsdnl7DzVhcZ/Ppq17dxquwUSAYbJb0H7T3ec5LBcjn3qkAxypau RxBP63LLcz3w7hjDaruRT+2SjU9ALo/ZHlz4BanIls537rX/+03iJFjaxk5O8GTUqlmFhu Mjw211NWA7gYwvO8OYguC8dMyqfcqcc= ARC-Authentication-Results: i=2; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=n2LwNA0+; spf=pass (imf03.hostedemail.com: domain of aleksander.lobakin@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=aleksander.lobakin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692626278; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n2ws8HW6OC6D+ZTB6cUDb9tsT38PdG61d3Wj6Llm6eU=; b=EKaNXV4eoOwjhlkGkutsE+TKsD65H9NA3pp5jL1FCwuvTFv7+GDtNs4WseiGtZHga7iMVC tSFQdpgunEtEHn0ieyKp+VlQ46+Ph7TlRsiDK5p/0jhDU5X4Jkcczb/+aV0J7mWUroPSG8 jT1INY6synT/9BNztZ4kE+40SIJ+7q8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692626278; x=1724162278; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=FaBZM/JNYXW0x5Rmq75xTtJ/7ltuhW1kxcyM164KWW8=; b=n2LwNA0+yudW0PS/9g9pt+BcAvA3uPCFXQhfJ3cbkmLr2LjXSaMIbvF2 t1YSfemu9c8wtuIg73+4NW5Dxt9UHbj8oB0a0w7HXfR+zhWUHz9XeNbTq nRns5dDe2BGEQWMi/3g9d9/36g8pabD3PklPejMNKY0LLH2+AktYPSuyU nRwXfKoH4h3hVy26ATUmKuFTtFSw8Ih7VPwKcgtsp5+WRBxLd852sd0qA G2lz4ZoL7j+25e/KJAleqxtwr/eVyZBZLjxEC3XlO6F5uDyOdreT/p2SF +n+ffiG6U/83lUMWFu0vFNK2bmxrsh2j7Vrn2Bv9TP9wwQ6yz+cNGMGPY Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="376344181" X-IronPort-AV: E=Sophos;i="6.01,190,1684825200"; d="scan'208";a="376344181" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2023 06:56:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="770959176" X-IronPort-AV: E=Sophos;i="6.01,190,1684825200"; d="scan'208";a="770959176" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga001.jf.intel.com with ESMTP; 21 Aug 2023 06:56:50 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 21 Aug 2023 06:56:49 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 21 Aug 2023 06:56:49 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 21 Aug 2023 06:56:49 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 21 Aug 2023 06:56:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kCkJUlhTDLk5Z1NJjXC7klCn74GI5o1FQmZFczVpdlkD2pP9T3LiVR5xxjUtuCebtUAQrRqcPw69GIG8ZkoXO76RLmuuCSVDwWIaKMy2uZZwaMfJyN8kLiuNtD6zxwR7qed128dJB5HzycsP8bCUD9xVduzAsKK02oYNDJY7C/413Eqm2xaQwCxyq9Y732/4ItyW+xR3DOu2wfNT0MG09TBef3ok3NAV4ROR4PZMdxKgPmESeQzQT5aWGSf6LSb9rWK8rJv7X9tD0HfqF3rg4F+Dbe3Sg3J3cupwA4u9T5fyj5B1GLOGYXYRAH2lN+QlwfyPBsht1VqjEHOle5gvNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n2ws8HW6OC6D+ZTB6cUDb9tsT38PdG61d3Wj6Llm6eU=; b=FCxF28Md2HejugXk79sznfHpRveo162Xvo2Z7ng2QFlxFlY+fp+gVScjlw7hhnEkl31D2LAOfMSgmTG1auPSaUwKwaIUDnRKUkx7rlyv1H+b1+fGplUdqQ1pSyHuBGuuQBQNHz7EKQnARxl5BFUvnMqcLiNOwmDfAwkmSu96TYqDRU62NiM4BLPlRletueXWbcC4Er2lQjgUIbCqDiz5yIZzYRrWRwHXM0olIWVTyBLPMdEvxlXF30fvUZxIfE6pOB0hFFcST+PXymqmblfbH0JoYZ8xslu3nINX0N3Z9cckqLrZg7Rd/Ry3CAHITNVU5t7X+bn4WH+SNOtFatt9jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) by CH3PR11MB8752.namprd11.prod.outlook.com (2603:10b6:610:1c2::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Mon, 21 Aug 2023 13:56:46 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::44ff:6a5:9aa4:124a]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::44ff:6a5:9aa4:124a%7]) with mapi id 15.20.6678.031; Mon, 21 Aug 2023 13:56:46 +0000 Message-ID: <7bf42407-7b2f-9824-b2fb-114fb88ace06@intel.com> Date: Mon, 21 Aug 2023 15:55:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH net] net: use SLAB_NO_MERGE for kmem_cache skbuff_head_cache Content-Language: en-US To: Jesper Dangaard Brouer , , CC: Eric Dumazet , "David S. Miller" , Jakub Kicinski , Paolo Abeni , , Andrew Morton , Mel Gorman , Christoph Lameter , , References: <169211265663.1491038.8580163757548985946.stgit@firesoul> From: Alexander Lobakin In-Reply-To: <169211265663.1491038.8580163757548985946.stgit@firesoul> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB9PR05CA0014.eurprd05.prod.outlook.com (2603:10a6:10:1da::19) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR11MB3625:EE_|CH3PR11MB8752:EE_ X-MS-Office365-Filtering-Correlation-Id: 40162fee-4a1c-48c2-3817-08dba24e756c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ibJHG4Y5py8Fa785XS65Nc3i+759Ns2M5I32XWYvZ9MMg0pwJSSzrznU7auNjWkqeJboahJOY8V8LUe0CT7dQa7GxipZ5hILdIxANXAer0zfsaycK1vq5/Hqv+eOJN++SFtAlYJGp1Gzwwu9wwcYcxEEyv3I/OsE7nwHaXG9eUuSm2ndM3MM2QaAXreB6DXk8hXQHnRbz3eTQ7NwAxmwNT//9HBy0bHHmrVfnc+pTDRYsGHE6XQqgXuWYHIob+vomliN2leAcb8FRSliNhIbHXfYL8pDOHOpucHVZxVIwnKQhmd5JABxTD/Sg2CNbm43oH+gNpThcnlwGD7aFK9eK78DJ1OFcsJtfMXBE/1m355dg/FPbeRCz6KZfG5b4Zc6LgHXV91eZerUNRG2tSGeqLF/s2SfPgffm6vztYifAHpulIZyEKfSk7gYS60DhBHWBbTQm9mDGz5hB47u1HhMAFpTwL/36qBdzSaCIxSGdTKKMrrao6EFkPH2Lm/6m6D3YxfkfoEuUyO0od4Bm3NzKkpb1mBp5FrIKIA+pM6R5afb3uCtiKN+MhAQ95+Nw9FCezcejZ1dKv9UTHiSZ2rq+KhXmmLTreysDt7KDe+DK1rohyWA1JeXy3Azmy89gasJXnHvaMNXsvwwbeJt4s73mw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB3625.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(366004)(39860400002)(376002)(136003)(396003)(451199024)(186009)(1800799009)(2906002)(7416002)(38100700002)(6506007)(6486002)(83380400001)(5660300002)(26005)(86362001)(31686004)(31696002)(8676002)(2616005)(8936002)(4326008)(316002)(66946007)(6512007)(54906003)(66556008)(66476007)(82960400001)(966005)(478600001)(6666004)(36756003)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVhIS3RzMnI0UlVhZXNRaUcrNE5NSlRBSk9MSi94cTA4VTBtSXFFd3Y4Vkw5?= =?utf-8?B?cTNGWTVDdllvc0FGd2tKQy9xVGJSTnlrZlJTN3NXUzVkdW0zZ0JNWFhlQlFR?= =?utf-8?B?NmJrS1lWM1U0K0FNZ1Bla1VFQjltdFloSnprVXNwOUJ3OWNOSHdjRWY0cUp5?= =?utf-8?B?cU9ScTZaWkZocEthbWVFcnczY0ZMN1dLU3RGeHcxZXBKSTdKRDhCN05wTlVT?= =?utf-8?B?dnhpRUJKSk81czlvMG1HWnBaREg0VW5NM1JpTm5XT1ZyVjNUYkFvajdYR21x?= =?utf-8?B?Y2VOMjVUOE9VK3FGeXdMTmVMUDdDN3RDNlNkQVhOUm55QjZPdytrWVpEcnBX?= =?utf-8?B?L0RXSXhOb0hYU21ueWVFU3hSOGZheHgvUE1uSDBodC9DOG1nLzJjWWJXUWlp?= =?utf-8?B?am9tRTcvSllUNDlFWG9teGdXSGt3a29ZYVpjSG4zeFJ4ZGxiRy9iUENDdUEr?= =?utf-8?B?M2dSL2pLREZLS2lYWFZ2eGIxUkRKTXBKSDRDNVhVK2ZPejlwZGEvTE43YW5L?= =?utf-8?B?QWFRalJMUk13cVpzZUVFTVZOamRTZEwzVWZ2K3RDRnd6NXJMOVRWY0dReFll?= =?utf-8?B?QlNmcldkMmdBY0w3SHJJQmo3RXdTRmtDdG1Xbm9yTnAzeTdlVzN5OUlaK2t3?= =?utf-8?B?aDNaU2RQRTJGMU9UR1pxTnc1bUZwWlM4eDl4SFRwZkNCZ0VkSUx1SVRCWXcy?= =?utf-8?B?VHEzU2xuVGVSWmcwUWcxYk01UU9QbTBtQlB1MUxYQjkvWmorMWNnQXJnT1Zp?= =?utf-8?B?T0o2TzNnUEpLQlZpbUR6T0txeXUvNlcvN1poSGZJeTlzV1pqVU01K0w3MERI?= =?utf-8?B?ZTZyVWErWlk0WVRMcmpmR3YvUVlrWjBDSW8yUzFzS0FBNXBZRkt0UDFQWmxS?= =?utf-8?B?cEI3ZDdjVTRrQk9mdWNiY0ZsVkp0aURjSDFGOGlCS3l1TUlkY1FBUjFrdm8v?= =?utf-8?B?cHVRY0JGOCtXdUp1M08rNk9mZXhQR3N1eVRDQ1J4eUE1Wks4Q2xVVEhxQnNm?= =?utf-8?B?S0NqNzlxLzRYZzF5L0VMNDhuT1pCZ0dEekFiMnRMR0FhZU5oNE5sOGRPTjcw?= =?utf-8?B?bUsyeGhhM1UrYjc2VXYvZlJlbW02Q3ZRb0QrcElmWUp3VXZPMFJkalc0SmMv?= =?utf-8?B?ZzVvb2VaMzRTbW9Fa3UrV2NYN2l6L2lTQXJYT0djbVowTjdKU2lzWHlLNkN3?= =?utf-8?B?UHlzT0RZOHcyNCtFK3JGL1pyRmZjOUo4aEprN0JRWUY5cUdCQXcxK3dvS1Fr?= =?utf-8?B?MTFtT1JTdnF0NXlwTHFxdDFBR1hHSzhqU2dtT2Y3b3ZDVmI3aDFPNm43U2R6?= =?utf-8?B?WWZvZEIwc0RYY1NnQjVvb2FBTkdWS2w1SzdXUkd3V3BpMkh3U3ZkQzhjbVZE?= =?utf-8?B?b3FnR0FabFo5NG9paDNkYS9xZk92TFBrYnpUN01kejF4aHE1L0hwTjI2Z2Z1?= =?utf-8?B?dzNSNmZsRTI2YWUwQVcxR09ZaTE0cnpUNWlFYzRIZkxMM3drRTR5b3dtd3V5?= =?utf-8?B?RkI4Z2Y1eTE1eGRTUnNmSVFjdUhmRktCUU1PaWk4TE5MMlUyZmlvb3gxaWl0?= =?utf-8?B?OUtwWUhGQWcybWZYN2YwdjhFc2xoK0F1MHFaWWZ5TnptOWQxckxKRURxMGNs?= =?utf-8?B?aVNsazR6eEdxb0dZeWt4SDhNdVBGbVlxYmt6cTU5VzJNc25LKzQ5Z05nNktt?= =?utf-8?B?b1FGMDRxUCtGeThIZHBVZWIvd0lieDN0ZW12dHc3UkxoS2pBTzRMV2FuYVNv?= =?utf-8?B?R1F4bDhtdEEzMDE2NStMKzMwYm50bDZFKzQwSnBDMkQzalNOUEl2NTk2b08v?= =?utf-8?B?eWtpS041V3RDZW9WWVBtNVl1YUpZUnlZY1pFVVcveG0wbmRONktSazVSR28w?= =?utf-8?B?elZaYitPNlJ6TUJKYTZOWTh4T2FiZTY4VStTSi9YT2E4K1pwcE9lNkVOc0cx?= =?utf-8?B?dGpvVGhZdFF2WkJ5S3NBblBwbEN1TlJFRFY1Y25jclBYdDVwZW8xa0d6aWRv?= =?utf-8?B?SVQ3L0d4alprU3ZZU00xTlA5RFpqV2pzRjE3TGt5T1pwazZwYk5raDYwVDZj?= =?utf-8?B?cDNuSlpVU3MrOVZWekVmU2xQdWtpeWdvd1hKcFg2Z1J4UVQ1a3lqZXk5Z3Br?= =?utf-8?B?ODZ3cUc4ODlWUjZQQmxjU1ZkeDh2dXVaaHN4Q0dhd0lidFIxN20rQVA4QXpz?= =?utf-8?B?aXc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 40162fee-4a1c-48c2-3817-08dba24e756c X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2023 13:56:46.6379 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sdmoQ32ED/Lp5HZJb1C1yfqo/g2e4GQtV24TQ9KILoj07nAFrawZsNzr403dIYTfr+k7F7J45O2ZNjjv3B+RncJtbHzPOX7fVXj2OyQJ70k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8752 X-OriginatorOrg: intel.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 78C312001D X-Stat-Signature: osj6ch7aadnfcc5g13pu8y1xdew18wur X-Rspam-User: X-HE-Tag: 1692626277-860352 X-HE-Meta: U2FsdGVkX183HIBuDnd7sgoAvFpZLlRIWot5arxBUm1QhEp+LAEM4JR2GSsG0mEU5QaTNX6F5VVtCZqsWlJkWt/M8o9I2OF43FpkxEr/UFN8besPEH0yYHjHGHhdEWZARZ1tClsApeCV+R2A5ky/WH+swL/DNceo3c3M+OHx6OBcAaTFn0Bt5FHbSLt2OdV4Kycv847coW9QfthVlSk8DzsiG27/1RqHnZA0HBZvbe/gj/tLB9vbxSFnUZ5pVtoE/qDxNZhoLshv5HrPw2C62/OvXvKuRbeXNtPBcDEE8PHcNWBVEl4zsy6QUWnJZEao635TyCNeCHxoJ0veFovZ1hVVidsFsWZiNPPNSlsDBNyAkqAYFlAXHw+ChEl69yf69Z3ZVVhb+r8G0nP573uZdP4jQk4RzTv2aMuStW7T4Js+8Ta7R02+yxh6CV/HKS0hTb0OlHV1Shi0FQObmB8vZuAvCi43zijXkHmfI+jbh2lrbbETTgWghDnF9yHUr8V+mhGIpBGxy818hZFac6TrKFHs2zfkysAausD1sDzCGHZSf6ur3pFZeQ7JuqwbCfi9kYxzLAPWBu/e/scQjhAieAdr3T8z4Rd1VdYRKE68zIx+r41xf7W3Y1ULkoOMhLAl1HJ/if+QcB74N0adG2A3pW5pbCZGJdY/IorRUDUzZJhus0Y86+A3p+NAS6p55HKIXGQcun0nFsg0WjAznqiD2GU6nDVfxlPO1PX7AiC07GQMH+br51z2UMTPl6ORAYZp8GDoIrFKMu19/29wGkykN9eDFPhB242yfMUOTK2NqdDV7KcKRtHzim19w0oq5tujfoD3u/IZR29yRo0OZHGX6kIY3OuFGkXA9GyM5/xikRB64RwOUfD7Nt1PYerMASh7saC8SvaECu6rT627OjyTNGq83ZY5hQq37POMZJInFOS3yDcO+9T4wyvCuJ8rZO7V84N+cFr17FTVukHDkAC NuwPntrE QQBal5EsbI+F9JX+rdraMjXdvxFarjzEylO30z1A6RiM1LVfiPE8SYXLPHH7ZuAMO5jvQExBJ0TKPtWWtygjeREDcpTjrckrwDez2I1Z7tvvYnxK+D1saMrvB2Bm3K3ZD+RQJ0HtmGb1CGfE/+T6DevKGqbalWyNmCmHl/N6AAHU+d/HBAB9gZisi8xMMNU5GNiWA8cF160VLeC84V6uenvfubE4WdJkkirEoSGo7mjcLtGfqZG32QvWYKT7rHbp7UsbVhsLQvRhCYw6LrLGXZvZWPewVmEK+tm96rRQpE/baJGawSPyQrk8PyuRFDgyZbtfycsx4dO3ieEw/9ffk5ty6qLTOgTgjzkibYWP9DSHxiN/ltXx7DS9gy4Tm0zMbLOwfYWXVycFK4iVwneecWdYfC0qgCyjJ6Jj5fW71sIUqp/m6vXxAh2/btVHMdPBlBNV9yOF7s47lCwc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Jesper Dangaard Brouer Date: Tue, 15 Aug 2023 17:17:36 +0200 > Since v6.5-rc1 MM-tree is merged and contains a new flag SLAB_NO_MERGE > in commit d0bf7d5759c1 ("mm/slab: introduce kmem_cache flag SLAB_NO_MERGE") > now is the time to use this flag for networking as proposed > earlier see link. > > The SKB (sk_buff) kmem_cache slab is critical for network performance. > Network stack uses kmem_cache_{alloc,free}_bulk APIs to gain > performance by amortising the alloc/free cost. > > For the bulk API to perform efficiently the slub fragmentation need to > be low. Especially for the SLUB allocator, the efficiency of bulk free > API depend on objects belonging to the same slab (page). > > When running different network performance microbenchmarks, I started > to notice that performance was reduced (slightly) when machines had > longer uptimes. I believe the cause was 'skbuff_head_cache' got > aliased/merged into the general slub for 256 bytes sized objects (with > my kernel config, without CONFIG_HARDENED_USERCOPY). > > For SKB kmem_cache network stack have other various reasons for > not merging, but it varies depending on kernel config (e.g. > CONFIG_HARDENED_USERCOPY). We want to explicitly set SLAB_NO_MERGE > for this kmem_cache to get most out of kmem_cache_{alloc,free}_bulk APIs. > > When CONFIG_SLUB_TINY is configured the bulk APIs are essentially > disabled. Thus, for this case drop the SLAB_NO_MERGE flag. > > Link: https://lore.kernel.org/all/167396280045.539803.7540459812377220500.stgit@firesoul/ > Signed-off-by: Jesper Dangaard Brouer > --- > net/core/skbuff.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > index a298992060e6..92aee3e0376a 100644 > --- a/net/core/skbuff.c > +++ b/net/core/skbuff.c > @@ -4750,12 +4750,23 @@ static void skb_extensions_init(void) > static void skb_extensions_init(void) {} > #endif > > +/* The SKB kmem_cache slab is critical for network performance. Never > + * merge/alias the slab with similar sized objects. This avoids fragmentation > + * that hurts performance of kmem_cache_{alloc,free}_bulk APIs. > + */ > +#ifndef CONFIG_SLUB_TINY > +#define FLAG_SKB_NO_MERGE SLAB_NO_MERGE > +#else /* CONFIG_SLUB_TINY - simple loop in kmem_cache_alloc_bulk */ > +#define FLAG_SKB_NO_MERGE 0 > +#endif > + > void __init skb_init(void) > { > skbuff_cache = kmem_cache_create_usercopy("skbuff_head_cache", > sizeof(struct sk_buff), > 0, > - SLAB_HWCACHE_ALIGN|SLAB_PANIC, > + SLAB_HWCACHE_ALIGN|SLAB_PANIC| > + FLAG_SKB_NO_MERGE, That alignment tho xD > offsetof(struct sk_buff, cb), > sizeof_field(struct sk_buff, cb), > NULL); Thanks, Olek