From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5731C83F1B for ; Thu, 10 Jul 2025 13:59:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8562B6B007B; Thu, 10 Jul 2025 09:59:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DFBD6B0088; Thu, 10 Jul 2025 09:59:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A70E6B0089; Thu, 10 Jul 2025 09:59:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 52EAE6B007B for ; Thu, 10 Jul 2025 09:59:23 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 05C12801DD for ; Thu, 10 Jul 2025 13:59:23 +0000 (UTC) X-FDA: 83648512206.02.756A0EA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 444A340004 for ; Thu, 10 Jul 2025 13:59:21 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MV8Sr+a1; spf=pass (imf07.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752155961; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rYeLrNchx2PmZZA5yhVFjvpxF+gU/27aDh8XMAO01js=; b=tpCPdT6iEtqJsbP2+Aixg8zrYPTFY7BqeMr9b3KTh1XFM3K9MWrDCoBxZb2OGZRtwSgFtH nfkL/ipm/7DeF/6OEwkELQHrf/4CfV/GyCfBpfaAqqxAzNe070xxh93N2U9FVLyj3Z8Ew1 H1GtD4Fh+Vkcyi47MLh97LcmJbAPhKc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MV8Sr+a1; spf=pass (imf07.hostedemail.com: domain of jlayton@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752155961; a=rsa-sha256; cv=none; b=z3n+qj3sQVQ3SNkmVvhJDVWb2vZHNThxMbmfUd/vjQXVtvZXIppJYIB4VBvp+yQh/9VIpf 6keRpIHlfc43HwieFnnjOEx9KD9GzInbe8HWpWwDUTAhc8lrWNYpJw0Ef83dWNpkWdjbRi 1t6yNRVXkXg99Yap45sCfdH/ZUcHDkk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 335C85C6E09; Thu, 10 Jul 2025 13:59:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08893C4CEE3; Thu, 10 Jul 2025 13:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752155959; bh=Sv73T93uupJs0f4PoBOYM5EvEo5cP7R/bj7pcAy2I+o=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=MV8Sr+a1r3vjL8XFhr9V55abj9WlPvTu6yMD/f3n5juKGoeHmRPTwdKW9tcrIuIlx T3lk4sIh70ly2ETukFMTVn54DOpmauxxAHEJ+DRKLIACSSAeTc1D+uNUtvawWLuIfv gWoO1+TZGFfp1axeKmixhbTWcBiRUzhSz9k+9BLr1SkK61mKy5WLAmdx/WA1ceULA0 0GBpd8DBUjb/8nizugCsmQZn+VNjywWD6iVL0fEBi1DORheJIiAZUGYEuU9o6AinjM kNGbN/1881KSnssObgqDOY9EyRQCf6tv+lID4uJVdIrFKiCyE+blYGegG7wqJjYNEk +GigJFl+b0kFQ== Message-ID: <7bea47339a061a9c76612279f565cbd298292105.camel@kernel.org> Subject: Re: [RFC PATCH v2 2/8] NFSD: Move the fh_getattr() helper From: Jeff Layton To: Mike Snitzer , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker Cc: linux-nfs@vger.kernel.org, linus-fsdevel@vger.kernel.org, linux-mm@kvack.org Date: Thu, 10 Jul 2025 09:59:17 -0400 In-Reply-To: <20250708160619.64800-3-snitzer@kernel.org> References: <20250708160619.64800-1-snitzer@kernel.org> <20250708160619.64800-3-snitzer@kernel.org> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-1.fc42) MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 444A340004 X-Stat-Signature: pms5spzmandw599pnrp3f3hm4u34smxx X-Rspam-User: X-HE-Tag: 1752155961-872543 X-HE-Meta: U2FsdGVkX18k3eu8ALd0N0gO54mqSAjzdXFuxQkTse/g5hxrRCspO0icR44OZ7GRu5IVPFzQTygKk5ehF3LfMwEfNS1c8kMG0gf99NOVEVXdr+llw+QqKGBd1WtoObDznSepepiD6p4tLpzazFBh9M871XUILI7IAZrsCYhMpEkYsO1I89kxPlPXs99cHngToNpa7L30TRnUB2jt2gu9qgEB2DzaF5alC0fxfmoJyY3G8Vtf3tj2Rg4XyfbIBNI33fq8mEBZJMQQzWdh0GB05J+EXkcXEoaJ4XBsNBaYMewSha0/RRMryh5SF2pkmXz3g8jAlwg1T7r/IOHic3JqmCh7fpyUDq7gJUbQ5O/+H1pi4qCG6iVrfVU28ND1LXdicv5N4MM4ikF8KGihAvwM5Y+7xIJ5W0BZagf2+p8yF0nDSw8L2xLw/DWcVFvn0OmwW5qTxqTAkgK3CNGKKDV0eLjUBrXkbOqjCh9H20a6wn30ci92hynXe7ISLQnJ9HryhQigs+QO/xHoczKA38mM3yWoMzGYsBtmjcna2pY2ZEAOC1F38Fwn3fbGWQWooUTIli5Bo4lPHnsZjmYqglSd2ii8XYnd8rR8lv2cDcil+l8BYRfVkg8JLItc9c5LT+SBb8dSYihmXdlZrp9Y3oSMZLq+EwbepK1zohniy/WKkVNX5PNtG0fuMteAmREQGt0ibz/Z3APhIWYIjLwYC+QDaXN73zG4CNZQDjUVdQwyxIuEjCK+dP4qbAGRE77P2BNW7UbpV+e1yuGo7OPKLYI0Fy9/XvwpADuoFxpAAmI6oB1MOrK7xNEFeIzjvTldm0qVUBhspAgERK5VNDRvoVFGdlbla2JSDUXyEaSFmLmzcK7CO6uG2xi6wAYvvq4Pmvxe2D88xSiDNbSPaZ/NQzjrm7PlwrTcLqhKr9mnux7lmrkAeNalJQ7FhYPBS0/6dpoXz+b3iZFZHOQE1Livc4H RLxLTnSb 3S+LRw/WTiimOClx3JTmzYsJpYmKkROMbngZGcYZg24/riRWdx3NvZV3ppgjWSoMnaDI58sjfNKCM0dUzYbhNq0koAZ70mmlgm6djlbYfEofqj9PWKO9J9azW1K2wf5gB25QkZk0AwVllmAJR7F/+jc1yn6BhMeAYxO6jh0frV9bHkeeJ2RoSWx/sxtYYqi3pf7crJz918uY0k4A/e/3HOXghuRWKO1nx4dLTxPdpRCt2tDA7FpSdhfmsHjXDRn0IDtyaj9DQMgxulw/fDf6BBEAMzui5qsPi4M6VFuDHYrHjpUdIG2A9HfClAMcVYWDGf92TqsNvRXgh+wnmLUE7CBheBtFtAoc2asdy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 2025-07-08 at 12:06 -0400, Mike Snitzer wrote: > From: Chuck Lever >=20 > Clean up: The fh_getattr() function is part of NFSD's file handle > API, so relocate it. >=20 > I've made it an un-inlined function so that trace points and new > functionality can easily be introduced. That increases the size of > nfsd.ko by about a page on my x86_64 system (out of 26MB; compiled > with -O2). >=20 Weird. I would have expected making it uninlined would decrease the size of the binary not increase it. There are quite a few fh_getattr() calls. > Signed-off-by: Chuck Lever > Signed-off-by: Mike Snitzer > --- > fs/nfsd/nfsfh.c | 23 +++++++++++++++++++++++ > fs/nfsd/nfsfh.h | 1 + > fs/nfsd/vfs.h | 13 ------------- > 3 files changed, 24 insertions(+), 13 deletions(-) >=20 > diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c > index 16e6b4428d55..f4a3cc9e31e0 100644 > --- a/fs/nfsd/nfsfh.c > +++ b/fs/nfsd/nfsfh.c > @@ -663,6 +663,29 @@ fh_update(struct svc_fh *fhp) > return nfserr_serverfault; > } > =20 > +/** > + * fh_getattr - Retrieve attributes on a local file > + * @fhp: File handle of target file > + * @stat: Caller-supplied kstat buffer to be filled in > + * > + * Returns nfs_ok on success, otherwise an NFS status code is > + * returned. > + */ > +__be32 fh_getattr(const struct svc_fh *fhp, struct kstat *stat) > +{ > + struct path p =3D { > + .mnt =3D fhp->fh_export->ex_path.mnt, > + .dentry =3D fhp->fh_dentry, > + }; > + u32 request_mask =3D STATX_BASIC_STATS; > + > + if (fhp->fh_maxsize =3D=3D NFS4_FHSIZE) > + request_mask |=3D (STATX_BTIME | STATX_CHANGE_COOKIE); > + > + return nfserrno(vfs_getattr(&p, stat, request_mask, > + AT_STATX_SYNC_AS_STAT)); > +} > + > /** > * fh_fill_pre_attrs - Fill in pre-op attributes > * @fhp: file handle to be updated > diff --git a/fs/nfsd/nfsfh.h b/fs/nfsd/nfsfh.h > index 6f5255d1c190..5ef7191f8ad8 100644 > --- a/fs/nfsd/nfsfh.h > +++ b/fs/nfsd/nfsfh.h > @@ -222,6 +222,7 @@ extern char * SVCFH_fmt(struct svc_fh *fhp); > __be32 fh_verify(struct svc_rqst *, struct svc_fh *, umode_t, int); > __be32 fh_verify_local(struct net *, struct svc_cred *, struct auth_doma= in *, > struct svc_fh *, umode_t, int); > +__be32 fh_getattr(const struct svc_fh *fhp, struct kstat *stat); > __be32 fh_compose(struct svc_fh *, struct svc_export *, struct dentry *,= struct svc_fh *); > __be32 fh_update(struct svc_fh *); > void fh_put(struct svc_fh *); > diff --git a/fs/nfsd/vfs.h b/fs/nfsd/vfs.h > index 4007dcbbbfef..0c0292611c6d 100644 > --- a/fs/nfsd/vfs.h > +++ b/fs/nfsd/vfs.h > @@ -160,17 +160,4 @@ __be32 nfsd_permission(struct svc_cred *cred, struc= t svc_export *exp, > =20 > void nfsd_filp_close(struct file *fp); > =20 > -static inline __be32 fh_getattr(const struct svc_fh *fh, struct kstat *s= tat) > -{ > - u32 request_mask =3D STATX_BASIC_STATS; > - struct path p =3D {.mnt =3D fh->fh_export->ex_path.mnt, > - .dentry =3D fh->fh_dentry}; > - > - if (fh->fh_maxsize =3D=3D NFS4_FHSIZE) > - request_mask |=3D (STATX_BTIME | STATX_CHANGE_COOKIE); > - > - return nfserrno(vfs_getattr(&p, stat, request_mask, > - AT_STATX_SYNC_AS_STAT)); > -} > - > #endif /* LINUX_NFSD_VFS_H */ In any case, I don't see a real benefit in keeping this as a static inline. Reviewed-by: Jeff Layton