From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7416CC25B75 for ; Fri, 31 May 2024 12:38:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EACDD6B00A0; Fri, 31 May 2024 08:38:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5D986B00A1; Fri, 31 May 2024 08:38:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D25836B00A2; Fri, 31 May 2024 08:38:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B20556B00A0 for ; Fri, 31 May 2024 08:38:22 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2DBDD140C34 for ; Fri, 31 May 2024 12:38:22 +0000 (UTC) X-FDA: 82178644044.13.6BE3F94 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf01.hostedemail.com (Postfix) with ESMTP id 4E23D40022 for ; Fri, 31 May 2024 12:38:20 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717159100; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CrO+EUJ3OxeD3rNJ/hjDUHE3oN2y19xYWckiJsPmQtg=; b=WhAfOPEmFrzfDHXxofrwHadU3IKlTjYLlbLLoy1o0i0UV3gPw3WOYoxV2GpMMtVkRlz7uc XDS/z5e/lY4rCeK6by73rgrVPPQoX/mcl0vSdiligeNpqQgdYj1w1UwYr2/QQ3/RcwjFdL 0YlhieLYZXBIVpiwT4uk8Yve0U/JbL4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717159100; a=rsa-sha256; cv=none; b=mxFF3GyKrFF2nkBjjyLfcF3LKDcQoJ7pnNkglChVHTW29mm4ormkPOoB8pVusZ7T7oadAO vu40uMF3SoTOeb7+YtDvm3n0rvxCyJIpsDuDDyTMiBnU0F4L3C4EbuFPC1a34xYA/ah/+D wzqQAKuM6lnjiEBq6+dMlwKlkiSvHZI= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B32661424; Fri, 31 May 2024 05:38:43 -0700 (PDT) Received: from [10.162.41.15] (e116581.arm.com [10.162.41.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E1F043F792; Fri, 31 May 2024 05:38:17 -0700 (PDT) Message-ID: <7be21e02-9ddc-4fea-9301-6f80eed5ad0e@arm.com> Date: Fri, 31 May 2024 18:08:14 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [External] Re: [QUESTION] mm: Redundant const parameter? To: Chengming Zhou Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com References: <7f7c3bbe-e250-420d-a7d5-89508d881f0b@bytedance.com> Content-Language: en-US From: Dev Jain In-Reply-To: <7f7c3bbe-e250-420d-a7d5-89508d881f0b@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4E23D40022 X-Stat-Signature: d8i7sjt8u8dmw8akdkon857jpkgcqscn X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1717159100-521325 X-HE-Meta: U2FsdGVkX18sRXDbRKgVR0NqH37P9Lva7G2kIstjZF1tKmXkzUXyyPDUsz/f5Ubeed8HEhVQnhtzBTaxnlnkSZOijINBHbqpJHfkbQNJJXMJoL1hfG3af+KogrgTIwgNtPsWljjjapfUoYVe2npxyFb4vm6FPZ8Rpsu7QrQIGzh3wa2haQcZS9wRwMPUAvzt4YRanA+r22TS6IhYYbnLFxaRTKEfjtTwDWDpXaViErc5uSg7dzlYTJ5FI3lyFyhgo8hXstZZGsDm0EEGmbGRElos9aixnn7rXpYF4kHhB9ik5OO26leJBSkiPtyC5j6f8eVY3eZaA3jYDPYG3cE9RqbtYkETB3PrGHTMRy4uRocWX0CbkTTlc4/S42TkJCpJUW1ZKR6KF2DkqvyTKMGzWG7DBecBPxaeLkzVqzQQwDMiF2CP/gzfwnwbjGMctEUGSiPRTRn3pB+lYrLheVfm3PVilb4JBldra++rezCFNTDZ8OFeaHtqx+l1g+4cBhErqKDQWaMC3YATsbN36Uz6wiCdOF4CSYoL//RLaroLLI9XpUxd1qcEbrGTHI2kwz9jIyI2gE0F6Z2Bc4c5J/6ZhgpjSpIKOenTNPF1RFS6nUpin7+BV39O1RKpntbiXLJAdba2OqCb+Oh+nZ+OVv1r6cefC8UxyFfrvvqQ9PmxDDQFoFPbmoYbZbsIwx7Dp/A57D5RVYsubWAI2Yzw/PrnAsX/gjtQK/XCgOfrJBm9QAP8kKM85xUPc+9vQT8wAWzGM8xZETRFYXaAq/FbIJJJfQgJ5qi0/BuPQ8fyrrTv/SmrurHJMD7NjyrY5bGTL5c6ENDhrBC1qqaibv/0ysyAN9heP/pdx5Q0CCwSm7JUinEV45j0hoHVo1kZZ5vNCK/lWD01r7J2wVadR79bn/sPnVA8gtSCt5SdsOqGVcJKOXEN5vJsjW0csTIOZSdGmAAn4ZJg4umw6mkWeeS+qht R2IC+YZo 3LW37r59J0OnmyHrJOAxQFDXyFl9BOB6/6pa1nubyM9HOYjq+o8qw6mvQvYUD5d2S9B9dENrM2+h9Q0OQ1hO/Rs+3oRV7Bl1lcj1pYea6B0ipSNcbMgaUyh1veE3eHVf7Z6fC6anJ7lycXw9oNy72qnBQsXslm07cyMeueCYBu+0WS1NW7qBeNpK+YUsIhckRfyd2qVWpwlyLQx4UXIXXwqmHWBNJZkUNossXvXv/B5qN1NiIYpFbySW0QXlFeFy2S8wKB8jR2BXWdzyBQ2mmdg178GuCPto9whsLTGILNSs819ryezB2IinLpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Yes; Matthew just did a wider fix: https://lore.kernel.org/all/20240531122904.2790052-1-willy@infradead.org/ On 5/31/24 18:00, Chengming Zhou wrote: > On 2024/5/31 19:31, Dev Jain wrote: >> I guess it would be better if I send this as a patch and wait for comments. > Ah, you're right. I think it should be: > > return folio_test_workingset(slab_folio(slab)); > > Right? Don't notice there isn't any build warning about this "const" discard. > > Thanks. > >> On 5/31/24 16:42, Dev Jain wrote: >>> Hi Chengming, >>> >>> In mm/slub.c, you had defined slab_test_node_partial() to take a const parameter. >>> >>> Is there any point of taking in a const, when you are anyways typecasting it to >>> >>> a (struct folio *) from (const struct folio *) ? In fact, at the place where you call >>> >>> slab_test_node_partial(), the struct slab *slab is not const. >>> >>> Please comment. >>> >>> >>> Thanks >>> >>> DJ >>> >>> >>> >>>