From: Dev Jain <dev.jain@arm.com>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Anshuman.Khandual@arm.com
Subject: Re: [External] Re: [QUESTION] mm: Redundant const parameter?
Date: Fri, 31 May 2024 18:08:14 +0530 [thread overview]
Message-ID: <7be21e02-9ddc-4fea-9301-6f80eed5ad0e@arm.com> (raw)
In-Reply-To: <7f7c3bbe-e250-420d-a7d5-89508d881f0b@bytedance.com>
Yes; Matthew just did a wider fix:
https://lore.kernel.org/all/20240531122904.2790052-1-willy@infradead.org/
On 5/31/24 18:00, Chengming Zhou wrote:
> On 2024/5/31 19:31, Dev Jain wrote:
>> I guess it would be better if I send this as a patch and wait for comments.
> Ah, you're right. I think it should be:
>
> return folio_test_workingset(slab_folio(slab));
>
> Right? Don't notice there isn't any build warning about this "const" discard.
>
> Thanks.
>
>> On 5/31/24 16:42, Dev Jain wrote:
>>> Hi Chengming,
>>>
>>> In mm/slub.c, you had defined slab_test_node_partial() to take a const parameter.
>>>
>>> Is there any point of taking in a const, when you are anyways typecasting it to
>>>
>>> a (struct folio *) from (const struct folio *) ? In fact, at the place where you call
>>>
>>> slab_test_node_partial(), the struct slab *slab is not const.
>>>
>>> Please comment.
>>>
>>>
>>> Thanks
>>>
>>> DJ
>>>
>>>
>>>
>>>
next prev parent reply other threads:[~2024-05-31 12:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 11:12 Dev Jain
2024-05-31 11:31 ` Dev Jain
2024-05-31 12:30 ` [External] " Chengming Zhou
2024-05-31 12:38 ` Dev Jain [this message]
2024-05-31 13:20 ` Matthew Wilcox
2024-05-31 12:17 ` Matthew Wilcox
2024-05-31 12:24 ` Dev Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7be21e02-9ddc-4fea-9301-6f80eed5ad0e@arm.com \
--to=dev.jain@arm.com \
--cc=Anshuman.Khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox