From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F606C2BB41 for ; Tue, 16 Aug 2022 10:11:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3BF36B0073; Tue, 16 Aug 2022 06:11:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC4128D0002; Tue, 16 Aug 2022 06:11:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B64988D0001; Tue, 16 Aug 2022 06:11:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A1C2E6B0073 for ; Tue, 16 Aug 2022 06:11:24 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 70A05C075E for ; Tue, 16 Aug 2022 10:11:24 +0000 (UTC) X-FDA: 79805038488.19.D5B0639 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf18.hostedemail.com (Postfix) with ESMTP id 9FC3B1C003B for ; Tue, 16 Aug 2022 10:11:23 +0000 (UTC) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4M6Rfm016PzkWQK; Tue, 16 Aug 2022 18:07:59 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 16 Aug 2022 18:11:19 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 16 Aug 2022 18:11:19 +0800 Message-ID: <7bdc252f-15dd-8d92-9e08-1ba7dd8308ad@huawei.com> Date: Tue, 16 Aug 2022 18:11:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH RFC] mm, proc: add PcpFree to meminfo Content-Language: en-US To: Greg Kroah-Hartman CC: Andrew Morton , , , Liu Shixin References: <20220816084426.135528-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660644684; a=rsa-sha256; cv=none; b=WMXDiftW9ZJ/3GXWvddscaTQX+HM6RXsSm3xMry7SJd3zxY0j0xFdwo82gNLRDRGWnt+j5 rbYJHOiYEwxiYphBfNZ0FhQfQpyaB7v/RDHzu4bNQP9YCSretPR/xg3Kbo20AIgFqoR8sb XlcNbkdLCATpMlDn+6uH1WAlXb1dVyU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660644684; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L5vzr6eYCaouLyGEPFdz94vvoS6o2lbpY0/keogODpA=; b=mARFDYO0sAxj6c/Q6n+3nojtlVIjkzDTGKrFsTR2GwaiUrRZrFfTLHV3e1Ay+amfu5Egk+ RerJ2CCU9Vgo16ACjaw63waBgw39CP1pgFizVa+KLNQ01SI4KThk5PW8PQE7clTjjHuVNM PFgJYI3jzPLGCKXSLF62+UPD/LJW5MA= X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9FC3B1C003B X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Stat-Signature: 74thc17sy9ptishpweqjoerc3mpy7idk X-HE-Tag: 1660644683-219227 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/8/16 17:16, Greg Kroah-Hartman wrote: > On Tue, Aug 16, 2022 at 04:44:26PM +0800, Kefeng Wang wrote: >> From: Liu Shixin >> >> The page on pcplist could be used, but not counted into memory free or >> avaliable, and pcp_free is only showed by show_mem(). Since commit >> d8a759b57035 ("mm, page_alloc: double zone's batchsize"), there is a >> significant decrease in the display of free memory, with a large number >> of cpus and nodes, the number of pages in the percpu list can be very >> large, so it is better to let user to know the pcp count. >> >> Signed-off-by: Liu Shixin >> Signed-off-by: Kefeng Wang >> --- >> drivers/base/node.c | 14 +++++++++++++- >> fs/proc/meminfo.c | 9 +++++++++ >> 2 files changed, 22 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/base/node.c b/drivers/base/node.c >> index eb0f43784c2b..846864e45db6 100644 >> --- a/drivers/base/node.c >> +++ b/drivers/base/node.c >> @@ -375,6 +375,9 @@ static ssize_t node_read_meminfo(struct device *dev, >> struct sysinfo i; >> unsigned long sreclaimable, sunreclaimable; >> unsigned long swapcached = 0; >> + unsigned long free_pcp = 0; >> + struct zone *zone; >> + int cpu; >> >> si_meminfo_node(&i, nid); >> sreclaimable = node_page_state_pages(pgdat, NR_SLAB_RECLAIMABLE_B); >> @@ -382,9 +385,17 @@ static ssize_t node_read_meminfo(struct device *dev, >> #ifdef CONFIG_SWAP >> swapcached = node_page_state_pages(pgdat, NR_SWAPCACHE); >> #endif >> + for_each_populated_zone(zone) { >> + if (zone_to_nid(zone) != nid) >> + continue; >> + for_each_online_cpu(cpu) >> + free_pcp += per_cpu_ptr(zone->per_cpu_pageset, cpu)->count; >> + } >> + >> len = sysfs_emit_at(buf, len, >> "Node %d MemTotal: %8lu kB\n" >> "Node %d MemFree: %8lu kB\n" >> + "Node %d PcpFree: %8lu kB\n" > First off, this sysfs file is a huge violation of the normal sysfs > rules, so I will not allow any new entries to be added. In fact, the > whole thing should just be removed and multiple files created in its > place. Hi Greg, do you mean to remove all /sys/devices/system/node/node*/meminfo, but this will beak ABI, is it acceptable? > > Can you send a patch to do that instead please? > > thanks, > > greg k-h > .