From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17066C64ED6 for ; Wed, 1 Mar 2023 04:38:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EB536B0071; Tue, 28 Feb 2023 23:38:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 89BCE6B0072; Tue, 28 Feb 2023 23:38:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7630C6B0073; Tue, 28 Feb 2023 23:38:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 664686B0071 for ; Tue, 28 Feb 2023 23:38:18 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 38195AA62B for ; Wed, 1 Mar 2023 04:38:18 +0000 (UTC) X-FDA: 80519072676.08.1D05EA8 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by imf09.hostedemail.com (Postfix) with ESMTP id 27D27140006 for ; Wed, 1 Mar 2023 04:38:14 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DFkgiwwM; spf=pass (imf09.hostedemail.com: domain of ecree.xilinx@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=ecree.xilinx@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677645495; a=rsa-sha256; cv=none; b=tskPCygjmzI6qstlQTv43jl3XZoHaZzVwvlf9ANtNoBBDyMjYJMdKK0fCCJhkYfsleIzaR CdGyBVo/N0GZJ6GrwO7+eqjsg7tBUZ66hjwUWj+YqZdwnC1G8ah49EY6fBjZdcUB4zquIC BUojN74PyiXNKUN5Q8Wi6r80OuR37Zc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DFkgiwwM; spf=pass (imf09.hostedemail.com: domain of ecree.xilinx@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=ecree.xilinx@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677645495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iGJPeH0r7xdEaYTJzJa7w1hRBmNpRDwnHXG8dM1Fi/8=; b=1hsJYHDFql327ICPqF+R1IAZeY1ToTKWqwrR7ffCNdhM4YaW5RH8thV8r0is28c7CjqtUr E+zF4UftN/J9fSsjdmEYqLnalUXIABjJoHwshIZlAeJjGUN32U6EH2j4imcGvMSDw5g8dm f2chveKGUgZDQoGOVVCuByI+j8eO1LM= Received: by mail-wr1-f46.google.com with SMTP id l1so8864025wry.12 for ; Tue, 28 Feb 2023 20:38:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=iGJPeH0r7xdEaYTJzJa7w1hRBmNpRDwnHXG8dM1Fi/8=; b=DFkgiwwMhK+5PJqOSgpPSKTngPQSY2UCT674oq6b9cyIrdrAk/eFMPKzpXxAIyU2mu AIMVErKA5nZWJ3wD8mx7LGgpKD/41iyjWqIcH59c+EiRJJdzAwSPBWx7UO39UnVQ//Db pDQhwa3j/09Z+VPJzZ9qZnnueCsDjit6+GxcDcNGGBZnoDkyxUmzcM9LpdjFsVuPhCMg Pn/vqPoGz0RLuhzpxtqYIfmX+SUxQk+WUTbPXVLxLWQ8XksU3r3yg2yKs1cvcUNfk/8r WHl+ZnqvX9Dy4JY5JTkBQPOfvpCf1+/e5aVvofM8BmoIuxHtoOImKJMYsOP2O/mRx63r kEow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iGJPeH0r7xdEaYTJzJa7w1hRBmNpRDwnHXG8dM1Fi/8=; b=ET+QqwwgGeUxQ0/GzMRTGk7fxYoLtUTA/YgAyqntdtuLS5+NuWNtlWaZYUAaCzL96j yny2p2KiY0P7llDUozOCCbdWSLgIT01qzdZWpEsTCDpStFfxtdO9hpdK29zydmTBZwwb 6+5eRsEuqW2FiZWPyHEpdTstnL4rEfrCEWjaQwiAB4hV6RWCq/RJVgSYTiS3RVrcy8qJ 9s8bMp1m3Gwr9DOQqnPHs3Kj/or2Xel16JNwIgnmTkKQg/wiEzAUQGA+WHThWn4DWyGn HtN3fVN/35cEXcr6lghvHKsSTy0pZdpUo49vrPLYipG373XSifwFDR+gumC7D0OaAeAw N31w== X-Gm-Message-State: AO0yUKWVAqilWdnjyNhzq9kotdtf5mY/0Z9ngD2fvghkY7J0P0mU+22D EjocsevzoLn2WD4oifoN8k8= X-Google-Smtp-Source: AK7set+gUptp4vTi5bsWAxrQuCAD1OMXyp9cGvDDgba6mo1W7tgWi8r8vzfAV/1dNQguTi11mFakdQ== X-Received: by 2002:adf:e54b:0:b0:2c7:169b:c577 with SMTP id z11-20020adfe54b000000b002c7169bc577mr3859807wrm.19.1677645493423; Tue, 28 Feb 2023 20:38:13 -0800 (PST) Received: from [192.168.1.122] (cpc159313-cmbg20-2-0-cust161.5-4.cable.virginm.net. [82.0.78.162]) by smtp.gmail.com with ESMTPSA id r14-20020adff70e000000b002c567881dbcsm11442126wrp.48.2023.02.28.20.38.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 20:38:12 -0800 (PST) Subject: Re: [PATCH v5 01/17] asm-generic/iomap.h: remove ARCH_HAS_IOREMAP_xx macros To: Baoquan He , linux-kernel@vger.kernel.org Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@ACULAB.COM, shorne@gmail.com, willy@infradead.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, netdev@vger.kernel.org, Martin Habets References: <20230301034247.136007-1-bhe@redhat.com> <20230301034247.136007-2-bhe@redhat.com> From: Edward Cree Message-ID: <7bd6db48-ffb1-7eb1-decf-afa8be032970@gmail.com> Date: Wed, 1 Mar 2023 04:38:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20230301034247.136007-2-bhe@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 27D27140006 X-Rspamd-Server: rspam01 X-Stat-Signature: me9m345f1adj6zie84i6w6maef4a4t95 X-HE-Tag: 1677645494-985368 X-HE-Meta: U2FsdGVkX1/ZtT6R6gF60jbUVen+W4Ln/oCkUCjaASlawoErpoqMEyJ0kMQ9hbWbhcoOiIeWbfqqFmeuKgpNrO1/uTa5dz/ta4Wj5wRKKffwBZbf0yX+Jv4TGTHDIzPscxbv/sQ7AQpaMNgmaGW+TSz958460Q6ooLby61YKoHmCe3yFnL/C7Dblbm6ZWR7yEMOQxYzPss9vFHJJQd5HAo2d2AvH2Fyo11LmIjdhJnkKy7fQ07y0b71MTVzr/JAXN8RjWo1cAz91hNbip1P5kGI2T5Qdpmc8LQ6N2aWUMeYxArbLs5MHTJDB0JDJhEMtyHSSjWPO4zrsPiJ7yyiIiWiUtnO9hzc8Gtd6EfjOT5TTB2MQubv63KU/DRCtefJycTfIQt9V9dxTzxriTTqsq1vLWuFKA5OHiZhwEfRetOGREv4uo3BftHSlY0ejAkaX4GUjIBG7FsZe6zyCDMc8rDLWa3oBrV1aAkJYFMqUydoYd2fxOMM8vrOCg2D/cT8LEpyHA5yNuw0UkFldqekOV9hXEjObo3YxT+IYtZfWf0VncRv6zoZPsdTGL2qJeU3hyGTru1nwZFwobF/MMmMZ6S5rAQ7DrnjYgNzLad9SghKKnUFmbeIQdTXaRasEJqX4bzpdyPRTOq3817WMOaUN/VO4LWrUHVBlVxGVCPCnLgtIyYavuFrE1FDgVwI5yuNNno2YE+KpyW3Uh3dajxqN4Hrh02ShPUfAZ/aFumTKxKZnXDgwawdECTkekrKVnuhWcBWmIzOHmO/iH0XfcjN5pVRLq7wfjfOr38C9XsHvLJd+PVEmvnn4Qemt2qmcQwr2X3MvLXkJhzW6ssPUT5OsdLhotg2KXC6zhiRmetiMCMkYGBvpArjGtoCS42miYEZhjySesDbo1Sz59POK2MrtiK6v7SYMqDZ56fgXkF8VbNG48pxT5drQnGnHOnQJoaHD2SD/mWpAe/bf/+HHZWD +bB22t7f Z0uC702FBZ+977VizxI/+UzVh1xlwvsJhvQ4vp9Cu11Bbd4SvB+FeD2CmmBKYpfVdYCRoHfEgjc2a0kdzTfbRJ8SBHEiCu14dgVVRNtRvoHk08EwT6lm0KERTWP1VQVFDevYjiHqvDZ3ek5fLXvh0Ovld4OAIp7qcBc4aeM90AS/QwxLs+5s/eO42pwyTa6oiGADxSDvhdxpO4imZ6qlZnSc1o4En4qLZo6QC/5LQulp/u156w/MDoeLDDWmfNFeHp5cHO81cdEza7KunSDNG851f2Zri/D+rIHN5kag5vhpigjMbeIPJJ4+4iTpvK3Bw0yf1chJ/F0ay/vKyFnVpGZRgk5gyPx4vjGSPmmOrexmoMPYluaDuX1xp7G2M9xjW/3wch+GN/RxJ3tueguB0/FDo8Sb9KWpfrlHgQ3ogDbPWUaZ+B+QHuDaCWt0EUzFx+YQitVdBsDC7ea6zrFK+XhdIt0aLeVSTbmY2R/u0G3CbxO5gc4ig9otGabvYHrXlH9Fm8boMzNhAGx64VUOr1pk0EaASyRL7mHK/K72Xwv7J7Zy851JeabJ+jz2ITXnQ4rVq1Ap/xF2vLd2wh3iutMGQDPUbShBgFsoZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01/03/2023 03:42, Baoquan He wrote: > diff --git a/drivers/net/ethernet/sfc/io.h b/drivers/net/ethernet/sfc/io.h > index 30439cc83a89..07f99ad14bf3 100644 > --- a/drivers/net/ethernet/sfc/io.h > +++ b/drivers/net/ethernet/sfc/io.h > @@ -70,7 +70,7 @@ > */ > #ifdef CONFIG_X86_64 > /* PIO is a win only if write-combining is possible */ > -#ifdef ARCH_HAS_IOREMAP_WC > +#ifdef ioremap_wc > #define EFX_USE_PIO 1 > #endif > #endif So I don't know how valid what we're doing here is... > diff --git a/include/asm-generic/iomap.h b/include/asm-generic/iomap.h > index 08237ae8b840..196087a8126e 100644 > --- a/include/asm-generic/iomap.h > +++ b/include/asm-generic/iomap.h > @@ -93,15 +93,15 @@ extern void __iomem *ioport_map(unsigned long port, unsigned int nr); > extern void ioport_unmap(void __iomem *); > #endif > > -#ifndef ARCH_HAS_IOREMAP_WC > +#ifndef ioremap_wc > #define ioremap_wc ioremap > #endif ... but it looks like this will break it, since in sfc/io.h `#ifdef ioremap_wc` will always be true (if I'm correctly understanding what we get via #include , which I'm probably not because asm includes always confuse me). I.e. we're not just interested in "can code that calls ioremap_wc compile?", we care about whether we actually get WC, because we're making an optimisation decision based on it.