From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E9C0EB64D9 for ; Mon, 10 Jul 2023 08:26:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD2DC6B0072; Mon, 10 Jul 2023 04:26:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C83B96B0074; Mon, 10 Jul 2023 04:26:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4B706B0075; Mon, 10 Jul 2023 04:26:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A17216B0072 for ; Mon, 10 Jul 2023 04:26:58 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6C6B11C7F54 for ; Mon, 10 Jul 2023 08:26:58 +0000 (UTC) X-FDA: 80995021716.08.4815F26 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf12.hostedemail.com (Postfix) with ESMTP id 2142C40004 for ; Mon, 10 Jul 2023 08:26:54 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688977616; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JIlQrztBEBLiOAeN0D+sJ91erADB/kMpZwsYoBIdcAk=; b=6xzrBRN+fqNbCJpuTN44+QJZ03KDo6lvJaaK0LiZp5X8rKb8HsS5h/2IIPAALT+VshhHlj 05p7YGlos2ANeRp0RAN+i6EFnrLDrH3uBX6z8bdr/6y3p6VNncSygpOvWnVQrqB2R7sO5G nEKOTmIpwCcujnSAVpdbszzCXvAkQdU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688977616; a=rsa-sha256; cv=none; b=VOpLvh0qo+oCqvcrT+AAbvGapouNbfSscsW8htsI7QgH9zaI1teCL44AE/+9SklYoxIB4O f8FG7GDq+hzi8RIOQLaS2g+/Px+j5sSoYRM/eFD8uLbkbeT3Q7HDZNmzFs64yWu5rCVify OnAkpId8E+mFllWXrJjbaW7dDp8R+wg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QzxqF5h42ztRB6; Mon, 10 Jul 2023 16:23:53 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 10 Jul 2023 16:26:50 +0800 Subject: Re: [PATCH 1/8] mm: memory-failure: fix potential permanently locked hpage To: Naoya Horiguchi CC: , , , References: <20230708085744.3599311-1-linmiaohe@huawei.com> <20230708085744.3599311-2-linmiaohe@huawei.com> <20230710075607.GA1686200@ik1-406-35019.vs.sakura.ne.jp> From: Miaohe Lin Message-ID: <7bcbe787-745f-31f4-a75f-b1d4b16d5f03@huawei.com> Date: Mon, 10 Jul 2023 16:26:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20230710075607.GA1686200@ik1-406-35019.vs.sakura.ne.jp> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Stat-Signature: iduscnjnkfnzi5ygghwd4wjfgumqcwiq X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2142C40004 X-Rspam-User: X-HE-Tag: 1688977614-427041 X-HE-Meta: U2FsdGVkX1/DgSlWN/ieKZ79FBVzufDr8NJFzT/D5YEsnojZ38m3q2Hp3fogygs9xn2J5xVP5fqJCFGgoumqcZpS0W3ohiPWhaG6Kx+I80tEW6qKnz9du++HC8fz31Cs6oKvLUxIuDTa8q9qrsVrEWKH4PLtXQGwMoNfUXdflmQxum36jjtWprCoggkLjK8klj/d50V4xt5oDsoI7ricxUNwBhjrB8NwGqrVTltsKoJ9yh3uyZfAoaO03pwAw/rFov3601ZUeQGfAC63lEm5YvXgRQ36tJN/eoobF/d+RfF9bbA1QfyU181hzX90mKESaVgTTKABCe3UK55D9/Th9th+4pfju0JjaA9O2zBRhU+4b3qYMRPS5tJrIn4A+JvGFR0lLnTfi/i3rQvqq4nEJKCbCzi294R2yF6wr1uTMQAA3vc9hhZiIZ/POCh1TZdgs+wf0gMM+YdOkQEFJm/QM4d7Q2fFTMTP1fm7UMYASgUNzc86nIs1Res7rDl4ww9laTitpYEpiaLuom7/0YRBJo3/JLi4Sj5AD6kCsgErbNVRzgBkfL/T8WiynujGlBAOxsDM538Ygi5Mt1S8P6eswa1IvmlvuUb/0bmRINRpX1d5qXV9t6cFA+MkmxO83nFMpUFmmpm6+ZL8izuaC+xYV65tI3nrqa1IHs9nP6aFWOT+pLsFO6/z/Va2k2jvCYdZ+WyNnD4t1+QVuYpK8r8UO1ayta4055JDf9ysEUBt/CY6mrg9umVAk85VQnw4LWO59S/UW1i0nJrf+nQw/wgLOzNzU9AlnK8arIZKV/diBzRbdLkJbS435WXTl017WV9Xcgg9na9F1FuDOmSwAzJLc5XEajAvgslpTIR1gsU0fdVC7LHRwuH5aA4if4BaffUT2TKJAuENjICLAYHWk6Ecd4rkRkUNyY1S85/s5Ta9ypRjQ71bxoZOqB+wB+hiIPX/Ns3e1lACSOJjaemEyl/ BEZpxxcp Qn367UjeVqioEGmD6IYlGOdUFVcpdAexHDn2WlUyGcNLleMQ1J9jjCFqcjFjx6fKXE36qo+MRvBLg3FiEdCZwlFPK+1SFamzmVdRIFJTFmV7bdjreFrszMs26eQGjWtOxjgG8OsxPdcjhZWpaTMAYf8VXFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.008040, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/10 15:56, Naoya Horiguchi wrote: > On Sat, Jul 08, 2023 at 04:57:37PM +0800, Miaohe Lin wrote: >> If hpage isn't Hugetlb page, MF_DELAYED is returned without unlock hpage >> leading to hpage permanently locked. But this shouldn't trigger in the >> real world because this PageHuge() check is just for potential problems. > > Right, so this if-block is dead code, how about simply removing it? >From the current code of view, I think this if-block is actually dead code and won't catch anything too. So removing it makes sense to me. Will do it in v2. Thanks Naoya.